sneak
a10d031669
check / check (push) Waiting to run
Each `go mod download` in the Dockerfile now runs under a 180-second time limit and is tried up to three times. Without the limit, a stalled connection to the module proxy held the step, and every build on the host sharing it, until the kernel dropped the connection. When all three attempts fail, the step prints "module download failed" and exits 1, so the build stops there and does not look like a test or lint failure. The loop is repeated in each of the three stages because a Dockerfile cannot share shell code between stages. A test checks every download step for the limit, the retries, the message and the final `exit 1`. Judgement call: 180 seconds and three attempts, against a normal download of 13 to 24 seconds. Deviation: REPO_POLICIES.md's model Go Dockerfile still shows a bare `RUN go mod download`. Model: opus-5-5
46 lines
1.5 KiB
Go
46 lines
1.5 KiB
Go
package main_test
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// TestDockerfileBoundsEveryModuleDownload fails unless every
|
|
// `go mod download` in the Dockerfile runs under a time limit, is tried
|
|
// a fixed number of times, and then fails the build with a message that
|
|
// names the module download (issue #351). Like the version tests, this
|
|
// parses the Dockerfile; that a stalled download really is cut off and
|
|
// retried was checked by hand.
|
|
func TestDockerfileBoundsEveryModuleDownload(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
var downloads []string
|
|
|
|
for _, instruction := range instructions(t, productDockerfile) {
|
|
if strings.Contains(instruction, "go mod download") {
|
|
downloads = append(downloads, instruction)
|
|
}
|
|
}
|
|
|
|
require.NotEmpty(t, downloads, "%s must download modules",
|
|
productDockerfile)
|
|
|
|
for _, download := range downloads {
|
|
assert.Contains(t, download, "timeout 180 go mod download",
|
|
"%s: a module download must have a time limit: %s",
|
|
productDockerfile, download)
|
|
assert.Contains(t, download, "for attempt in 1 2 3",
|
|
"%s: a module download must be retried: %s",
|
|
productDockerfile, download)
|
|
assert.Contains(t, download, "module download failed",
|
|
"%s: a module download that never succeeds must say so: %s",
|
|
productDockerfile, download)
|
|
assert.True(t, strings.HasSuffix(download, "exit 1"),
|
|
"%s: a module download that never succeeds must fail the"+
|
|
" build: %s", productDockerfile, download)
|
|
}
|
|
}
|