check / check (pull_request) Successful in 2m52s
A chunk is registered as pending (known, scanner-pending, packer pending-row) before it is packed. Under --skip-errors the scanner skipped a file on any processing error, including a failure inside addChunkToPacker (packing, database, encryption, upload). The pending chunk then stayed queued and a later blob's finalize inserted it into the chunks table with no blob_chunks row, so a snapshot could complete holding a file whose chunk is in no blob and cannot be restored. Errors from addChunkToPacker are now marked and abort the run regardless of --skip-errors; only open and read errors are skipped. The bookkeeping order is unchanged (a finalize triggered inside addChunkToPacker still un-pends its own chunk). Flag help and comments now say only unreadable files are skipped. Model: opus-4-8
146 lines
4.5 KiB
Go
146 lines
4.5 KiB
Go
package cli
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/adrg/xdg"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
// errConfigNotFound is wrapped by all config-resolution failures.
|
|
var errConfigNotFound = errors.New("config file not found")
|
|
|
|
// RootFlags holds global flags that apply to all commands.
|
|
// These flags are defined on the root command and inherited by all subcommands.
|
|
type RootFlags struct {
|
|
ConfigPath string
|
|
Verbose bool
|
|
Debug bool
|
|
Quiet bool
|
|
SkipErrors bool
|
|
}
|
|
|
|
//nolint:gochecknoglobals // cobra persistent flags bind to package state
|
|
var rootFlags RootFlags
|
|
|
|
// NewRootCommand creates the root cobra command for the vaultik CLI.
|
|
// It sets up the command structure, global flags, and adds all subcommands.
|
|
// This is the main entry point for the CLI command hierarchy.
|
|
func NewRootCommand() *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "vaultik",
|
|
Short: "Secure incremental backup tool with asymmetric encryption",
|
|
Long: `vaultik is a secure incremental backup tool that encrypts data using age
|
|
public keys and uploads to S3-compatible storage. No private keys are needed
|
|
on the source system.`,
|
|
SilenceUsage: true,
|
|
// Bare 'vaultik' (no subcommand): print help. The banner is
|
|
// printed once at process startup by Entry, before cobra
|
|
// parses arguments, so it appears even when cobra rejects
|
|
// args (e.g. "requires at least 2 arg(s)") and on --help.
|
|
Run: func(cmd *cobra.Command, _ []string) {
|
|
_ = cmd.Help()
|
|
},
|
|
}
|
|
|
|
// Add global flags
|
|
cmd.PersistentFlags().StringVar(&rootFlags.ConfigPath, "config", "",
|
|
"Path to config file (default: $VAULTIK_CONFIG or platform config dir)")
|
|
cmd.PersistentFlags().BoolVarP(&rootFlags.Verbose, "verbose", "v", false,
|
|
"Enable verbose output")
|
|
cmd.PersistentFlags().BoolVar(&rootFlags.Debug, "debug", false,
|
|
"Enable debug output")
|
|
cmd.PersistentFlags().BoolVarP(&rootFlags.Quiet, "quiet", "q", false,
|
|
"Suppress non-error output")
|
|
cmd.PersistentFlags().BoolVar(&rootFlags.SkipErrors, "skip-errors", false,
|
|
"Skip files that cannot be read when creating a snapshot, or "+
|
|
"that cannot be restored when restoring, instead of aborting "+
|
|
"(packing and storage errors still abort)")
|
|
|
|
// Add subcommands
|
|
cmd.AddCommand(
|
|
NewConfigCommand(),
|
|
NewPruneCommand(),
|
|
NewSnapshotCommand(),
|
|
NewInfoCommand(),
|
|
NewVersionCommand(),
|
|
NewRemoteCommand(),
|
|
NewDatabaseCommand(),
|
|
)
|
|
|
|
return cmd
|
|
}
|
|
|
|
// GetRootFlags returns the global flags that were parsed from the command line.
|
|
// This allows subcommands to access global flag values like verbosity and config path.
|
|
func GetRootFlags() RootFlags {
|
|
return rootFlags
|
|
}
|
|
|
|
// ResolveConfigPath resolves the config file path from flags, environment, or default.
|
|
// Search order: --config flag, VAULTIK_CONFIG env, XDG config dir,
|
|
// /etc/vaultik/config.yml.
|
|
// Explicit paths from --config and $VAULTIK_CONFIG are checked for existence
|
|
// so the user gets a clear error instead of a downstream YAML parser failure.
|
|
func ResolveConfigPath() (string, error) {
|
|
if path := rootFlags.ConfigPath; path != "" {
|
|
_, err := os.Stat(path)
|
|
if err != nil {
|
|
return "", fmt.Errorf(
|
|
"%w: from --config: %s (run 'vaultik config init --config %s' to create it)",
|
|
errConfigNotFound, path, path)
|
|
}
|
|
|
|
return path, nil
|
|
}
|
|
|
|
if path := os.Getenv("VAULTIK_CONFIG"); path != "" {
|
|
_, err := os.Stat(path) //nolint:gosec // G703: path is operator-supplied by design
|
|
if err != nil {
|
|
return "", fmt.Errorf(
|
|
"%w: from $VAULTIK_CONFIG: %s (unset VAULTIK_CONFIG, point it at "+
|
|
"an existing file, or run 'vaultik config init')",
|
|
errConfigNotFound, path)
|
|
}
|
|
|
|
return path, nil
|
|
}
|
|
|
|
for _, path := range defaultConfigPaths() {
|
|
_, err := os.Stat(path)
|
|
if err == nil {
|
|
return path, nil
|
|
}
|
|
}
|
|
|
|
return "", fmt.Errorf(
|
|
"%w: searched %s (run 'vaultik config init' to create the default "+
|
|
"config, or pass --config <path>)",
|
|
errConfigNotFound, strings.Join(defaultConfigPaths(), " or "))
|
|
}
|
|
|
|
// defaultConfigPaths returns the ordered list of config paths to search.
|
|
// On macOS: ~/Library/Application Support/vaultik/config.yml
|
|
// On Linux: ~/.config/vaultik/config.yml
|
|
// Fallback: /etc/vaultik/config.yml
|
|
func defaultConfigPaths() []string {
|
|
return []string{
|
|
filepath.Join(xdg.ConfigHome, "vaultik", "config.yml"),
|
|
"/etc/vaultik/config.yml",
|
|
}
|
|
}
|
|
|
|
// DefaultConfigPath returns the platform-appropriate default config path.
|
|
// Used by the init command and in help text.
|
|
func DefaultConfigPath() string {
|
|
if os.Getuid() == 0 {
|
|
return "/etc/vaultik/config.yml"
|
|
}
|
|
|
|
return filepath.Join(xdg.ConfigHome, "vaultik", "config.yml")
|
|
}
|