clawbot
6fcd8e1668
Docker images reported commit unknown because the build ran git inside the container while .dockerignore excludes .git, and VERSION was never overridden. script/docker and script/cibuild now compute version, commit and date on the host and pass them as build args; the Dockerfile runs no git and falls back to dev and unknown, never empty, on a bare docker build. Profiling a failing command gave a truncated or missing profile: Entry and each command goroutine called os.Exit(1), skipping the deferred profile writers in main. Entry now returns a status that main exits with after its defers run, and command goroutines report failure through one RunOperation helper, which also restores PID-lock release and graceful shutdown on failure. model: claude-opus-4-8 (implementation, review); claude-fable-5-1 (merge) Co-authored-by: clawbot <clawbot@noreply.example.org>
59 lines
1.5 KiB
Go
59 lines
1.5 KiB
Go
package cli //nolint:testpackage // shares programName and the capture helpers
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// TestEntryReturnsStatusCode pins the contract main() relies on for
|
|
// issue #75: Entry reports success or failure through its return value
|
|
// and never calls os.Exit. An os.Exit from inside Entry would skip
|
|
// main's deferred profile writers and truncate the profile of a failing
|
|
// command. main turns this code into os.Exit only after those defers
|
|
// run, so a failing command must come back with a non-zero code rather
|
|
// than ending the process here.
|
|
//
|
|
// Stdout is captured only to keep the banner and command output off the
|
|
// test log; the assertion is on the returned code.
|
|
//
|
|
//nolint:paralleltest // replaces os.Args and rootFlags
|
|
func TestEntryReturnsStatusCode(t *testing.T) {
|
|
for _, testCase := range []struct {
|
|
name string
|
|
args []string
|
|
want int
|
|
}{
|
|
{
|
|
// version is self-contained: it needs no config and no
|
|
// destination store, so it exercises the success path.
|
|
name: "successful command returns zero",
|
|
args: []string{programName, "version"},
|
|
want: 0,
|
|
},
|
|
{
|
|
name: "unknown command returns one",
|
|
args: []string{programName, "no-such-command"},
|
|
want: 1,
|
|
},
|
|
} {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
previousArgs := os.Args
|
|
|
|
t.Cleanup(func() {
|
|
os.Args = previousArgs
|
|
rootFlags = RootFlags{}
|
|
})
|
|
|
|
os.Args = testCase.args
|
|
|
|
var code int
|
|
|
|
_ = captureProcessStdout(t, func() { code = Entry() })
|
|
|
|
assert.Equal(t, testCase.want, code)
|
|
})
|
|
}
|
|
}
|