All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
179 lines
4.2 KiB
Go
179 lines
4.2 KiB
Go
package crypto_test
|
|
|
|
import (
|
|
"bytes"
|
|
"testing"
|
|
|
|
"filippo.io/age"
|
|
"sneak.berlin/go/vaultik/internal/crypto"
|
|
)
|
|
|
|
func TestEncryptor(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Generate a test key pair
|
|
identity, err := age.GenerateX25519Identity()
|
|
if err != nil {
|
|
t.Fatalf("failed to generate identity: %v", err)
|
|
}
|
|
|
|
publicKey := identity.Recipient().String()
|
|
|
|
// Create encryptor
|
|
enc, err := crypto.NewEncryptor([]string{publicKey})
|
|
if err != nil {
|
|
t.Fatalf("failed to create encryptor: %v", err)
|
|
}
|
|
|
|
// Test data
|
|
plaintext := []byte("Hello, World! This is a test message.")
|
|
|
|
// Encrypt
|
|
ciphertext, err := enc.Encrypt(plaintext)
|
|
if err != nil {
|
|
t.Fatalf("failed to encrypt: %v", err)
|
|
}
|
|
|
|
// Verify it's actually encrypted (should be larger and different)
|
|
if bytes.Equal(plaintext, ciphertext) {
|
|
t.Error("ciphertext equals plaintext")
|
|
}
|
|
|
|
// Decrypt to verify
|
|
r, err := age.Decrypt(bytes.NewReader(ciphertext), identity)
|
|
if err != nil {
|
|
t.Fatalf("failed to decrypt: %v", err)
|
|
}
|
|
|
|
var decrypted bytes.Buffer
|
|
|
|
_, err = decrypted.ReadFrom(r)
|
|
if err != nil {
|
|
t.Fatalf("failed to read decrypted data: %v", err)
|
|
}
|
|
|
|
if !bytes.Equal(plaintext, decrypted.Bytes()) {
|
|
t.Error("decrypted data doesn't match original")
|
|
}
|
|
}
|
|
|
|
func TestEncryptorMultipleRecipients(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Generate three test key pairs
|
|
identity1, err := age.GenerateX25519Identity()
|
|
if err != nil {
|
|
t.Fatalf("failed to generate identity1: %v", err)
|
|
}
|
|
|
|
identity2, err := age.GenerateX25519Identity()
|
|
if err != nil {
|
|
t.Fatalf("failed to generate identity2: %v", err)
|
|
}
|
|
|
|
identity3, err := age.GenerateX25519Identity()
|
|
if err != nil {
|
|
t.Fatalf("failed to generate identity3: %v", err)
|
|
}
|
|
|
|
publicKeys := []string{
|
|
identity1.Recipient().String(),
|
|
identity2.Recipient().String(),
|
|
identity3.Recipient().String(),
|
|
}
|
|
|
|
// Create encryptor with multiple recipients
|
|
enc, err := crypto.NewEncryptor(publicKeys)
|
|
if err != nil {
|
|
t.Fatalf("failed to create encryptor: %v", err)
|
|
}
|
|
|
|
// Test data
|
|
plaintext := []byte("Secret message for multiple recipients")
|
|
|
|
// Encrypt
|
|
ciphertext, err := enc.Encrypt(plaintext)
|
|
if err != nil {
|
|
t.Fatalf("failed to encrypt: %v", err)
|
|
}
|
|
|
|
// Verify each recipient can decrypt
|
|
identities := []age.Identity{identity1, identity2, identity3}
|
|
for i, identity := range identities {
|
|
r, err := age.Decrypt(bytes.NewReader(ciphertext), identity)
|
|
if err != nil {
|
|
t.Fatalf("recipient %d failed to decrypt: %v", i+1, err)
|
|
}
|
|
|
|
var decrypted bytes.Buffer
|
|
|
|
_, err = decrypted.ReadFrom(r)
|
|
if err != nil {
|
|
t.Fatalf("recipient %d failed to read decrypted data: %v", i+1, err)
|
|
}
|
|
|
|
if !bytes.Equal(plaintext, decrypted.Bytes()) {
|
|
t.Errorf("recipient %d: decrypted data doesn't match original", i+1)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestEncryptorUpdateRecipients(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Generate two identities
|
|
identity1, _ := age.GenerateX25519Identity()
|
|
identity2, _ := age.GenerateX25519Identity()
|
|
|
|
publicKey1 := identity1.Recipient().String()
|
|
publicKey2 := identity2.Recipient().String()
|
|
|
|
// Create encryptor with first key
|
|
enc, err := crypto.NewEncryptor([]string{publicKey1})
|
|
if err != nil {
|
|
t.Fatalf("failed to create encryptor: %v", err)
|
|
}
|
|
|
|
// Encrypt with first key
|
|
plaintext := []byte("test data")
|
|
|
|
ciphertext1, err := enc.Encrypt(plaintext)
|
|
if err != nil {
|
|
t.Fatalf("failed to encrypt: %v", err)
|
|
}
|
|
|
|
// Update to second key
|
|
err = enc.UpdateRecipients([]string{publicKey2})
|
|
if err != nil {
|
|
t.Fatalf("failed to update recipients: %v", err)
|
|
}
|
|
|
|
// Encrypt with second key
|
|
ciphertext2, err := enc.Encrypt(plaintext)
|
|
if err != nil {
|
|
t.Fatalf("failed to encrypt: %v", err)
|
|
}
|
|
|
|
// First ciphertext should only decrypt with first identity
|
|
_, err = age.Decrypt(bytes.NewReader(ciphertext1), identity1)
|
|
if err != nil {
|
|
t.Error("failed to decrypt with identity1")
|
|
}
|
|
|
|
_, err = age.Decrypt(bytes.NewReader(ciphertext1), identity2)
|
|
if err == nil {
|
|
t.Error("should not decrypt with identity2")
|
|
}
|
|
|
|
// Second ciphertext should only decrypt with second identity
|
|
_, err = age.Decrypt(bytes.NewReader(ciphertext2), identity2)
|
|
if err != nil {
|
|
t.Error("failed to decrypt with identity2")
|
|
}
|
|
|
|
_, err = age.Decrypt(bytes.NewReader(ciphertext2), identity1)
|
|
if err == nil {
|
|
t.Error("should not decrypt with identity1")
|
|
}
|
|
}
|