sneak
7ae470e530
Fix every finding surfaced by the canonical .golangci.yml with golangci-lint v2.12.2 (refs #61), behavior-preserving throughout: - err113: dynamic errors replaced with package-level sentinels and %w wrapping; direct comparisons converted to errors.Is - goprintffuncname: printf-style helpers renamed with an f suffix (ui.Writer message methods, cli.ReportErrorf, database.Fatalf, vaultik stdoutf) and all call sites updated - revive: stuttering type names renamed (blob.Handler, blob.WithReader, blob.ChunkPosition, storage.URL, storage.Info), doc comments added, unused parameters blanked, package comments added - contextcheck/noctx: ctx threaded through blob.Packer (AddChunk/Flush/FinalizeBlob/PackChunks) and scanner call sites; context-aware exec and sql variants used - funlen/cyclop/gocognit/nestif/dupl: oversized or duplicated functions split into focused helpers across production and test code - paralleltest/tparallel/thelper/usetesting/testpackage: tests parallelized where safe (global log.Initialize kept in the serial phase), helpers marked, t.TempDir adopted, external test packages where only exported API is used - gosec: integer conversions clamped or justified, header timeouts added, remaining findings suppressed with per-site justifications - mnd/goconst/lll/wsl_v5/nlreturn/noinlineerr/errcheck and other mechanical findings fixed directly Remove the deprecated log.LogOptions alias (callers migrated to log.Options). make check is green.
124 lines
2.6 KiB
Go
124 lines
2.6 KiB
Go
package s3_test
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"io"
|
|
"testing"
|
|
|
|
"sneak.berlin/go/vaultik/internal/s3"
|
|
)
|
|
|
|
//nolint:paralleltest // test servers share a fixed localhost port
|
|
func TestClient(t *testing.T) {
|
|
ts := NewTestServer(t)
|
|
defer func() {
|
|
err := ts.Cleanup()
|
|
if err != nil {
|
|
t.Errorf("cleanup failed: %v", err)
|
|
}
|
|
}()
|
|
|
|
ctx := context.Background()
|
|
|
|
// Create client
|
|
client, err := s3.NewClient(ctx, s3.Config{
|
|
Endpoint: testEndpoint,
|
|
Bucket: testBucket,
|
|
Prefix: "test-prefix/",
|
|
AccessKeyID: testAccessKey,
|
|
SecretAccessKey: testSecretKey,
|
|
Region: testRegion,
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("failed to create client: %v", err)
|
|
}
|
|
|
|
testKey := "foo/bar.txt"
|
|
testData := []byte("test data")
|
|
|
|
verifyPutGetHead(ctx, t, client, testKey, testData)
|
|
verifyListAndDelete(ctx, t, client, testKey)
|
|
}
|
|
|
|
// verifyPutGetHead uploads an object, reads it back, and checks existence.
|
|
func verifyPutGetHead(
|
|
ctx context.Context, t *testing.T, client *s3.Client,
|
|
testKey string, testData []byte,
|
|
) {
|
|
t.Helper()
|
|
|
|
err := client.PutObject(ctx, testKey, bytes.NewReader(testData))
|
|
if err != nil {
|
|
t.Fatalf("failed to put object: %v", err)
|
|
}
|
|
|
|
// Test GetObject
|
|
reader, err := client.GetObject(ctx, testKey)
|
|
if err != nil {
|
|
t.Fatalf("failed to get object: %v", err)
|
|
}
|
|
defer func() {
|
|
err := reader.Close()
|
|
if err != nil {
|
|
t.Errorf("failed to close reader: %v", err)
|
|
}
|
|
}()
|
|
|
|
data, err := io.ReadAll(reader)
|
|
if err != nil {
|
|
t.Fatalf("failed to read data: %v", err)
|
|
}
|
|
|
|
if !bytes.Equal(data, testData) {
|
|
t.Errorf("data mismatch: got %q, want %q", data, testData)
|
|
}
|
|
|
|
// Test HeadObject
|
|
exists, err := client.HeadObject(ctx, testKey)
|
|
if err != nil {
|
|
t.Fatalf("failed to head object: %v", err)
|
|
}
|
|
|
|
if !exists {
|
|
t.Error("expected object to exist")
|
|
}
|
|
}
|
|
|
|
// verifyListAndDelete lists the object's prefix, deletes it, and checks
|
|
// it is gone.
|
|
func verifyListAndDelete(
|
|
ctx context.Context, t *testing.T, client *s3.Client, testKey string,
|
|
) {
|
|
t.Helper()
|
|
|
|
keys, err := client.ListObjects(ctx, "foo/")
|
|
if err != nil {
|
|
t.Fatalf("failed to list objects: %v", err)
|
|
}
|
|
|
|
if len(keys) != 1 {
|
|
t.Errorf("expected 1 key, got %d", len(keys))
|
|
}
|
|
|
|
if keys[0] != testKey {
|
|
t.Errorf("unexpected key: got %s, want %s", keys[0], testKey)
|
|
}
|
|
|
|
// Test DeleteObject
|
|
err = client.DeleteObject(ctx, testKey)
|
|
if err != nil {
|
|
t.Fatalf("failed to delete object: %v", err)
|
|
}
|
|
|
|
// Verify deletion
|
|
exists, err := client.HeadObject(ctx, testKey)
|
|
if err != nil {
|
|
t.Fatalf("failed to head object after deletion: %v", err)
|
|
}
|
|
|
|
if exists {
|
|
t.Error("expected object to not exist after deletion")
|
|
}
|
|
}
|