All checks were successful
check / check (push) Successful in 5s
Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green. ## Version bump - `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated) - `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2` - `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables) - `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged - CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change ## Lint remediation The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights: - `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is` - `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated - `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added - `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants - `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code) - tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages - `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications - remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags) - removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`) `make check` (tests with `-race`, lint, fmt-check) passes. Co-authored-by: sneak <sneak@sneak.berlin> Reviewed-on: #62 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
77 lines
2.9 KiB
Go
77 lines
2.9 KiB
Go
// Package storage provides a unified interface for storage backends.
|
|
// It supports both S3-compatible object storage and local filesystem storage,
|
|
// allowing Vaultik to store backups in either location with the same API.
|
|
//
|
|
// Storage backends are selected via URL:
|
|
// - s3://bucket/prefix?endpoint=host®ion=r - S3-compatible storage
|
|
// - file:///path/to/backup - Local filesystem storage
|
|
//
|
|
// Both backends implement the Storer interface and support progress reporting
|
|
// during upload/write operations.
|
|
package storage
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
)
|
|
|
|
// ErrNotFound is returned when an object does not exist.
|
|
var ErrNotFound = errors.New("object not found")
|
|
|
|
// ProgressCallback is called during storage operations with bytes transferred so far.
|
|
// Return an error to cancel the operation.
|
|
type ProgressCallback func(bytesTransferred int64) error
|
|
|
|
// ObjectInfo contains metadata about a stored object.
|
|
type ObjectInfo struct {
|
|
Key string // Object key/path
|
|
Size int64 // Size in bytes
|
|
Err error // Error for streaming results (nil on success)
|
|
}
|
|
|
|
// Info provides human-readable storage configuration.
|
|
type Info struct {
|
|
Type string // "s3" or "file"
|
|
Location string // endpoint/bucket for S3, base path for filesystem
|
|
}
|
|
|
|
// Storer defines the interface for storage backends.
|
|
// All paths are relative to the storage root (bucket/prefix for S3, base
|
|
// directory for filesystem).
|
|
type Storer interface {
|
|
// Put stores data at the specified key.
|
|
// Parent directories are created automatically for filesystem backends.
|
|
Put(ctx context.Context, key string, data io.Reader) error
|
|
|
|
// PutWithProgress stores data with progress reporting.
|
|
// Size must be the exact size of the data to store.
|
|
// The progress callback is called periodically with bytes transferred.
|
|
PutWithProgress(ctx context.Context, key string, data io.Reader,
|
|
size int64, progress ProgressCallback) error
|
|
|
|
// Get retrieves data from the specified key.
|
|
// The caller must close the returned ReadCloser.
|
|
// Returns ErrNotFound if the object does not exist.
|
|
Get(ctx context.Context, key string) (io.ReadCloser, error)
|
|
|
|
// Stat returns metadata about an object without retrieving its contents.
|
|
// Returns ErrNotFound if the object does not exist.
|
|
Stat(ctx context.Context, key string) (*ObjectInfo, error)
|
|
|
|
// Delete removes an object. No error is returned if the object doesn't exist.
|
|
Delete(ctx context.Context, key string) error
|
|
|
|
// List returns all keys with the given prefix.
|
|
// For large result sets, prefer ListStream.
|
|
List(ctx context.Context, prefix string) ([]string, error)
|
|
|
|
// ListStream returns a channel of ObjectInfo for large result sets.
|
|
// The channel is closed when listing completes.
|
|
// If an error occurs during listing, the final item will have Err set.
|
|
ListStream(ctx context.Context, prefix string) <-chan ObjectInfo
|
|
|
|
// Info returns human-readable storage location information.
|
|
Info() Info
|
|
}
|