parseDuration fell back to an unanchored search for number-and-unit pieces when time.ParseDuration failed, and skipped everything in between. 1.0y became 0, so `snapshot create --prune --keep-newer-than 1.0y` deleted every snapshot of the backed-up names, the new one included. 2.1w became one week and 1,5y five years. The fallback now requires the whole input to be whole-number-and-unit parts with nothing between them. A bare number is rejected before time.ParseDuration sees it, since Go reads 0 and +0 as zero with no unit. Judgement call: a space between number and unit (`30 days`) was accepted and is now an error, matching Go's own units. Model: opus-5-5
160 lines
3.8 KiB
Go
160 lines
3.8 KiB
Go
package vaultik //nolint:testpackage // exercises unexported parse helpers
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestParseSnapshotName(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
snapshotID string
|
|
want string
|
|
}{
|
|
{
|
|
name: "standard format with name",
|
|
snapshotID: "myhost_home_2026-01-12T14:41:15Z",
|
|
want: "home",
|
|
},
|
|
{
|
|
name: "standard format with different name",
|
|
snapshotID: "server1_system_2026-02-15T09:30:00Z",
|
|
want: "system",
|
|
},
|
|
{
|
|
name: "name with underscores",
|
|
snapshotID: "myhost_my_special_backup_2026-03-01T00:00:00Z",
|
|
want: "my_special_backup",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got := parseSnapshotName(tt.snapshotID)
|
|
if got != tt.want {
|
|
t.Errorf("parseSnapshotName(%q) = %q, want %q",
|
|
tt.snapshotID, got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseDuration(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
input string
|
|
want time.Duration
|
|
err bool
|
|
}{
|
|
// Go units, including the m-is-minutes / mo-is-months distinction
|
|
// that this parser exists to keep straight.
|
|
{"10ns", 10 * time.Nanosecond, false},
|
|
{"10us", 10 * time.Microsecond, false},
|
|
{"500ms", 500 * time.Millisecond, false},
|
|
{"30s", 30 * time.Second, false},
|
|
{"6m", 6 * time.Minute, false},
|
|
{"1h", time.Hour, false},
|
|
{"1.5h", 90 * time.Minute, false},
|
|
// Extended calendar units.
|
|
{"30d", 30 * 24 * time.Hour, false},
|
|
{"3days", 3 * 24 * time.Hour, false},
|
|
{"4w", 4 * 7 * 24 * time.Hour, false},
|
|
{"2weeks", 2 * 7 * 24 * time.Hour, false},
|
|
{"6mo", 180 * 24 * time.Hour, false},
|
|
{"1month", 30 * 24 * time.Hour, false},
|
|
{"1y", 365 * 24 * time.Hour, false},
|
|
{"2years", 2 * 365 * 24 * time.Hour, false},
|
|
// Combined units.
|
|
{"2w3d", 2*7*24*time.Hour + 3*24*time.Hour, false},
|
|
{"1y6mo", 365*24*time.Hour + 180*24*time.Hour, false},
|
|
// Rejected inputs.
|
|
{"6", 0, true}, // bare number, no unit
|
|
{"0", 0, true}, // bare number; time.ParseDuration accepts it
|
|
{"+0", 0, true}, // bare number; time.ParseDuration accepts it
|
|
{"5x", 0, true}, // unknown unit
|
|
{"-5d", 0, true}, // negative, extended unit
|
|
{"-5h", 0, true}, // negative, Go unit
|
|
{"", 0, true}, // empty
|
|
{"garbage", 0, true},
|
|
// Characters outside the number-and-unit parts must not be
|
|
// skipped: 1.0y read as 0y would select every snapshot.
|
|
{"1.0y", 0, true},
|
|
{"2.1w", 0, true},
|
|
{"1,5y", 0, true},
|
|
{"30 days", 0, true},
|
|
{"30 days ago", 0, true},
|
|
{"x7d", 0, true},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.input, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
got, err := parseDuration(tt.input)
|
|
if tt.err {
|
|
if err == nil {
|
|
t.Fatalf("expected error for %q, got %v", tt.input, got)
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
if err != nil {
|
|
t.Fatalf("unexpected error for %q: %v", tt.input, err)
|
|
}
|
|
|
|
if got != tt.want {
|
|
t.Errorf("parseDuration(%q) = %v, want %v", tt.input, got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseSnapshotTimestamp(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
snapshotID string
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "valid with name",
|
|
snapshotID: "myhost_home_2026-01-12T14:41:15Z",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid without name",
|
|
snapshotID: "myhost_2026-01-12T14:41:15Z",
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "invalid - single part",
|
|
snapshotID: "nounderscore",
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "invalid - bad timestamp",
|
|
snapshotID: "myhost_home_notadate",
|
|
wantErr: true,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
_, err := parseSnapshotTimestamp(tt.snapshotID)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("parseSnapshotTimestamp(%q) error = %v, wantErr %v",
|
|
tt.snapshotID, err, tt.wantErr)
|
|
}
|
|
})
|
|
}
|
|
}
|