sneak/vaultik
1
0
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add .editorconfig (refs #59) #60

Merged
sneak merged 1 commits from issue-59-editorconfig into main 2026-08-07 17:46:19 +02:00
Conversation 1 Commits 1 Files Changed 1 +12
clawbot commented 2026-08-04 01:59:53 +02:00
Collaborator
Copy Link

Adds .editorconfig, copied byte-for-byte from sneak/dnswatcher (blob 2fe0ce0). This is the small, safe half of #59; the .golangci.yml half is deferred — adopting the org-standard config surfaces ~2,990 lint findings on vaultik and needs a separate lint-cleanup decision (see #59). Hence refs #59, not closes.

make check and docker build . are green (a static config file does not affect them). Left open for review (not merged).

Adds `.editorconfig`, copied byte-for-byte from `sneak/dnswatcher` (blob `2fe0ce0`). This is the small, safe half of #59; the `.golangci.yml` half is deferred — adopting the org-standard config surfaces ~2,990 lint findings on vaultik and needs a separate lint-cleanup decision (see #59). Hence `refs #59`, not `closes`. `make check` and `docker build .` are green (a static config file does not affect them). Left open for review (not merged).
clawbot added 1 commit 2026-08-04 01:59:54 +02:00
Add .editorconfig (refs #59)
All checks were successful
check / check (pull_request) Successful in 7s
Details
a8a424d75f
clawbot commented 2026-08-04 02:00:28 +02:00
Author
Collaborator
Copy Link

Independent adversarial review (reviewer separate from the author):

Review: sneak/vaultik PR issue-59-editorconfig (a8a424d)

1. Scope — PASS
Diff adds exactly one file, .editorconfig (+12 lines), and nothing else. git log origin/main..origin/issue-59-editorconfig shows a single commit. .golangci.yml is NOT present — correctly deferred.

2. Content byte-identical to dnswatcher — PASS

  • PR file blob SHA: 2fe0ce0, 178 bytes
  • dnswatcher .editorconfig blob SHA: 2fe0ce08508c7246d98b6bf8dbc96f0921f825f5, 178 bytes
  • SHAs match, so byte-identical. Line-by-line content also verified identical (root = true; [*] block: space/4/lf/utf-8/trim/final-newline; [Makefile] to tab).

3. No side effects — PASS
.editorconfig is an editor-hint file read only by IDEs/editors that support the spec. It is not consumed by make, the Go toolchain, go test, golangci-lint, or any CI step in this repo, so it cannot affect make check, tests, or lint results. It is purely additive with zero runtime/build surface.

4. Hygiene — PASS

  • Commit title: Add .editorconfig (refs #59) — ends with (refs #59), correctly using refs (partial work, not closing the issue).
  • No Claude/Anthropic/AI/Co-Authored-By/claude.ai references in the diff, the file, or the commit message.
  • Commit message is a clean single subject line, no trailers.

VERDICT: PASS

Independent adversarial review (reviewer separate from the author): ## Review: `sneak/vaultik` PR `issue-59-editorconfig` (`a8a424d`) **1. Scope — PASS** Diff adds exactly one file, `.editorconfig` (+12 lines), and nothing else. `git log origin/main..origin/issue-59-editorconfig` shows a single commit. `.golangci.yml` is NOT present — correctly deferred. **2. Content byte-identical to `dnswatcher` — PASS** - PR file blob SHA: `2fe0ce0`, 178 bytes - `dnswatcher` `.editorconfig` blob SHA: `2fe0ce08508c7246d98b6bf8dbc96f0921f825f5`, 178 bytes - SHAs match, so byte-identical. Line-by-line content also verified identical (`root = true`; `[*]` block: space/4/lf/utf-8/trim/final-newline; `[Makefile]` to tab). **3. No side effects — PASS** `.editorconfig` is an editor-hint file read only by IDEs/editors that support the spec. It is not consumed by `make`, the Go toolchain, `go test`, `golangci-lint`, or any CI step in this repo, so it cannot affect `make check`, tests, or lint results. It is purely additive with zero runtime/build surface. **4. Hygiene — PASS** - Commit title: `Add .editorconfig (refs #59)` — ends with ` (refs #59)`, correctly using `refs` (partial work, not closing the issue). - No `Claude`/`Anthropic`/AI/`Co-Authored-By`/`claude.ai` references in the diff, the file, or the commit message. - Commit message is a clean single subject line, no trailers. VERDICT: PASS
sneak merged commit 928c389a5a into main 2026-08-07 17:46:19 +02:00
sneak deleted branch issue-59-editorconfig 2026-08-07 17:46:19 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/vaultik#60
Delete Branch "issue-59-editorconfig"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?