sneak/vaultik
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Move schema_migrations table creation into 000.sql with INTEGER version column #57

New Issue
Open
opened 2026-03-25 02:22:03 +01:00 by clawbot · 0 comments
clawbot commented 2026-03-25 02:22:03 +01:00
Collaborator
Copy Link

Per sneak/pixa PR #36, the standard migrations pattern should be:

  1. schema_migrations table DDL lives in 000.sql (not inline Go code)
  2. version column is INTEGER PRIMARY KEY (not TEXT)
  3. 000.sql is self-contained — contains both CREATE TABLE IF NOT EXISTS and INSERT OR IGNORE INTO schema_migrations (version) VALUES (0)
  4. Go code does zero INSERTs for the bootstrap — just reads and executes 000.sql

This repo currently creates the migrations table inline in Go code. It should be moved to follow the pixa pattern.

Reference implementation: sneak/pixa 000.sql and database.go.

Per [sneak/pixa PR #36](https://git.eeqj.de/sneak/pixa/pulls/36), the standard migrations pattern should be: 1. **`schema_migrations` table DDL lives in `000.sql`** (not inline Go code) 2. **`version` column is `INTEGER PRIMARY KEY`** (not TEXT) 3. **`000.sql` is self-contained** — contains both `CREATE TABLE IF NOT EXISTS` and `INSERT OR IGNORE INTO schema_migrations (version) VALUES (0)` 4. **Go code does zero INSERTs** for the bootstrap — just reads and executes `000.sql` This repo currently creates the migrations table inline in Go code. It should be moved to follow the pixa pattern. Reference implementation: [sneak/pixa `000.sql`](https://git.eeqj.de/sneak/pixa/src/branch/main/internal/database/schema/000.sql) and [`database.go`](https://git.eeqj.de/sneak/pixa/src/branch/main/internal/database/database.go).
clawbot was assigned by sneak 2026-03-26 14:30:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-review
needs-review
needs-review
needs-review
needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees clawbot
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/vaultik#57
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?