Renames internal/vaultik/blob_fetch_stub.go to internal/vaultik/blob_fetch.go.
The file contains production code (hashVerifyReader, FetchAndDecryptBlob), not stubs. The _stub suffix was a misnomer from the original implementation in PR #39.
Pure rename — no code changes. All tests, linting, and formatting pass.
Renames `internal/vaultik/blob_fetch_stub.go` to `internal/vaultik/blob_fetch.go`.
The file contains production code (`hashVerifyReader`, `FetchAndDecryptBlob`), not stubs. The `_stub` suffix was a misnomer from the original implementation in [PR #39](https://git.eeqj.de/sneak/vaultik/pulls/39).
Pure rename — no code changes. All tests, linting, and formatting pass.
closes #52
The file contains production code (hashVerifyReader, FetchAndDecryptBlob),
not stubs. The _stub suffix was a misnomer from the original implementation.
PR #53 claims to be a pure rename of blob_fetch_stub.go → blob_fetch.go per issue #52, but it contains massive unauthorized changes across 9 additional files (1065 insertions, 1301 deletions):
File
Changes
internal/blob/packer.go
+/-211 lines
internal/cli/restore.go
+/-155 lines
internal/snapshot/scanner.go
+/-680 lines
internal/snapshot/snapshot.go
+/-63 lines
internal/vaultik/info.go
+/-99 lines
internal/vaultik/prune.go
+/-206 lines
internal/vaultik/restore.go
+/-136 lines
internal/vaultik/snapshot.go
+/-554 lines
internal/vaultik/verify.go
+/-262 lines
The only file that matches the issue is the actual rename: blob_fetch_stub.go → blob_fetch.go (0 code changes, correct).
All other changes reverse prior refactoring by inlining extracted helper methods back into their parent functions. This is a significant code organization change NOT requested by issue #52.
Verdict: needs-rework. Strip all changes except the rename. The PR should touch exactly one file.
## Review: FAIL ❌
[PR #53](https://git.eeqj.de/sneak/vaultik/pulls/53) claims to be a pure rename of `blob_fetch_stub.go` → `blob_fetch.go` per [issue #52](https://git.eeqj.de/sneak/vaultik/issues/52), but it contains **massive unauthorized changes** across 9 additional files (1065 insertions, 1301 deletions):
| File | Changes |
|---|---|
| `internal/blob/packer.go` | +/-211 lines |
| `internal/cli/restore.go` | +/-155 lines |
| `internal/snapshot/scanner.go` | +/-680 lines |
| `internal/snapshot/snapshot.go` | +/-63 lines |
| `internal/vaultik/info.go` | +/-99 lines |
| `internal/vaultik/prune.go` | +/-206 lines |
| `internal/vaultik/restore.go` | +/-136 lines |
| `internal/vaultik/snapshot.go` | +/-554 lines |
| `internal/vaultik/verify.go` | +/-262 lines |
The only file that matches the issue is the actual rename: `blob_fetch_stub.go` → `blob_fetch.go` (0 code changes, correct).
All other changes **reverse prior refactoring** by inlining extracted helper methods back into their parent functions. This is a significant code organization change NOT requested by [issue #52](https://git.eeqj.de/sneak/vaultik/issues/52).
**Verdict: `needs-rework`.** Strip all changes except the rename. The PR should touch exactly one file.
Pure rename, zero code changes. docker build . passes (lint, tests, build all green).
## Rework: Rebased onto current main
The branch was based on a stale `main` (before [PR #41](https://git.eeqj.de/sneak/vaultik/pulls/41) was merged), causing the diff to include reversed refactoring changes.
**Fix:** Rebased `rename-blob-fetch-stub` onto current `main` (`ac2f21a`). The diff now shows exactly one change:
```
internal/vaultik/{blob_fetch_stub.go => blob_fetch.go} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
```
Pure rename, zero code changes. `docker build .` passes (lint, tests, build all green).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Renames
internal/vaultik/blob_fetch_stub.gotointernal/vaultik/blob_fetch.go.The file contains production code (
hashVerifyReader,FetchAndDecryptBlob), not stubs. The_stubsuffix was a misnomer from the original implementation in PR #39.Pure rename — no code changes. All tests, linting, and formatting pass.
closes #52
Review: FAIL ❌
PR #53 claims to be a pure rename of
blob_fetch_stub.go→blob_fetch.goper issue #52, but it contains massive unauthorized changes across 9 additional files (1065 insertions, 1301 deletions):internal/blob/packer.gointernal/cli/restore.gointernal/snapshot/scanner.gointernal/snapshot/snapshot.gointernal/vaultik/info.gointernal/vaultik/prune.gointernal/vaultik/restore.gointernal/vaultik/snapshot.gointernal/vaultik/verify.goThe only file that matches the issue is the actual rename:
blob_fetch_stub.go→blob_fetch.go(0 code changes, correct).All other changes reverse prior refactoring by inlining extracted helper methods back into their parent functions. This is a significant code organization change NOT requested by issue #52.
Verdict:
needs-rework. Strip all changes except the rename. The PR should touch exactly one file.8d3a3ab7a1tod0818e800bRework: Rebased onto current main
The branch was based on a stale
main(before PR #41 was merged), causing the diff to include reversed refactoring changes.Fix: Rebased
rename-blob-fetch-stubonto currentmain(ac2f21a). The diff now shows exactly one change:Pure rename, zero code changes.
docker build .passes (lint, tests, build all green).Review: PASS ✅
PR #53 correctly implements issue #52 — rename
blob_fetch_stub.go→blob_fetch.go.Verified:
blob_fetch_stub.gono longer exists on the branchblob_fetch.gocontains the expected production code (hashVerifyReader,FetchAndDecryptBlob,FetchBlob)docker build .passes: formatting, linting, tests, and binary build all greenPure rename, clean rebase onto current
main. Ready to merge.