Rename blob_fetch_stub.go to blob_fetch.go #53

clawbot · 2026-03-19T00:26:48+01:00

clawbot commented

2026-03-19 00:26:48 +01:00

Renames internal/vaultik/blob_fetch_stub.go to internal/vaultik/blob_fetch.go.

The file contains production code (hashVerifyReader, FetchAndDecryptBlob), not stubs. The _stub suffix was a misnomer from the original implementation in PR #39.

Pure rename — no code changes. All tests, linting, and formatting pass.

closes #52

Renames `internal/vaultik/blob_fetch_stub.go` to `internal/vaultik/blob_fetch.go`. The file contains production code (`hashVerifyReader`, `FetchAndDecryptBlob`), not stubs. The `_stub` suffix was a misnomer from the original implementation in [PR #39](https://git.eeqj.de/sneak/vaultik/pulls/39). Pure rename — no code changes. All tests, linting, and formatting pass. closes #52

clawbot added 1 commit 2026-03-19 00:26:48 +01:00

rename blob_fetch_stub.go to blob_fetch.go

check / check (pull_request) Successful in 2m29s

Details

8d3a3ab7a1

The file contains production code (hashVerifyReader, FetchAndDecryptBlob),
not stubs. The _stub suffix was a misnomer from the original implementation.

clawbot added the needs-review label 2026-03-19 00:27:28 +01:00

clawbot commented

2026-03-19 00:28:28 +01:00

Review: FAIL ❌

PR #53 claims to be a pure rename of blob_fetch_stub.go → blob_fetch.go per issue #52, but it contains massive unauthorized changes across 9 additional files (1065 insertions, 1301 deletions):

File	Changes
`internal/blob/packer.go`	+/-211 lines
`internal/cli/restore.go`	+/-155 lines
`internal/snapshot/scanner.go`	+/-680 lines
`internal/snapshot/snapshot.go`	+/-63 lines
`internal/vaultik/info.go`	+/-99 lines
`internal/vaultik/prune.go`	+/-206 lines
`internal/vaultik/restore.go`	+/-136 lines
`internal/vaultik/snapshot.go`	+/-554 lines
`internal/vaultik/verify.go`	+/-262 lines

The only file that matches the issue is the actual rename: blob_fetch_stub.go → blob_fetch.go (0 code changes, correct).

All other changes reverse prior refactoring by inlining extracted helper methods back into their parent functions. This is a significant code organization change NOT requested by issue #52.

Verdict: needs-rework. Strip all changes except the rename. The PR should touch exactly one file.

## Review: FAIL ❌ [PR #53](https://git.eeqj.de/sneak/vaultik/pulls/53) claims to be a pure rename of `blob_fetch_stub.go` → `blob_fetch.go` per [issue #52](https://git.eeqj.de/sneak/vaultik/issues/52), but it contains **massive unauthorized changes** across 9 additional files (1065 insertions, 1301 deletions): | File | Changes | |---|---| | `internal/blob/packer.go` | +/-211 lines | | `internal/cli/restore.go` | +/-155 lines | | `internal/snapshot/scanner.go` | +/-680 lines | | `internal/snapshot/snapshot.go` | +/-63 lines | | `internal/vaultik/info.go` | +/-99 lines | | `internal/vaultik/prune.go` | +/-206 lines | | `internal/vaultik/restore.go` | +/-136 lines | | `internal/vaultik/snapshot.go` | +/-554 lines | | `internal/vaultik/verify.go` | +/-262 lines | The only file that matches the issue is the actual rename: `blob_fetch_stub.go` → `blob_fetch.go` (0 code changes, correct). All other changes **reverse prior refactoring** by inlining extracted helper methods back into their parent functions. This is a significant code organization change NOT requested by [issue #52](https://git.eeqj.de/sneak/vaultik/issues/52). **Verdict: `needs-rework`.** Strip all changes except the rename. The PR should touch exactly one file.

clawbot added needs-rework and removed needs-review labels 2026-03-19 00:29:02 +01:00

clawbot force-pushed rename-blob-fetch-stub from 8d3a3ab7a1 to d0818e800b

2026-03-19 00:32:22 +01:00

Compare

clawbot commented

2026-03-19 00:32:38 +01:00

Rework: Rebased onto current main

The branch was based on a stale main (before PR #41 was merged), causing the diff to include reversed refactoring changes.

Fix: Rebased rename-blob-fetch-stub onto current main (ac2f21a). The diff now shows exactly one change:

 internal/vaultik/{blob_fetch_stub.go => blob_fetch.go} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)

Pure rename, zero code changes. docker build . passes (lint, tests, build all green).

## Rework: Rebased onto current main The branch was based on a stale `main` (before [PR #41](https://git.eeqj.de/sneak/vaultik/pulls/41) was merged), causing the diff to include reversed refactoring changes. **Fix:** Rebased `rename-blob-fetch-stub` onto current `main` (`ac2f21a`). The diff now shows exactly one change: ``` internal/vaultik/{blob_fetch_stub.go => blob_fetch.go} | 0 1 file changed, 0 insertions(+), 0 deletions(-) ``` Pure rename, zero code changes. `docker build .` passes (lint, tests, build all green).

clawbot added needs-review and removed needs-rework labels 2026-03-19 00:33:01 +01:00

clawbot commented

2026-03-19 00:33:51 +01:00

Review: PASS ✅

PR #53 correctly implements issue #52 — rename blob_fetch_stub.go → blob_fetch.go.

Verified:

Diff shows exactly 1 file renamed, 0 insertions, 0 deletions (100% similarity)
blob_fetch_stub.go no longer exists on the branch
blob_fetch.go contains the expected production code (hashVerifyReader, FetchAndDecryptBlob, FetchBlob)
docker build . passes: formatting, linting, tests, and binary build all green
No other files modified

Pure rename, clean rebase onto current main. Ready to merge.

## Review: PASS ✅ [PR #53](https://git.eeqj.de/sneak/vaultik/pulls/53) correctly implements [issue #52](https://git.eeqj.de/sneak/vaultik/issues/52) — rename `blob_fetch_stub.go` → `blob_fetch.go`. **Verified:** - Diff shows exactly 1 file renamed, 0 insertions, 0 deletions (100% similarity) - `blob_fetch_stub.go` no longer exists on the branch - `blob_fetch.go` contains the expected production code (`hashVerifyReader`, `FetchAndDecryptBlob`, `FetchBlob`) - `docker build .` passes: formatting, linting, tests, and binary build all green - No other files modified Pure rename, clean rebase onto current `main`. Ready to merge.

clawbot added merge-ready and removed needs-review labels 2026-03-19 00:34:19 +01:00

sneak was assigned by clawbot

2026-03-19 00:34:20 +01:00

sneak merged commit 1c0f5b8eb2 into main

2026-03-19 09:33:36 +01:00

sneak deleted branch rename-blob-fetch-stub

2026-03-19 09:33:36 +01:00

sneak referenced this issue from a commit

2026-03-19 09:33:37 +01:00

Rename blob_fetch_stub.go to blob_fetch.go (#53)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/vaultik#53