next fails its check #482

Open
opened 2026-11-19 12:40:02 +01:00 by clawbot · 1 comment
Collaborator

next at fbcb1b9fc675f3997cf578e4bd606765379635f1 fails script/cibuild after #480 merged. Failure lines from the whole output:

#23 104.9 --- FAIL: TestBackupWithEmptySourcePathDoesNotPrune (0.00s)
#23 104.9     --- FAIL: TestBackupWithEmptySourcePathDoesNotPrune/one_of_two_paths (2.08s)
#23 104.9         snapshot_prune_test.go:115: 
#23 104.9             	Error Trace:	/src/internal/vaultik/snapshot_prune_test.go:115
#23 113.7     packer_test.go:164: Compression: 13 -> 226 bytes
#23 113.7     writer_test.go:107: Hash 1: d7b67aaf6eae60b80a95b7e658032b306911521b2638c8b377510c1659414a7e
#23 113.7     writer_test.go:108: Hash 2: d7b67aaf6eae60b80a95b7e658032b306911521b2638c8b377510c1659414a7e
#23 113.7     writer_test.go:109: Encrypted size 1: 271 bytes
#23 113.7     writer_test.go:110: Encrypted size 2: 271 bytes
#23 113.7     writer_test.go:57: Input size: 1048576 bytes
#23 113.7     writer_test.go:58: Single hash (SHA256(data)): 3f04de531e4bd49e6b6b68ced34d6c00e145af4d9b1ac5a5c6ec5fbe677
#23 113.7     writer_test.go:59: Double hash (SHA256(SHA256(data))): 76973e8fcc32f4f20761fb17b203300052febd513728ccd6049
#23 113.7     writer_test.go:60: Writer hash: 76973e8fcc32f4f20761fb17b203300052febd513728ccd604992f7fce2fd085
#23 114.2     chunker_isolated_test.go:62: Created 8 chunks for 524288 bytes with 65536 average chunk size
#23 114.2     chunker_isolated_test.go:62: Created 16 chunks for 1048576 bytes with 65536 average chunk size
#23 114.2     chunker_isolated_test.go:62: Created 10 chunks for 10485760 bytes with 262144 average chunk size
#23 120.4     cascade_debug_test.go:105: Foreign keys enabled: 1
#23 120.4     cascade_debug_test.go:105: file_chunks table definition:
#23 120.4     cascade_debug_test.go:107: Created file with ID: 1f15aed0-1cbd-40fc-9ad8-effa5a224085
#23 120.4     cascade_debug_test.go:107: Created file chunk mapping: file_id=1f15aed0-1cbd-40fc-9ad8-effa5a224085, idx=0
#23 120.4     cascade_debug_test.go:107: Created file chunk mapping: file_id=1f15aed0-1cbd-40fc-9ad8-effa5a224085, idx=1
#23 120.4     cascade_debug_test.go:107: Created file chunk mapping: file_id=1f15aed0-1cbd-40fc-9ad8-effa5a224085, idx=2
#23 120.4     cascade_debug_test.go:115: File chunks before delete: 3
#23 120.4     cascade_debug_test.go:118: Deleting file...
#23 120.4     cascade_debug_test.go:134: File was successfully deleted
#23 120.4     cascade_debug_test.go:143: File chunks after delete: 0
#23 120.4     cascade_debug_test.go:155: Manual count of file_chunks for deleted file: 0
#23 120.4     repository_debug_test.go:112: Created file1 with ID: 7bcd3d70-b638-4b9d-acd3-43bb484eb885
#23 120.4     repository_debug_test.go:112: Created file2 with ID: 75f5eeb5-e051-4381-82ce-b72b167f288c
#23 120.4     repository_debug_test.go:112: Created snapshot: test-snapshot
#23 120.4     repository_debug_test.go:116: snapshot_files count before add: 0
#23 120.4     repository_debug_test.go:124: Added file2 to snapshot
#23 120.4     repository_debug_test.go:128: snapshot_files count after add: 1
#23 120.4     repository_debug_test.go:131: Files in snapshot_files:
#23 120.4     repository_debug_test.go:131:   - 75f5eeb5-e051-4381-82ce-b72b167f288c
#23 120.4     repository_debug_test.go:135: Files count before cleanup: 2
#23 120.4     repository_debug_test.go:143: Ran orphaned cleanup
#23 120.4     repository_debug_test.go:147: Files count after cleanup: 1
#23 120.4     repository_debug_test.go:155: Remaining files:
#23 120.4     repository_debug_test.go:158:   - ID: 75f5eeb5-e051-4381-82ce-b72b167f288c, Path: /referenced.txt

Failure lines not shown: 28.

Last 40 lines:

#23 128.1 {"time":"2026-11-19T11:39:57.595782992Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":["/tmp/TestBackupWithEmptySourcePathDoesNotPruneone_of_two_paths4063044235/001/src/music of snapshot media"],"unmounted_paths":null,"caller":"snapshot.go:222"}
#23 128.1 --- PASS: TestBackupWithEmptySourcePathDoesNotPrune (0.01s)
#23 128.1     --- PASS: TestBackupWithEmptySourcePathDoesNotPrune/only_path (3.54s)
#23 128.1     --- PASS: TestBackupWithEmptySourcePathDoesNotPrune/one_of_two_paths (3.53s)
#23 128.1 --- PASS: TestBackupAfterInterruptedRunRestoresChangedFile (4.26s)
#23 128.1 {"time":"2026-11-19T11:39:57.645767844Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunelisting_fails3726805849/001/src/nas of snapshot data"],"caller":"snapshot.go:222"}
#23 128.1 {"time":"2026-11-19T11:39:57.648316198Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunedirectory_left_empty1685032053/001/src/nas of snapshot data"],"caller":"snapshot.go:222"}
#23 128.1 --- PASS: TestBackupAfterRemovingNewestSnapshotRestoresChangedFile (4.22s)
#23 128.1 --- PASS: TestBackupCountsDeletedFileOnce (3.75s)
#23 128.1 --- PASS: TestNewChunkSizeOfChangedFileStaysFixed (3.98s)
#23 128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune (0.00s)
#23 128.1     --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/listing_fails (4.32s)
#23 128.1     --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/directory_left_empty (4.27s)
#23 128.1 PASS
#23 128.1 ok  	sneak.berlin/go/vaultik/internal/vaultik	13.068s
#23 ERROR: process "/bin/sh -c go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0'         -cover ./... ||     { echo \"--- Rerunning with -v for details ---\";       go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0'           -v ./...; exit 1; }" did not complete successfully: exit code: 1
------
 > [test 6/6] RUN go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0'         -cover ./... ||     { echo "--- Rerunning with -v for details ---";       go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0'           -v ./...; exit 1; }:
128.1 {"time":"2026-11-19T11:39:57.645767844Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunelisting_fails3726805849/001/src/nas of snapshot data"],"caller":"snapshot.go:222"}
128.1 {"time":"2026-11-19T11:39:57.648316198Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunedirectory_left_empty1685032053/001/src/nas of snapshot data"],"caller":"snapshot.go:222"}
128.1 --- PASS: TestBackupAfterRemovingNewestSnapshotRestoresChangedFile (4.22s)
128.1 --- PASS: TestBackupCountsDeletedFileOnce (3.75s)
128.1 --- PASS: TestNewChunkSizeOfChangedFileStaysFixed (3.98s)
128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune (0.00s)
128.1     --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/listing_fails (4.32s)
128.1     --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/directory_left_empty (4.27s)
128.1 PASS
128.1 ok  	sneak.berlin/go/vaultik/internal/vaultik	13.068s
------
Dockerfile:43
--------------------
  42 |     # for that library only; our own packages keep it.
  43 | >>> RUN go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' \
  44 | >>>         -cover ./... || \
  45 | >>>     { echo "--- Rerunning with -v for details ---"; \
  46 | >>>       go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' \
  47 | >>>           -v ./...; exit 1; }
  48 |     
--------------------
ERROR: failed to build: failed to solve: process "/bin/sh -c go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0'         -cover ./... ||     { echo \"--- Rerunning with -v for details ---\";       go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0'           -v ./...; exit 1; }" did not complete successfully: exit code: 1

Model: opus-5-5

`next` at `fbcb1b9fc675f3997cf578e4bd606765379635f1` fails `script/cibuild` after https://git.eeqj.de/sneak/vaultik/pulls/480 merged. Failure lines from the whole output: ```` #23 104.9 --- FAIL: TestBackupWithEmptySourcePathDoesNotPrune (0.00s) #23 104.9 --- FAIL: TestBackupWithEmptySourcePathDoesNotPrune/one_of_two_paths (2.08s) #23 104.9 snapshot_prune_test.go:115: #23 104.9 Error Trace: /src/internal/vaultik/snapshot_prune_test.go:115 #23 113.7 packer_test.go:164: Compression: 13 -> 226 bytes #23 113.7 writer_test.go:107: Hash 1: d7b67aaf6eae60b80a95b7e658032b306911521b2638c8b377510c1659414a7e #23 113.7 writer_test.go:108: Hash 2: d7b67aaf6eae60b80a95b7e658032b306911521b2638c8b377510c1659414a7e #23 113.7 writer_test.go:109: Encrypted size 1: 271 bytes #23 113.7 writer_test.go:110: Encrypted size 2: 271 bytes #23 113.7 writer_test.go:57: Input size: 1048576 bytes #23 113.7 writer_test.go:58: Single hash (SHA256(data)): 3f04de531e4bd49e6b6b68ced34d6c00e145af4d9b1ac5a5c6ec5fbe677 #23 113.7 writer_test.go:59: Double hash (SHA256(SHA256(data))): 76973e8fcc32f4f20761fb17b203300052febd513728ccd6049 #23 113.7 writer_test.go:60: Writer hash: 76973e8fcc32f4f20761fb17b203300052febd513728ccd604992f7fce2fd085 #23 114.2 chunker_isolated_test.go:62: Created 8 chunks for 524288 bytes with 65536 average chunk size #23 114.2 chunker_isolated_test.go:62: Created 16 chunks for 1048576 bytes with 65536 average chunk size #23 114.2 chunker_isolated_test.go:62: Created 10 chunks for 10485760 bytes with 262144 average chunk size #23 120.4 cascade_debug_test.go:105: Foreign keys enabled: 1 #23 120.4 cascade_debug_test.go:105: file_chunks table definition: #23 120.4 cascade_debug_test.go:107: Created file with ID: 1f15aed0-1cbd-40fc-9ad8-effa5a224085 #23 120.4 cascade_debug_test.go:107: Created file chunk mapping: file_id=1f15aed0-1cbd-40fc-9ad8-effa5a224085, idx=0 #23 120.4 cascade_debug_test.go:107: Created file chunk mapping: file_id=1f15aed0-1cbd-40fc-9ad8-effa5a224085, idx=1 #23 120.4 cascade_debug_test.go:107: Created file chunk mapping: file_id=1f15aed0-1cbd-40fc-9ad8-effa5a224085, idx=2 #23 120.4 cascade_debug_test.go:115: File chunks before delete: 3 #23 120.4 cascade_debug_test.go:118: Deleting file... #23 120.4 cascade_debug_test.go:134: File was successfully deleted #23 120.4 cascade_debug_test.go:143: File chunks after delete: 0 #23 120.4 cascade_debug_test.go:155: Manual count of file_chunks for deleted file: 0 #23 120.4 repository_debug_test.go:112: Created file1 with ID: 7bcd3d70-b638-4b9d-acd3-43bb484eb885 #23 120.4 repository_debug_test.go:112: Created file2 with ID: 75f5eeb5-e051-4381-82ce-b72b167f288c #23 120.4 repository_debug_test.go:112: Created snapshot: test-snapshot #23 120.4 repository_debug_test.go:116: snapshot_files count before add: 0 #23 120.4 repository_debug_test.go:124: Added file2 to snapshot #23 120.4 repository_debug_test.go:128: snapshot_files count after add: 1 #23 120.4 repository_debug_test.go:131: Files in snapshot_files: #23 120.4 repository_debug_test.go:131: - 75f5eeb5-e051-4381-82ce-b72b167f288c #23 120.4 repository_debug_test.go:135: Files count before cleanup: 2 #23 120.4 repository_debug_test.go:143: Ran orphaned cleanup #23 120.4 repository_debug_test.go:147: Files count after cleanup: 1 #23 120.4 repository_debug_test.go:155: Remaining files: #23 120.4 repository_debug_test.go:158: - ID: 75f5eeb5-e051-4381-82ce-b72b167f288c, Path: /referenced.txt ```` Failure lines not shown: 28. Last 40 lines: ```` #23 128.1 {"time":"2026-11-19T11:39:57.595782992Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":["/tmp/TestBackupWithEmptySourcePathDoesNotPruneone_of_two_paths4063044235/001/src/music of snapshot media"],"unmounted_paths":null,"caller":"snapshot.go:222"} #23 128.1 --- PASS: TestBackupWithEmptySourcePathDoesNotPrune (0.01s) #23 128.1 --- PASS: TestBackupWithEmptySourcePathDoesNotPrune/only_path (3.54s) #23 128.1 --- PASS: TestBackupWithEmptySourcePathDoesNotPrune/one_of_two_paths (3.53s) #23 128.1 --- PASS: TestBackupAfterInterruptedRunRestoresChangedFile (4.26s) #23 128.1 {"time":"2026-11-19T11:39:57.645767844Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunelisting_fails3726805849/001/src/nas of snapshot data"],"caller":"snapshot.go:222"} #23 128.1 {"time":"2026-11-19T11:39:57.648316198Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunedirectory_left_empty1685032053/001/src/nas of snapshot data"],"caller":"snapshot.go:222"} #23 128.1 --- PASS: TestBackupAfterRemovingNewestSnapshotRestoresChangedFile (4.22s) #23 128.1 --- PASS: TestBackupCountsDeletedFileOnce (3.75s) #23 128.1 --- PASS: TestNewChunkSizeOfChangedFileStaysFixed (3.98s) #23 128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune (0.00s) #23 128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/listing_fails (4.32s) #23 128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/directory_left_empty (4.27s) #23 128.1 PASS #23 128.1 ok sneak.berlin/go/vaultik/internal/vaultik 13.068s #23 ERROR: process "/bin/sh -c go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' -cover ./... || { echo \"--- Rerunning with -v for details ---\"; go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' -v ./...; exit 1; }" did not complete successfully: exit code: 1 ------ > [test 6/6] RUN go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' -cover ./... || { echo "--- Rerunning with -v for details ---"; go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' -v ./...; exit 1; }: 128.1 {"time":"2026-11-19T11:39:57.645767844Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunelisting_fails3726805849/001/src/nas of snapshot data"],"caller":"snapshot.go:222"} 128.1 {"time":"2026-11-19T11:39:57.648316198Z","level":"WARN","msg":"Skipping post-backup prune","files_unreadable":0,"empty_paths":null,"unmounted_paths":["/tmp/TestBackupWithVolumeNotMountedDoesNotPrunedirectory_left_empty1685032053/001/src/nas of snapshot data"],"caller":"snapshot.go:222"} 128.1 --- PASS: TestBackupAfterRemovingNewestSnapshotRestoresChangedFile (4.22s) 128.1 --- PASS: TestBackupCountsDeletedFileOnce (3.75s) 128.1 --- PASS: TestNewChunkSizeOfChangedFileStaysFixed (3.98s) 128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune (0.00s) 128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/listing_fails (4.32s) 128.1 --- PASS: TestBackupWithVolumeNotMountedDoesNotPrune/directory_left_empty (4.27s) 128.1 PASS 128.1 ok sneak.berlin/go/vaultik/internal/vaultik 13.068s ------ Dockerfile:43 -------------------- 42 | # for that library only; our own packages keep it. 43 | >>> RUN go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' \ 44 | >>> -cover ./... || \ 45 | >>> { echo "--- Rerunning with -v for details ---"; \ 46 | >>> go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' \ 47 | >>> -v ./...; exit 1; } 48 | -------------------- ERROR: failed to build: failed to solve: process "/bin/sh -c go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' -cover ./... || { echo \"--- Rerunning with -v for details ---\"; go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' -v ./...; exit 1; }" did not complete successfully: exit code: 1 ```` Model: opus-5-5
clawbot added the red-next label 2026-11-19 12:40:02 +01:00
Author
Collaborator

Fixed in #483 (branch issue-482-snapshot-start-time). The test failure was a real bug, not a test defect. A snapshot's started_at came from a second clock read after its ID was built. Near a second boundary, two runs of one snapshot name could share a started_at, so ListRecent listed them in either order. The start time now comes from the clock read that builds the ID.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/vaultik/pulls/483 (branch `issue-482-snapshot-start-time`). The test failure was a real bug, not a test defect. A snapshot's `started_at` came from a second clock read after its ID was built. Near a second boundary, two runs of one snapshot name could share a `started_at`, so `ListRecent` listed them in either order. The start time now comes from the clock read that builds the ID. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/vaultik#482