PR: #479 (branch issue-476-retry-blob-upload, base next).
A failed blob upload now gets up to five retries, 3 seconds apart, each announced with a warning. If the last try fails too, the backup stops with the upload's error. The panic in the report was already fixed on next by #253; a new test covers a failing upload with the progress reporter on.
Judgement call: "retry 5 times" is read as five retries after the first try. The count and the delay are constants, not config keys.
Deviation: next had been deleted from the remote after the merge into main. I recreated it at main's tip (4605eae), which has the same tree as the old next.
Model: opus-5-5
PR: https://git.eeqj.de/sneak/vaultik/pulls/479 (branch `issue-476-retry-blob-upload`, base `next`).
A failed blob upload now gets up to five retries, 3 seconds apart, each announced with a warning. If the last try fails too, the backup stops with the upload's error. The panic in the report was already fixed on `next` by https://git.eeqj.de/sneak/vaultik/issues/253; a new test covers a failing upload with the progress reporter on.
- Judgement call: "retry 5 times" is read as five retries after the first try. The count and the delay are constants, not config keys.
- Deviation: `next` had been deleted from the remote after the merge into `main`. I recreated it at `main`'s tip (`4605eae`), which has the same tree as the old `next`.
Model: opus-5-5
Verified: you were right, the panic itself is already fixed on next (#253). PR 479 adds only the upload retries this issue asks for, plus a test of a failing upload with progress shown, so the old panic stays fixed.
Model: opus-5-5
Verified: you were right, the panic itself is already fixed on `next` (https://git.eeqj.de/sneak/vaultik/issues/253). PR 479 adds only the upload retries this issue asks for, plus a test of a failing upload with progress shown, so the old panic stays fixed.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
there needs to be graceful handling of blob upload failures, and retries. retry by default 5 times with 3 second delays.
PR: #479 (branch
issue-476-retry-blob-upload, basenext).A failed blob upload now gets up to five retries, 3 seconds apart, each announced with a warning. If the last try fails too, the backup stops with the upload's error. The panic in the report was already fixed on
nextby #253; a new test covers a failing upload with the progress reporter on.nexthad been deleted from the remote after the merge intomain. I recreated it atmain's tip (4605eae), which has the same tree as the oldnext.Model: opus-5-5
this might be old i was testing on a very old version, verify before working it
Verified: you were right, the panic itself is already fixed on
next(#253). PR 479 adds only the upload retries this issue asks for, plus a test of a failing upload with progress shown, so the old panic stays fixed.Model: opus-5-5