cosmetic: index_path accepts a relative path #430

Closed
opened 2026-11-11 01:01:49 +01:00 by clawbot · 2 comments
Collaborator

Found by the acceptance test (#418).

Steps to reproduce

  • Put index_path: relative/index.sqlite in the config.
  • Run vaultik snapshot create from two different working directories.

What happened

Each run creates its own index under the current directory. The second run sees an empty index: every file is read again, every snapshot at the destination is listed as remote-only, and the destination binding starts over. A relative file:// destination is refused when the config loads for the same reason (#299); index_path is not.

What should happen

A relative index_path is refused when the config loads, with the same wording as the file:// check. ~ stays expanded.

Model: fable-5-1

Found by the acceptance test (https://git.eeqj.de/sneak/vaultik/issues/418). **Steps to reproduce** - Put `index_path: relative/index.sqlite` in the config. - Run `vaultik snapshot create` from two different working directories. **What happened** Each run creates its own index under the current directory. The second run sees an empty index: every file is read again, every snapshot at the destination is listed as remote-only, and the destination binding starts over. A relative `file://` destination is refused when the config loads for the same reason (https://git.eeqj.de/sneak/vaultik/issues/299); `index_path` is not. **What should happen** A relative `index_path` is refused when the config loads, with the same wording as the `file://` check. `~` stays expanded. Model: fable-5-1
Author
Collaborator

Plan: a relative index_path is refused when the config loads, naming the setting and the value. ~ is still expanded first.

Package: internal/config. Starts after #419 merges, which changes the same package.

For every unit from the acceptance test

  • One branch off current next, one PR with base next, labelled needs-review and assigned to clawbot. The title ends (closes #N).
  • Add nothing to docs/TODO.md. sneak ruled on 11 November that it is not a history document (#440).
  • README.md on next: change only a sentence the fix makes false. The rewritten README in #399 is with sneak and is updated after this merges.
  • A test that fails on current next shows the fix. Run make fmt and make check before the final push.

Model: opus-5-5

Plan: a relative `index_path` is refused when the config loads, naming the setting and the value. `~` is still expanded first. Package: `internal/config`. Starts after https://git.eeqj.de/sneak/vaultik/issues/419 merges, which changes the same package. **For every unit from the acceptance test** - One branch off current `next`, one PR with base `next`, labelled `needs-review` and assigned to `clawbot`. The title ends `(closes #N)`. - Add nothing to `docs/TODO.md`. sneak ruled on 11 November that it is not a history document (https://git.eeqj.de/sneak/vaultik/issues/440). - `README.md` on `next`: change only a sentence the fix makes false. The rewritten README in https://git.eeqj.de/sneak/vaultik/pulls/399 is with sneak and is updated after this merges. - A test that fails on current `next` shows the fix. Run `make fmt` and `make check` before the final push. Model: opus-5-5
clawbot self-assigned this 2026-11-11 01:21:31 +01:00
Author
Collaborator

Built in #453: config load refuses a relative index_path (or VAULTIK_INDEX_PATH), quoting the value; ~ is expanded first. An explicitly empty index_path is refused too.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/vaultik/pulls/453: config load refuses a relative `index_path` (or `VAULTIK_INDEX_PATH`), quoting the value; `~` is expanded first. An explicitly empty `index_path` is refused too. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/vaultik#430