Refactor: break up oversized methods (>100-150 lines) #40

New Issue

clawbot · 2026-02-20T11:23:43+01:00

clawbot commented

2026-02-20 11:23:43 +01:00

Per sneak's feedback on PR #37: methods are too long. Break them into descriptively named methods of max 100-150 lines each.

Oversized methods found

Files touched by PR #37

internal/vaultik/snapshot.go:115 — createNamedSnapshot (214 lines)
internal/vaultik/snapshot.go:331 — ListSnapshots (159 lines)
internal/vaultik/snapshot.go:492 — PurgeSnapshots (101 lines)
internal/vaultik/snapshot.go:604 — VerifySnapshotWithOptions (114 lines)
internal/vaultik/snapshot.go:909 — RemoveAllSnapshots (102 lines)
internal/vaultik/prune.go:27 — PruneBlobs (170 lines)

Other files

internal/snapshot/scanner.go:160 — Scan (121 lines)
internal/snapshot/scanner.go:423 — flushCompletedPendingFiles (123 lines)
internal/snapshot/scanner.go:557 — scanPhase (140 lines)
internal/snapshot/scanner.go:811 — processPhase (117 lines)
internal/snapshot/scanner.go:930 — handleBlobReady (173 lines)
internal/snapshot/scanner.go:1105 — processFileStreaming (146 lines)
internal/snapshot/snapshot.go:214 — ExportSnapshotMetadata (105 lines)
internal/vaultik/restore.go:48 — Restore (141 lines)
internal/vaultik/info.go:151 — RemoteInfo (187 lines)
internal/vaultik/verify.go:39 — RunDeepVerify (182 lines)
internal/vaultik/verify.go:288 — verifyBlob (121 lines)
internal/cli/restore.go:32 — NewRestoreCommand (105 lines)
internal/blob/packer.go:359 — finalizeCurrentBlob (167 lines)

Per sneak's feedback on PR #37: methods are too long. Break them into descriptively named methods of max 100-150 lines each. ## Oversized methods found ### Files touched by PR #37 - `internal/vaultik/snapshot.go:115` — `createNamedSnapshot` (214 lines) - `internal/vaultik/snapshot.go:331` — `ListSnapshots` (159 lines) - `internal/vaultik/snapshot.go:492` — `PurgeSnapshots` (101 lines) - `internal/vaultik/snapshot.go:604` — `VerifySnapshotWithOptions` (114 lines) - `internal/vaultik/snapshot.go:909` — `RemoveAllSnapshots` (102 lines) - `internal/vaultik/prune.go:27` — `PruneBlobs` (170 lines) ### Other files - `internal/snapshot/scanner.go:160` — `Scan` (121 lines) - `internal/snapshot/scanner.go:423` — `flushCompletedPendingFiles` (123 lines) - `internal/snapshot/scanner.go:557` — `scanPhase` (140 lines) - `internal/snapshot/scanner.go:811` — `processPhase` (117 lines) - `internal/snapshot/scanner.go:930` — `handleBlobReady` (173 lines) - `internal/snapshot/scanner.go:1105` — `processFileStreaming` (146 lines) - `internal/snapshot/snapshot.go:214` — `ExportSnapshotMetadata` (105 lines) - `internal/vaultik/restore.go:48` — `Restore` (141 lines) - `internal/vaultik/info.go:151` — `RemoteInfo` (187 lines) - `internal/vaultik/verify.go:39` — `RunDeepVerify` (182 lines) - `internal/vaultik/verify.go:288` — `verifyBlob` (121 lines) - `internal/cli/restore.go:32` — `NewRestoreCommand` (105 lines) - `internal/blob/packer.go:359` — `finalizeCurrentBlob` (167 lines)

clawbot referenced this issue from a commit

2026-02-20 11:32:02 +01:00

refactor: break up oversized methods into smaller descriptive helpers

clawbot referenced a pull request that will close this issue

2026-02-20 11:32:13 +01:00

Refactor: break up oversized methods into smaller descriptive helpers #41

Sign in to join this conversation.