What is wrong: with one unreadable file and one unreadable directory, the run prints the skip errors, "Files: 140 examined, 4 backed up, 135 unchanged, 1 failed", then "Finished successfully.", and exits 0, also under --cron. The skipped directory is not counted as failed. A script or cron wrapper cannot tell a complete backup from one missing files, while snapshot restore under the same flag exits non-zero when files failed (#218). In internal/vaultik/snapshot.go, totalFilesFailed feeds the summary only; the run returns success.
Definition of done
When any file or directory was skipped, snapshot create --skip-errors still completes and keeps the snapshot, does not print "Finished successfully.", and exits non-zero, as restore does under the flag.
A skipped directory is counted as failed in the summary. (Not counting the files under it as deleted is handled in #342, whose review requires it.)
The README's --skip-errors text says what the exit status is.
A test covers a skipped file and a skipped directory.
Model: opus-5-5
Found by the defect hunt in https://git.eeqj.de/sneak/vaultik/issues/288 (part 1).
**What is wrong:** with one unreadable file and one unreadable directory, the run prints the skip errors, "Files: 140 examined, 4 backed up, 135 unchanged, 1 failed", then "Finished successfully.", and exits 0, also under `--cron`. The skipped directory is not counted as failed. A script or cron wrapper cannot tell a complete backup from one missing files, while `snapshot restore` under the same flag exits non-zero when files failed (https://git.eeqj.de/sneak/vaultik/issues/218). In `internal/vaultik/snapshot.go`, `totalFilesFailed` feeds the summary only; the run returns success.
**Definition of done**
- When any file or directory was skipped, `snapshot create --skip-errors` still completes and keeps the snapshot, does not print "Finished successfully.", and exits non-zero, as restore does under the flag.
- A skipped directory is counted as failed in the summary. (Not counting the files under it as deleted is handled in https://git.eeqj.de/sneak/vaultik/pulls/342, whose review requires it.)
- The README's `--skip-errors` text says what the exit status is.
- A test covers a skipped file and a skipped directory.
Model: opus-5-5
clawbot
self-assigned this 2026-10-13 00:47:14 +02:00
Implemented in #381: a skipped file or directory is counted as failed, and snapshot create --skip-errors keeps the snapshot but exits non-zero when it skipped anything.
Model: opus-5-5
Implemented in https://git.eeqj.de/sneak/vaultik/pulls/381: a skipped file or directory is counted as failed, and `snapshot create --skip-errors` keeps the snapshot but exits non-zero when it skipped anything.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the defect hunt in #288 (part 1).
What is wrong: with one unreadable file and one unreadable directory, the run prints the skip errors, "Files: 140 examined, 4 backed up, 135 unchanged, 1 failed", then "Finished successfully.", and exits 0, also under
--cron. The skipped directory is not counted as failed. A script or cron wrapper cannot tell a complete backup from one missing files, whilesnapshot restoreunder the same flag exits non-zero when files failed (#218). Ininternal/vaultik/snapshot.go,totalFilesFailedfeeds the summary only; the run returns success.Definition of done
snapshot create --skip-errorsstill completes and keeps the snapshot, does not print "Finished successfully.", and exits non-zero, as restore does under the flag.--skip-errorstext says what the exit status is.Model: opus-5-5
Implemented in #381: a skipped file or directory is counted as failed, and
snapshot create --skip-errorskeeps the snapshot but exits non-zero when it skipped anything.Model: opus-5-5