What is wrong: with one unreadable file and one unreadable directory, the run prints the skip errors, "Files: 140 examined, 4 backed up, 135 unchanged, 1 failed", then "Finished successfully.", and exits 0, also under --cron. The skipped directory is not counted as failed. A script or cron wrapper cannot tell a complete backup from one missing files, while snapshot restore under the same flag exits non-zero when files failed (#218). In internal/vaultik/snapshot.go, totalFilesFailed feeds the summary only; the run returns success.
Definition of done
When any file or directory was skipped, snapshot create --skip-errors still completes and keeps the snapshot, does not print "Finished successfully.", and exits non-zero, as restore does under the flag.
A skipped directory is counted as failed in the summary, and files under it that the previous snapshot of the same name had are not counted as deleted (noticed while fixing #304).
The README's --skip-errors text says what the exit status is.
A test covers a skipped file and a skipped directory.
Model: opus-5-5
Found by the defect hunt in https://git.eeqj.de/sneak/vaultik/issues/288 (part 1).
**What is wrong:** with one unreadable file and one unreadable directory, the run prints the skip errors, "Files: 140 examined, 4 backed up, 135 unchanged, 1 failed", then "Finished successfully.", and exits 0, also under `--cron`. The skipped directory is not counted as failed. A script or cron wrapper cannot tell a complete backup from one missing files, while `snapshot restore` under the same flag exits non-zero when files failed (https://git.eeqj.de/sneak/vaultik/issues/218). In `internal/vaultik/snapshot.go`, `totalFilesFailed` feeds the summary only; the run returns success.
**Definition of done**
- When any file or directory was skipped, `snapshot create --skip-errors` still completes and keeps the snapshot, does not print "Finished successfully.", and exits non-zero, as restore does under the flag.
- A skipped directory is counted as failed in the summary, and files under it that the previous snapshot of the same name had are not counted as deleted (noticed while fixing https://git.eeqj.de/sneak/vaultik/issues/304).
- The README's `--skip-errors` text says what the exit status is.
- A test covers a skipped file and a skipped directory.
Model: opus-5-5
clawbot
self-assigned this 2026-10-13 00:47:14 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found by the defect hunt in #288 (part 1).
What is wrong: with one unreadable file and one unreadable directory, the run prints the skip errors, "Files: 140 examined, 4 backed up, 135 unchanged, 1 failed", then "Finished successfully.", and exits 0, also under
--cron. The skipped directory is not counted as failed. A script or cron wrapper cannot tell a complete backup from one missing files, whilesnapshot restoreunder the same flag exits non-zero when files failed (#218). Ininternal/vaultik/snapshot.go,totalFilesFailedfeeds the summary only; the run returns success.Definition of done
snapshot create --skip-errorsstill completes and keeps the snapshot, does not print "Finished successfully.", and exits non-zero, as restore does under the flag.--skip-errorstext says what the exit status is.Model: opus-5-5