Multiple methods write to os.Stdout instead of v.Stdout, breaking testability #26

New Issue

clawbot · 2026-02-08T21:01:08+01:00

clawbot commented

2026-02-08 21:01:08 +01:00

Bug

Several methods in the vaultik package write directly to os.Stdout instead of using the injectable v.Stdout writer. This breaks the TestVaultik testing infrastructure which captures output via buffers.

Affected methods:

ListSnapshots - uses tabwriter.NewWriter(os.Stdout, ...) and json.NewEncoder(os.Stdout)
PurgeSnapshots - uses fmt.Println, fmt.Printf, fmt.Scanln
VerifySnapshotWithOptions - uses fmt.Printf directly
outputPruneBlobsJSON - package-level function uses os.Stdout
outputRemoveJSON - uses json.NewEncoder(os.Stdout)
ShowInfo - uses fmt.Printf throughout

Impact

Output cannot be captured in tests
Output cannot be redirected programmatically
Inconsistent behavior: some methods use v.Stdout, others bypass it

Fix

Replace all os.Stdout references with v.Stdout and fmt.Printf/fmt.Println with fmt.Fprintf(v.Stdout, ...).

## Bug Several methods in the `vaultik` package write directly to `os.Stdout` instead of using the injectable `v.Stdout` writer. This breaks the `TestVaultik` testing infrastructure which captures output via buffers. Affected methods: - `ListSnapshots` - uses `tabwriter.NewWriter(os.Stdout, ...)` and `json.NewEncoder(os.Stdout)` - `PurgeSnapshots` - uses `fmt.Println`, `fmt.Printf`, `fmt.Scanln` - `VerifySnapshotWithOptions` - uses `fmt.Printf` directly - `outputPruneBlobsJSON` - package-level function uses `os.Stdout` - `outputRemoveJSON` - uses `json.NewEncoder(os.Stdout)` - `ShowInfo` - uses `fmt.Printf` throughout ## Impact - Output cannot be captured in tests - Output cannot be redirected programmatically - Inconsistent behavior: some methods use `v.Stdout`, others bypass it ## Fix Replace all `os.Stdout` references with `v.Stdout` and `fmt.Printf`/`fmt.Println` with `fmt.Fprintf(v.Stdout, ...)`.

clawbot self-assigned this 2026-02-08 21:01:08 +01:00

clawbot referenced a pull request that will close this issue

2026-02-08 21:05:04 +01:00

Use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output (closes #26) #31

clawbot added the

needs-rebase

label 2026-02-20 09:17:44 +01:00

sneak closed this issue

2026-02-20 11:07:53 +01:00

sneak referenced this issue from a commit

2026-02-20 11:07:54 +01:00

Merge pull request 'Use v.Stdout/v.Stdin instead of os.Stdout for all user-facing output (closes #26)' (#31) from fix/issue-26 into main