Both noted by the review of #238 and confirmed on next at ea72697:
internal/config/config.go:309 warns "Config file has insecure permissions (contains S3 credentials)" for any group- or world-readable config file, including a file:// config that holds no S3 credentials. The warning claims something about the file that may be false.
internal/vaultik/snapshot.go:1041 wraps an error from listAllRemoteSnapshotKeys (:1346) that already starts with listing remote snapshots:, so snapshot purge against a store that cannot be listed prints the prefix twice.
Definition of done
The permissions warning says only what is true of the file: it names the S3 credentials only when the file sets them, and otherwise says that the file is readable by others.
The purge error carries the listing remote snapshots: prefix once.
A test for each.
make check passes.
Model: opus-5-5
Both noted by the review of https://git.eeqj.de/sneak/vaultik/pulls/238 and confirmed on `next` at `ea72697`:
- `internal/config/config.go:309` warns "Config file has insecure permissions (contains S3 credentials)" for any group- or world-readable config file, including a `file://` config that holds no S3 credentials. The warning claims something about the file that may be false.
- `internal/vaultik/snapshot.go:1041` wraps an error from `listAllRemoteSnapshotKeys` (`:1346`) that already starts with `listing remote snapshots:`, so `snapshot purge` against a store that cannot be listed prints the prefix twice.
## Definition of done
1. The permissions warning says only what is true of the file: it names the S3 credentials only when the file sets them, and otherwise says that the file is readable by others.
2. The purge error carries the `listing remote snapshots:` prefix once.
3. A test for each.
4. `make check` passes.
Model: opus-5-5
clawbot
self-assigned this 2026-10-06 08:47:06 +02:00
Both defects reproduced on next at 3fc8a8f. Fixed in #263: the warning names the S3 credentials only when s3.access_key_id or s3.secret_access_key is set and otherwise says the config file is readable by others, and the snapshot purge error carries listing remote snapshots: once.
Model: opus-5-5
Both defects reproduced on `next` at `3fc8a8f`. Fixed in https://git.eeqj.de/sneak/vaultik/pulls/263: the warning names the S3 credentials only when `s3.access_key_id` or `s3.secret_access_key` is set and otherwise says the config file is readable by others, and the `snapshot purge` error carries `listing remote snapshots:` once.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Both noted by the review of #238 and confirmed on
nextatea72697:internal/config/config.go:309warns "Config file has insecure permissions (contains S3 credentials)" for any group- or world-readable config file, including afile://config that holds no S3 credentials. The warning claims something about the file that may be false.internal/vaultik/snapshot.go:1041wraps an error fromlistAllRemoteSnapshotKeys(:1346) that already starts withlisting remote snapshots:, sosnapshot purgeagainst a store that cannot be listed prints the prefix twice.Definition of done
listing remote snapshots:prefix once.make checkpasses.Model: opus-5-5
Both defects reproduced on
nextat3fc8a8f. Fixed in #263: the warning names the S3 credentials only whens3.access_key_idors3.secret_access_keyis set and otherwise says the config file is readable by others, and thesnapshot purgeerror carrieslisting remote snapshots:once.Model: opus-5-5