Scope the process-wide PID lock to mutating commands #150

New Issue

2026-09-21T22:03:35+02:00

clawbot commented

2026-09-21 22:03:35 +02:00

Split from #74 (item 5). RunWithApp (internal/cli/app.go) unconditionally acquires a process-wide lock at $XDG_DATA_HOME/vaultik/vaultik.pid for every fx-backed command. Read-only commands (snapshot list, info, snapshot verify, remote info) therefore fail with an "already running" error while a backup is in progress. #74 documented this behavior; this issue proposes scoping the lock so read-only commands are not blocked by a running backup.

Definition of done

Query/read-only commands (snapshot list, snapshot verify, info, remote info) run to completion while a snapshot create holds the lock, instead of failing with "already running". Commands that write the local index or remote store still mutually exclude. The partition of which commands take the lock is made explicitly, and the README locking section is updated to match. Tests cover a read-only command succeeding during a simulated concurrent mutator. make check green.

model: claude-opus-4-8

Split from https://git.eeqj.de/sneak/vaultik/issues/74 (item 5). `RunWithApp` (`internal/cli/app.go`) unconditionally acquires a process-wide lock at `$XDG_DATA_HOME/vaultik/vaultik.pid` for every fx-backed command. Read-only commands (`snapshot list`, `info`, `snapshot verify`, `remote info`) therefore fail with an "already running" error while a backup is in progress. #74 documented this behavior; this issue proposes scoping the lock so read-only commands are not blocked by a running backup. ## Definition of done Query/read-only commands (`snapshot list`, `snapshot verify`, `info`, `remote info`) run to completion while a `snapshot create` holds the lock, instead of failing with "already running". Commands that write the local index or remote store still mutually exclude. The partition of which commands take the lock is made explicitly, and the README locking section is updated to match. Tests cover a read-only command succeeding during a simulated concurrent mutator. `make check` green. model: claude-opus-4-8

clawbot referenced this issue from a commit

2026-09-22 01:07:40 +02:00

Reconcile docs with code across the accuracy-sweep items (closes #74)

clawbot referenced this issue

2026-09-22 01:08:08 +02:00

Reconcile docs with code across the accuracy-sweep items (closes #74) #174

clawbot referenced this issue

2026-09-22 01:08:45 +02:00

Documentation accuracy sweep: undocumented behavior and stale claims #74

clawbot referenced this issue from a commit

2026-09-22 09:05:37 +02:00

Reconcile docs with code across the accuracy-sweep items (closes #74)

~~clawbot referenced this issue 2026-09-22 09:10:30 +02:00~~

next: integrate accumulated work into main #114

clawbot referenced this issue from a commit

2026-09-22 10:43:04 +02:00

Scope the PID lock to mutating commands (closes #150)

clawbot referenced a pull request that will close this issue

2026-09-22 10:43:24 +02:00

Scope the PID lock to mutating commands #179

clawbot commented

2026-09-22 10:43:48 +02:00

Implemented in #179.

The process-wide PID lock is now taken only by commands that write the local index or remote store — snapshot create, snapshot purge, snapshot remove, prune, remote nuke — which still exclude each other. Read-only commands — info, snapshot list, snapshot verify, remote info — no longer take the lock and run to completion during a backup. Each command declares its mode at the call site, and the README locking section is updated to match.

Judgement call: snapshot restore is grouped with the read-only commands. It writes only to the target directory you name (and a temporary copy of the snapshot database), never the local index or remote store, so it does not take the lock.

Model: opus-4-8

Implemented in https://git.eeqj.de/sneak/vaultik/pulls/179. The process-wide PID lock is now taken only by commands that write the local index or remote store — `snapshot create`, `snapshot purge`, `snapshot remove`, `prune`, `remote nuke` — which still exclude each other. Read-only commands — `info`, `snapshot list`, `snapshot verify`, `remote info` — no longer take the lock and run to completion during a backup. Each command declares its mode at the call site, and the README locking section is updated to match. Judgement call: `snapshot restore` is grouped with the read-only commands. It writes only to the target directory you name (and a temporary copy of the snapshot database), never the local index or remote store, so it does not take the lock. Model: opus-4-8

clawbot closed this issue

2026-09-22 11:01:30 +02:00

clawbot referenced this issue from a commit

2026-09-22 11:01:31 +02:00

Scope the PID lock to mutating commands (closes #150)

clawbot referenced this issue

2026-09-22 11:03:59 +02:00

next: integrate accumulated work into main #114

Sign in to join this conversation.