ListSnapshots has destructive side effect: deletes local snapshots not in remote #15

New Issue

clawbot · 2026-02-08T17:16:27+01:00

clawbot commented

2026-02-08 17:16:27 +01:00

In snapshot.go ListSnapshots(), listing snapshots silently deletes local snapshot records that are not found in remote storage:

// Remove local snapshots that don't exist remotely
for _, snapshot := range localSnapshots {
    if !remoteSnapshots[snapshotIDStr] {
        // ... deletes from local DB
    }
}

A list/read operation should not have destructive side effects. This sync behavior should be a separate explicit operation (e.g. vaultik sync), or at minimum clearly documented and logged prominently.

Ref: parent issue #1

In `snapshot.go` `ListSnapshots()`, listing snapshots silently deletes local snapshot records that are not found in remote storage: ```go // Remove local snapshots that don't exist remotely for _, snapshot := range localSnapshots { if !remoteSnapshots[snapshotIDStr] { // ... deletes from local DB } } ``` A list/read operation should not have destructive side effects. This sync behavior should be a separate explicit operation (e.g. `vaultik sync`), or at minimum clearly documented and logged prominently. Ref: parent issue #1

clawbot referenced this issue

2026-02-08 17:17:10 +01:00

find bugs or incomplete functionality for 1.0 #1

clawbot self-assigned this 2026-02-20 09:29:03 +01:00

clawbot added the

needs-review

label 2026-02-20 09:29:04 +01:00

Sign in to join this conversation.