RemoveAllSnapshots has O(n²) duplicate detection for snapshot IDs #12

New Issue

clawbot · 2026-02-08T17:16:25+01:00

clawbot commented

2026-02-08 17:16:25 +01:00

In snapshot.go RemoveAllSnapshots(), duplicate snapshot IDs are detected with a linear scan:

found := false
for _, id := range snapshotIDs {
    if id == sid {
        found = true
        break
    }
}

This is O(n²) overall. Should use a map[string]bool for O(1) lookups. Same pattern exists in PruneBlobs().

Ref: parent issue #1

In `snapshot.go` `RemoveAllSnapshots()`, duplicate snapshot IDs are detected with a linear scan: ```go found := false for _, id := range snapshotIDs { if id == sid { found = true break } } ``` This is O(n²) overall. Should use a `map[string]bool` for O(1) lookups. Same pattern exists in `PruneBlobs()`. Ref: parent issue #1

clawbot referenced this issue

2026-02-08 17:17:10 +01:00

find bugs or incomplete functionality for 1.0 #1

clawbot self-assigned this 2026-02-20 09:29:07 +01:00

clawbot added the needs-review label 2026-02-20 09:29:08 +01:00

clawbot referenced this issue from a commit

2026-03-17 13:49:06 +01:00

fix: replace O(n²) duplicate detection with map-based O(1) lookups

clawbot referenced this issue

2026-03-17 13:49:11 +01:00

fix: replace O(n²) duplicate detection with map-based O(1) lookups #45

clawbot referenced this issue