Dockerfile.lint citation names an lll finding where the PR records revive #118

Closed
opened 2026-09-03 23:55:19 +02:00 by clawbot · 1 comment
Collaborator

Split out of issue #115part 3 of 3. Trivial; suitable as filler work in a short window.

The defect

Dockerfile.lint:73-76 cites pull request #114 as recording that script/lint "exits 1 naming the lll finding". The evidence block on that PR names a revive finding, and explains why it was revive and not lll (golangci-lint reports one issue per line by default; neither linter is in its default set, which is the point).

The claim itself is true — a run does produce lll — only the citation is wrong. Verify against the PR body before changing it, then fix the cited linter name to match what the PR actually records.

Definition of done

  • The citation at Dockerfile.lint:73-76 names the linter the PR evidence block actually records. Essentially one word.
  • make check green, evidence on the PR. script/cibuild is not required.
  • Branch off next. PR based on next, not main.
  • Commit title ends with a bare (closes #N) naming this issue's number — a bare #N, never a markdown link, or Gitea will not auto-close it.
Split out of [issue #115](https://git.eeqj.de/sneak/vaultik/issues/115) — **part 3 of 3**. Trivial; suitable as filler work in a short window. ## The defect `Dockerfile.lint:73-76` cites [pull request #114](https://git.eeqj.de/sneak/vaultik/pulls/114) as recording that `script/lint` "exits 1 naming the `lll` finding". The evidence block on that PR names a **`revive`** finding, and explains why it was `revive` and not `lll` (golangci-lint reports one issue per line by default; neither linter is in its default set, which is the point). The claim itself is true — a run does produce `lll` — only the **citation** is wrong. Verify against the PR body before changing it, then fix the cited linter name to match what the PR actually records. ## Definition of done - The citation at `Dockerfile.lint:73-76` names the linter the PR evidence block actually records. Essentially one word. - `make check` green, evidence on the PR. `script/cibuild` is **not** required. - Branch off `next`. PR based on `next`, **not** `main`. - Commit title ends with a bare ` (closes #N)` naming **this** issue's number — a bare `#N`, never a markdown link, or Gitea will not auto-close it.
clawbot added this to the 1.0.0 milestone 2026-09-03 23:55:19 +02:00
clawbot self-assigned this 2026-09-03 23:55:19 +02:00
Author
Collaborator

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted.

Model: fable-5-1

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted. Model: fable-5-1
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/vaultik#118