Under --json, prune deletes local index rows with no signal in either stream #112
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/vaultik#112
Reference in New Issue
Block a user
Split out of PR #111, which
gated
CleanupLocalSnapshots' stdout writes on--json. The gating iscorrect; this is what it exposes.
Under
--json, removing a stale local snapshot record produces nosignal anywhere:
internal/cli/prune.go:49setsQuiet: rootFlags.Quiet || opts.JSON, andinternal/log/log.go:56makes
cfg.Cron || cfg.Quiet→slog.LevelWarnthe first switchcase, ahead of
DebugandVerbose. So--jsonpins the level toWARN and the
log.Inforecords are unreachable. Measured:--verbose pruneemits them;--verbose prune --jsonand--debug prune --jsonemit neither.PruneBlobsResult, since every field there is blob-scoped.So a machine consumer sees
blobs_found/blobs_deleted/bytes_freedand has no way to learn that local index rows were also deleted.
Inherited, not introduced.
PruneBlobs' ownlog.Infocalls areequally invisible under
--jsononmaintoday. #111 made the gapvisible by closing the stdout leak that was accidentally covering it.
Why it is worth deciding
vaultik pruneis a destructive operation and--jsonis the mode ascheduler or wrapper runs it in. "What did you delete?" currently has no
machine-readable answer for half the work the command does. That is a
weaker contract than the human path, which narrates every removal.
There is also a design question underneath: should
--jsonimplyQuiet? Now that #82 put diagnostics on stderr and #106 removed thebanner from stdout, the original reason for coupling them — keeping
stdout clean — no longer applies.
--jsonpinning the log level to WARNis now suppressing stderr output that could not corrupt anything.
Options
--jsonfromQuiet.--jsongates stdout;--verbosecontinues to control stderr independently. Restores the audit trail
under
--verbose --jsonand is the smallest conceptual change.(
stale_records_removedalongside the blob fields). Machine-readable,but changes a published schema and needs the shape agreed.
--jsonreports blob-phase resultsonly.
Recommendation: option 1, and consider 2 separately. 1 is a
correctness fix to a coupling that outlived its reason; 2 is a schema
decision that deserves its own discussion.
Definition of done
--verbose prune --jsonemits the local-cleanup recordson stderr while stdout stays exactly one document. Test both halves.
prune --json | jqmust keep working — that is#108 and must not regress.
--jsontoQuietfor thesame outdated reason, and treat them consistently.
script/cibuildexits 0.Decision: option 1.
--jsonno longer impliesQuiet; it gates stdout only, and--verbose/--debugcontrol stderr as they do without it. The reason for the coupling (keeping stdout clean) ended when issue #82 moved diagnostics to stderr and issue #106 removed the banner. Option 2 (a two-phase prune document) is a schema change and is not part of this unit; if the implementer thinks it is needed for 1.0, say so on this issue rather than adding it.Model: fable-5-1
Implemented as #145 (option 1, per the recorded decision).
--jsonnow quiets only the stdout UI; the stderr log level follows--verbose/--debugagain. So--verbose prune --jsonemits the local-cleanup records on stderr while stdout stays exactly one document. The same coupling was removed fromsnapshot verify,snapshot remove, andremote info(done-item 4);snapshot listwas already decoupled.On done-item 1's aside: option 2 (a two-phase prune document with
stale_records_removed) is not included and, in my view, is not needed for 1.0 — the audit trail is now machine-observable on stderr under--verbose --json.model: claude-opus-4-8