vaultik

294 Commits 4 Branches 0 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
sneak	f131e59d56	Join the S3 prefix to every key with one slash (closes #222 ) check / check (push) Waiting to run Details The S3 client built each key as prefix + key, and the URL parser keeps the prefix as written, so s3://bucket/p stored p + "blobs/..." with no slash while s3://bucket/p/ stored p/blobs/.... A recovery host that wrote the URL the other way found no snapshots. NewClient now strips trailing slashes from the prefix and adds one back when anything is left, giving the README layout for both URL forms; an empty prefix stays at the bucket root. The s3.prefix config setting goes through the same client and gets the same join. A new test writes and lists through each URL shape against an in-process S3 server and checks the keys in the bucket. Model: opus-5-5	2026-10-06 15:35:06 +00:00
clawbot	a50e3fa038	Add tests for internal/storage: URL parsing, backends, shared conformance suite (closes #66 ) check / check (push) Failing after 1s Details check / check (pull_request) Successful in 3m25s Details internal/storage, the package that parses store URLs and selects the backend, had no tests. Adds table-driven tests for URL parsing (each scheme, query parameters, malformed input, unknown scheme, backend type chosen); one shared conformance suite for the Storer interface, run against the file backend in a temp directory and the s3 backend on the in-process harness internal/s3 already uses, so a new backend inherits it; and rclone construction and argument tests using its in-process local backend. A comment records that rclone data operations need a configured remote and are not unit-tested. No production code changed and no defect surfaced. model: claude-opus-4-8 (implementation, review); claude-fable-5-1 (merge)	2026-09-22 00:58:27 +02:00
clawbot	9ca962969a	Map s3 not-found to storage.ErrNotFound in Get and Stat (closes #129 ) check / check (push) Failing after 1s Details check / check (pull_request) Successful in 3m50s Details The Storer interface documents that Get and Stat return storage.ErrNotFound for a missing object. The file and rclone backends did; the s3 backend returned the raw SDK error, so callers testing for ErrNotFound behaved differently on s3. S3Storer.Get and Stat now wrap ErrNotFound when the SDK reports a missing object and leave every other error untouched. The SDK reports a missing key two ways (NoSuchKey from Get, NotFound from Head); both are recognised in one helper, s3.IsNotFound, which HeadObject now also uses. The mapping lives in the storage package because internal/s3 cannot import it. model: claude-opus-4-8 (implementation, review); claude-fable-5-1 (merge)	2026-09-21 21:07:35 +02:00

Author

SHA1

Message

Date

sneak

f131e59d56

Join the S3 prefix to every key with one slash (closes #222 )

check / check (push) Waiting to run

Details

The S3 client built each key as prefix + key, and the URL parser keeps
the prefix as written, so s3://bucket/p stored p + "blobs/..." with no
slash while s3://bucket/p/ stored p/blobs/.... A recovery host that wrote
the URL the other way found no snapshots.

NewClient now strips trailing slashes from the prefix and adds one back
when anything is left, giving the README layout for both URL forms; an
empty prefix stays at the bucket root. The s3.prefix config setting
goes through the same client and gets the same join.

A new test writes and lists through each URL shape against an
in-process S3 server and checks the keys in the bucket.

Model: opus-5-5

2026-10-06 15:35:06 +00:00

clawbot

a50e3fa038

Add tests for internal/storage: URL parsing, backends, shared conformance suite (closes #66 )

check / check (push) Failing after 1s

Details

check / check (pull_request) Successful in 3m25s

Details

internal/storage, the package that parses store URLs and selects the backend, had no tests.

Adds table-driven tests for URL parsing (each scheme, query parameters, malformed input, unknown scheme, backend type chosen); one shared conformance suite for the Storer interface, run against the file backend in a temp directory and the s3 backend on the in-process harness internal/s3 already uses, so a new backend inherits it; and rclone construction and argument tests using its in-process local backend. A comment records that rclone data operations need a configured remote and are not unit-tested. No production code changed and no defect surfaced.

model: claude-opus-4-8 (implementation, review); claude-fable-5-1 (merge)

2026-09-22 00:58:27 +02:00

clawbot

9ca962969a

Map s3 not-found to storage.ErrNotFound in Get and Stat (closes #129 )

check / check (push) Failing after 1s

Details

check / check (pull_request) Successful in 3m50s

Details

The Storer interface documents that Get and Stat return storage.ErrNotFound for a missing object. The file and rclone backends did; the s3 backend returned the raw SDK error, so callers testing for ErrNotFound behaved differently on s3.

S3Storer.Get and Stat now wrap ErrNotFound when the SDK reports a missing object and leave every other error untouched. The SDK reports a missing key two ways (NoSuchKey from Get, NotFound from Head); both are recognised in one helper, s3.IsNotFound, which HeadObject now also uses. The mapping lives in the storage package because internal/s3 cannot import it.

model: claude-opus-4-8 (implementation, review); claude-fable-5-1 (merge)

2026-09-21 21:07:35 +02:00