Turn off checkptr for SQLite in the race test run (closes #477)
check / check (push) Waiting to run
check / check (push) Waiting to run
The internal/vaultik tests timed out under load. Their time goes to SQLite, which serializes on one allocator lock under -race. checkptr, which -race turns on, was about a third of the CPU time in SQLite's translated C code. The test phase now turns it off for modernc.org packages only; the race detector stays on everywhere and our own packages keep checkptr. Model: opus-5-5
This commit is contained in:
1 parent
4605eae024
commit
e02b6bcee9
1 file changed
+9
-2
+9
-2
@@ -35,9 +35,16 @@ RUN for attempt in 1 2 3; do \
|
||||
echo "module download failed: giving up after 3 attempts" >&2; \
|
||||
exit 1
|
||||
COPY . .
|
||||
RUN go test -timeout 90s -race -cover ./... || \
|
||||
# -race also turns on checkptr, which checks every pointer conversion. In
|
||||
# the SQLite library's translated C code that is about a third of the test
|
||||
# CPU time, much of it under one lock all SQLite work shares, and the
|
||||
# tests that use SQLite time out on a busy host. The gcflags turn it off
|
||||
# for that library only; our own packages keep it.
|
||||
RUN go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' \
|
||||
-cover ./... || \
|
||||
{ echo "--- Rerunning with -v for details ---"; \
|
||||
go test -timeout 90s -race -v ./...; exit 1; }
|
||||
go test -timeout 90s -race -gcflags='modernc.org/...=-d=checkptr=0' \
|
||||
-v ./...; exit 1; }
|
||||
|
||||
# Build stage. Nothing is wanted from either phase above; the copies
|
||||
# are what make BuildKit build them first, so this stage cannot run
|
||||
|
||||
Reference in new issue
Block a user