Update golangci-lint to v2.12.2 with canonical config (#62)

Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green.

## Version bump

- `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated)
- `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2`
- `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables)
- `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged
- CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change

## Lint remediation

The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights:

- `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is`
- `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated
- `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added
- `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants
- `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code)
- tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages
- `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications
- remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags)
- removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`)

`make check` (tests with `-race`, lint, fmt-check) passes.

Co-authored-by: sneak <sneak@sneak.berlin>
Reviewed-on: #62
Co-authored-by: clawbot <clawbot@noreply.example.org>
Co-committed-by: clawbot <clawbot@noreply.example.org>

internal/vaultik/remove_snapshot_test.go

@@ -29,7 +29,7 @@ func newTestStorer() *testStorer {
 	}
 }
 
-func (s *testStorer) Put(ctx context.Context, key string, reader io.Reader) error {
+func (s *testStorer) Put(_ context.Context, key string, reader io.Reader) error {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
@@ -43,11 +43,14 @@ func (s *testStorer) Put(ctx context.Context, key string, reader io.Reader) erro
 	return nil
 }
 
-func (s *testStorer) PutWithProgress(ctx context.Context, key string, reader io.Reader, size int64, progress storage.ProgressCallback) error {
+func (s *testStorer) PutWithProgress(
+	ctx context.Context, key string, reader io.Reader,
+	_ int64, _ storage.ProgressCallback,
+) error {
 	return s.Put(ctx, key, reader)
 }
 
-func (s *testStorer) Get(ctx context.Context, key string) (io.ReadCloser, error) {
+func (s *testStorer) Get(_ context.Context, key string) (io.ReadCloser, error) {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
@@ -59,7 +62,7 @@ func (s *testStorer) Get(ctx context.Context, key string) (io.ReadCloser, error)
 	return io.NopCloser(bytes.NewReader(data)), nil
 }
 
-func (s *testStorer) Stat(ctx context.Context, key string) (*storage.ObjectInfo, error) {
+func (s *testStorer) Stat(_ context.Context, key string) (*storage.ObjectInfo, error) {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
@@ -74,7 +77,7 @@ func (s *testStorer) Stat(ctx context.Context, key string) (*storage.ObjectInfo,
 	}, nil
 }
 
-func (s *testStorer) Delete(ctx context.Context, key string) error {
+func (s *testStorer) Delete(_ context.Context, key string) error {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
@@ -83,7 +86,7 @@ func (s *testStorer) Delete(ctx context.Context, key string) error {
 	return nil
 }
 
-func (s *testStorer) List(ctx context.Context, prefix string) ([]string, error) {
+func (s *testStorer) List(_ context.Context, prefix string) ([]string, error) {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
@@ -98,7 +101,9 @@ func (s *testStorer) List(ctx context.Context, prefix string) ([]string, error)
 	return keys, nil
 }
 
-func (s *testStorer) ListStream(ctx context.Context, prefix string) <-chan storage.ObjectInfo {
+func (s *testStorer) ListStream(
+	_ context.Context, prefix string,
+) <-chan storage.ObjectInfo {
 	ch := make(chan storage.ObjectInfo)
 
 	go func() {
@@ -120,6 +125,13 @@ func (s *testStorer) ListStream(ctx context.Context, prefix string) <-chan stora
 	return ch
 }
 
+func (s *testStorer) Info() storage.Info {
+	return storage.Info{
+		Type:     testLabel,
+		Location: "memory",
+	}
+}
+
 func (s *testStorer) hasKey(key string) bool {
 	s.mu.Lock()
 	defer s.mu.Unlock()
@@ -136,17 +148,16 @@ func (s *testStorer) keyCount() int {
 	return len(s.data)
 }
 
-func (s *testStorer) Info() storage.StorageInfo {
-	return storage.StorageInfo{
-		Type:     "test",
-		Location: "memory",
-	}
-}
+// testBlobHashA is a fixture blob hash reused across the remove tests.
+const testBlobHashA = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" +
+	"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
 
 // addManifest creates a compressed manifest in storage at the same
 // hashed path the production code uses. snapshotID is the human ID;
 // the storage path uses RemoteSnapshotKey(id).
-func addManifest(t *testing.T, store *testStorer, snapshotID string, blobHashes []string) {
+func addManifest(
+	t *testing.T, store *testStorer, snapshotID string, blobHashes []string,
+) {
 	t.Helper()
 
 	blobs := make([]snapshot.BlobInfo, len(blobHashes))
@@ -173,11 +184,12 @@ func addManifest(t *testing.T, store *testStorer, snapshotID string, blobHashes
 }
 
 // remoteKeyPath returns the storage-relative path to a snapshot's
-// metadata directory or manifest under the hashed remote-key scheme.
-// Tests use this in hasKey/asserts to avoid scattering RemoteSnapshotKey
-// calls throughout.
-func remoteKeyPath(snapshotID, suffix string) string {
-	return "metadata/" + snapshot.RemoteSnapshotKey(snapshotID) + "/" + suffix
+// manifest under the hashed remote-key scheme. Tests use this in
+// hasKey/asserts to avoid scattering RemoteSnapshotKey calls
+// throughout.
+func remoteKeyPath(snapshotID string) string {
+	return "metadata/" + snapshot.RemoteSnapshotKey(snapshotID) +
+		"/manifest.json.zst"
 }
 
 // addBlob adds a fake blob to storage
@@ -206,10 +218,11 @@ func addBlob(t *testing.T, store *testStorer, hash string) {
 // untouched.
 func TestRemoveSnapshot_LocalOnly_PreservesRemote(t *testing.T) {
 	log.Initialize(log.Config{})
+	t.Parallel()
 
 	store := newTestStorer()
 
-	blobA := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	blobA := testBlobHashA
 	addManifest(t, store, "snapshot-001", []string{blobA})
 	addBlob(t, store, blobA)
 
@@ -223,9 +236,10 @@ func TestRemoveSnapshot_LocalOnly_PreservesRemote(t *testing.T) {
 	assert.False(t, result.RemoteRemoved)
 
 	assert.True(t, store.hasKey("blobs/aa/aa/"+blobA))
-	assert.True(t, store.hasKey(remoteKeyPath("snapshot-001", "manifest.json.zst")))
+	assert.True(t, store.hasKey(remoteKeyPath("snapshot-001")))
 
-	assert.Contains(t, tv.Stdout.String(), "Removed snapshot 'snapshot-001' from local database")
+	assert.Contains(t, tv.Stdout.String(),
+		"Removed snapshot 'snapshot-001' from local database")
 }
 
 // TestRemoveSnapshot_DefaultRemovesMetadataNotBlobs is the canonical
@@ -235,10 +249,11 @@ func TestRemoveSnapshot_LocalOnly_PreservesRemote(t *testing.T) {
 // remaining remote manifest, and the output prints that exact command.
 func TestRemoveSnapshot_DefaultRemovesMetadataNotBlobs(t *testing.T) {
 	log.Initialize(log.Config{})
+	t.Parallel()
 
 	store := newTestStorer()
 
-	blobUnique := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	blobUnique := testBlobHashA
 	blobShared := "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"
 
 	addManifest(t, store, "snapshot-001", []string{blobUnique, blobShared})
@@ -255,8 +270,8 @@ func TestRemoveSnapshot_DefaultRemovesMetadataNotBlobs(t *testing.T) {
 	assert.Equal(t, "snapshot-001", result.SnapshotID)
 	assert.True(t, result.RemoteRemoved)
 
-	assert.False(t, store.hasKey(remoteKeyPath("snapshot-001", "manifest.json.zst")))
-	assert.True(t, store.hasKey(remoteKeyPath("snapshot-002", "manifest.json.zst")))
+	assert.False(t, store.hasKey(remoteKeyPath("snapshot-001")))
+	assert.True(t, store.hasKey(remoteKeyPath("snapshot-002")))
 	// Blobs are intentionally NOT touched — that's what `vaultik prune`
 	// is for.
 	assert.True(t, store.hasKey("blobs/aa/aa/"+blobUnique))
@@ -270,10 +285,11 @@ func TestRemoveSnapshot_DefaultRemovesMetadataNotBlobs(t *testing.T) {
 
 func TestRemoveSnapshot_DryRun(t *testing.T) {
 	log.Initialize(log.Config{})
+	t.Parallel()
 
 	store := newTestStorer()
 
-	blobA := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	blobA := testBlobHashA
 	addManifest(t, store, "snapshot-001", []string{blobA})
 	addBlob(t, store, blobA)
 
@@ -289,13 +305,14 @@ func TestRemoveSnapshot_DryRun(t *testing.T) {
 
 	assert.Equal(t, initialCount, store.keyCount())
 	assert.True(t, store.hasKey("blobs/aa/aa/"+blobA))
-	assert.True(t, store.hasKey(remoteKeyPath("snapshot-001", "manifest.json.zst")))
+	assert.True(t, store.hasKey(remoteKeyPath("snapshot-001")))
 
 	assert.Contains(t, tv.Stdout.String(), "[Dry run - no changes made]")
 }
 
 func TestRemoveAllSnapshots_RequiresForce(t *testing.T) {
 	log.Initialize(log.Config{})
+	t.Parallel()
 
 	store := newTestStorer()
 	addManifest(t, store, "snapshot-001", []string{})
@@ -306,16 +323,17 @@ func TestRemoveAllSnapshots_RequiresForce(t *testing.T) {
 	opts := &vaultik.RemoveOptions{} // No Force
 	_, err := tv.RemoveAllSnapshots(opts)
 
-	assert.Error(t, err)
+	require.Error(t, err)
 	assert.Contains(t, err.Error(), "--all requires --force")
 }
 
 func TestRemoveAllSnapshots_WithForce(t *testing.T) {
 	log.Initialize(log.Config{})
+	t.Parallel()
 
 	store := newTestStorer()
 
-	blobA := "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
+	blobA := testBlobHashA
 	addManifest(t, store, "snapshot-001", []string{blobA})
 	addManifest(t, store, "snapshot-002", []string{blobA})
 	addBlob(t, store, blobA)
@@ -331,8 +349,8 @@ func TestRemoveAllSnapshots_WithForce(t *testing.T) {
 
 	// Blobs intentionally preserved — that's prune's job.
 	assert.True(t, store.hasKey("blobs/aa/aa/"+blobA))
-	assert.False(t, store.hasKey(remoteKeyPath("snapshot-001", "manifest.json.zst")))
-	assert.False(t, store.hasKey(remoteKeyPath("snapshot-002", "manifest.json.zst")))
+	assert.False(t, store.hasKey(remoteKeyPath("snapshot-001")))
+	assert.False(t, store.hasKey(remoteKeyPath("snapshot-002")))
 
 	out := tv.Stdout.String()
 	assert.Contains(t, out, "Removed 2 snapshot(s)")
@@ -342,6 +360,7 @@ func TestRemoveAllSnapshots_WithForce(t *testing.T) {
 
 func TestRemoveAllSnapshots_DryRun(t *testing.T) {
 	log.Initialize(log.Config{})
+	t.Parallel()
 
 	store := newTestStorer()
 	addManifest(t, store, "snapshot-001", []string{})
@@ -368,6 +387,7 @@ func TestRemoveAllSnapshots_DryRun(t *testing.T) {
 
 func TestRemoveAllSnapshots_NoSnapshots(t *testing.T) {
 	log.Initialize(log.Config{})
+	t.Parallel()
 
 	store := newTestStorer()
 	// No snapshots added