Update golangci-lint to v2.12.2 with canonical config (#62)

Updates golangci-lint to v2.12.2 everywhere it is pinned and installs the canonical `.golangci.yml`, then remediates every finding the new linter/config surfaces so `make check` is green.

## Version bump

- `Dockerfile` lint stage: `golangci/golangci-lint:v2.11.3-alpine` -> `v2.12.2-alpine` (digest-pinned, date comment updated)
- `Makefile` `deps` target: `go install` moved from the old v1 module path at `@latest` to the pinned `github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2`
- `.golangci.yml` replaced with the canonical config (v2 schema; settings under `linters.settings` so the thresholds actually apply; `default: all` with the standard six disables)
- `script/bootstrap` installs golangci-lint via the system package manager and carries no version pin, so it is unchanged
- CI (`.gitea/workflows/check.yml`) only runs `script/cibuild`, so it needed no change

## Lint remediation

The canonical config surfaced ~3,300 findings across 56k lines. All are fixed, behavior-preserving; incorporates and supersedes the per-package mechanical passes already merged to `main` (refs #61). Highlights:

- `err113`: dynamic errors replaced with package sentinels + `%w` wrapping; comparisons via `errors.Is`
- `goprintffuncname`: printf-style helpers renamed with an `f` suffix (`ui.Writer` message methods, `cli.ReportErrorf`, `database.Fatalf`) and all call sites updated
- `revive` stutter renames: `blob.Handler`, `blob.WithReader`, `blob.ChunkPosition`, `storage.URL`, `storage.Info`; missing doc comments added
- `contextcheck`/`noctx`: `context.Context` threaded through `blob.Packer` and the scanner call sites; context-aware `exec`/`sql` variants
- `funlen`/`cyclop`/`gocognit`/`dupl`: oversized and duplicated functions split into focused helpers (production and test code)
- tests: `t.Parallel()` added where safe (global logger init kept in the serial phase for `-race`), `t.TempDir()`/`t.Helper()` adopted, several suites converted to external test packages
- `gosec`: bounded integer conversions, `ReadHeaderTimeout` on the test HTTP server; remaining warnings suppressed per-site with justifications
- remaining `nolint` directives are rare, targeted, and each carries a reason (e.g. `nilnil` not-found contract in the repository layer, fx module globals, on-disk snake_case struct tags)
- removed the deprecated `log.LogOptions` alias (callers migrated to `log.Options`)

`make check` (tests with `-race`, lint, fmt-check) passes.

Co-authored-by: sneak <sneak@sneak.berlin>
Reviewed-on: #62
Co-authored-by: clawbot <clawbot@noreply.example.org>
Co-committed-by: clawbot <clawbot@noreply.example.org>

internal/ui/ui_test.go

@@ -1,37 +1,45 @@
-package ui
+package ui_test
 
 import (
 	"bytes"
 	"strings"
 	"testing"
 	"time"
+
+	"sneak.berlin/go/vaultik/internal/ui"
 )
 
-func newTestWriter(color bool) (*Writer, *bytes.Buffer) {
+func newTestWriter(color bool) (*ui.Writer, *bytes.Buffer) {
 	buf := &bytes.Buffer{}
 
-	return NewWithColor(buf, color), buf
+	return ui.NewWithColor(buf, color), buf
 }
 
 func TestMessageMethodsPlain(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		method string
-		fn     func(*Writer)
+		fn     func(*ui.Writer)
 		want   string
 	}{
-		{"Begin", func(w *Writer) { w.Begin("starting %s", "thing") }, "》 starting thing\n"},
-		{"Complete", func(w *Writer) { w.Complete("done %s", "thing") }, "》 done thing\n"},
-		{"Info", func(w *Writer) { w.Info("status") }, "》 status\n"},
-		{"Notice", func(w *Writer) { w.Notice("note") }, "》 note\n"},
-		{"Warning", func(w *Writer) { w.Warning("oops") }, "⚠️  Warning: oops\n"},
-		{"Error", func(w *Writer) { w.Error("boom") }, "🛑 ERROR: boom\n"},
-		{"Progress", func(w *Writer) { w.Progress("p") }, "  》 p\n"},
-		{"Detail", func(w *Writer) { w.Detail("d") }, "  》 d\n"},
-		{"Banner", func(w *Writer) { w.Banner("hello") }, "hello\n"}, // plain mode, no bold
+		{"Begin", func(w *ui.Writer) { w.Beginf("starting %s", "thing") },
+			"》 starting thing\n"},
+		{"Complete", func(w *ui.Writer) { w.Completef("done %s", "thing") },
+			"》 done thing\n"},
+		{"Info", func(w *ui.Writer) { w.Infof("status") }, "》 status\n"},
+		{"Notice", func(w *ui.Writer) { w.Noticef("note") }, "》 note\n"},
+		{"Warning", func(w *ui.Writer) { w.Warningf("oops") }, "⚠️  Warning: oops\n"},
+		{"Error", func(w *ui.Writer) { w.Errorf("boom") }, "🛑 ERROR: boom\n"},
+		{"Progress", func(w *ui.Writer) { w.Progressf("p") }, "  》 p\n"},
+		{"Detail", func(w *ui.Writer) { w.Detailf("d") }, "  》 d\n"},
+		{"Banner", func(w *ui.Writer) { w.Bannerf("hello") }, "hello\n"}, // plain, no bold
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.method, func(t *testing.T) {
+			t.Parallel()
+
 			w, buf := newTestWriter(false)
 			tt.fn(w)
 
@@ -43,15 +51,17 @@ func TestMessageMethodsPlain(t *testing.T) {
 }
 
 func TestWarningErrorCounters(t *testing.T) {
+	t.Parallel()
+
 	w, _ := newTestWriter(false)
 	if w.WarningCount() != 0 || w.ErrorCount() != 0 {
 		t.Fatalf("expected fresh writer to have zero counts")
 	}
 
-	w.Info("normal")
-	w.Warning("first warn")
-	w.Warning("second warn")
-	w.Error("only error")
+	w.Infof("normal")
+	w.Warningf("first warn")
+	w.Warningf("second warn")
+	w.Errorf("only error")
 
 	if got, want := w.WarningCount(), 2; got != want {
 		t.Errorf("WarningCount: got %d, want %d", got, want)
@@ -63,8 +73,10 @@ func TestWarningErrorCounters(t *testing.T) {
 }
 
 func TestColorOutputContainsANSI(t *testing.T) {
+	t.Parallel()
+
 	w, buf := newTestWriter(true)
-	w.Error("boom")
+	w.Errorf("boom")
 
 	out := buf.String()
 	if !strings.Contains(out, "\033[") {
@@ -77,8 +89,10 @@ func TestColorOutputContainsANSI(t *testing.T) {
 }
 
 func TestBannerBoldWhenColor(t *testing.T) {
+	t.Parallel()
+
 	w, buf := newTestWriter(true)
-	w.Banner("hello")
+	w.Bannerf("hello")
 
 	out := buf.String()
 	if !strings.Contains(out, "\033[1m") {
@@ -87,6 +101,8 @@ func TestBannerBoldWhenColor(t *testing.T) {
 }
 
 func TestValueFormattersPlain(t *testing.T) {
+	t.Parallel()
+
 	w, _ := newTestWriter(false)
 
 	if got := w.Hex("0123456789abcdef0123"); got != "0123456789ab..." {
@@ -127,18 +143,26 @@ func TestValueFormattersPlain(t *testing.T) {
 	}
 
 	// Time format: today → HH:MM:SS, other day → YYYY-MM-DD HH:MM:SS.
-	today := time.Date(time.Now().Year(), time.Now().Month(), time.Now().Day(), 14, 30, 45, 0, time.Local)
+	// These construct local-zone times on purpose: Writer.Time displays
+	// in the process's local zone.
+	now := time.Now()
+
+	today := time.Date(now.Year(), now.Month(), now.Day(),
+		14, 30, 45, 0, time.Local) //nolint:gosmopolitan // local display
 	if got := w.Time(today); got != "14:30:45" {
 		t.Errorf("Time today: got %q, want 14:30:45", got)
 	}
 
-	other := time.Date(2030, 1, 2, 3, 4, 5, 0, time.Local)
+	other := time.Date(2030, 1, 2, 3, 4, 5, 0,
+		time.Local) //nolint:gosmopolitan // local display
 	if got := w.Time(other); got != "2030-01-02 03:04:05" {
 		t.Errorf("Time other day: got %q", got)
 	}
 }
 
 func TestValueFormattersColored(t *testing.T) {
+	t.Parallel()
+
 	w, _ := newTestWriter(true)
 
 	hex := w.Hex("0123456789abcdef0123")