Bind the local index only after a backup writes the marker (closes #420)
check / check (push) Successful in 9m13s

A first backup that failed before writing anything, on a missing bucket, a refused credential or missing recipients, still bound the local index to the configured destination, so correcting a mistyped storage_url was refused afterwards. A backup now records the binding only after it has written the marker file at the destination. prune, snapshot purge, snapshot remove and remote nuke only refuse a different binding and leave an unbound index unbound.

Model: opus-5-5
This commit was merged in pull request #445.
This commit is contained in:
clawbot committed 2026-11-11 04:49:11 +01:00
1 parent 1df1d23094
commit c07db21b45
5 files changed
+178 -44

No files matched your search

+5 -10
View File
@@ -115,14 +115,9 @@ func (v *Vaultik) CreateSnapshot(opts *SnapshotCreateOptions) error {
"index_path", v.Config.IndexPath,
)
err := v.EnsureStorageBinding()
if err != nil {
return err
}
// Before PruneDatabase: it drops incomplete snapshots, which could
// leave the local index without one and so skip the marker check.
err = v.markDestination()
err := v.markDestination()
if err != nil {
return err
}
@@ -749,7 +744,7 @@ type SnapshotPurgeOptions struct {
// snapshot name, not the latest globally. This prevents `home` and `system`
// snapshots from cannibalizing each other.
func (v *Vaultik) PurgeSnapshotsWithOptions(opts *SnapshotPurgeOptions) error {
err := v.EnsureStorageBinding()
err := v.checkStorageBinding()
if err != nil {
return err
}
@@ -1277,7 +1272,7 @@ func (v *Vaultik) outputVerifyJSON(result *VerifyResult) error {
// jq` fail (issue #108). The narration is duplicated as log records,
// which go to stderr and so cannot corrupt the document.
func (v *Vaultik) CleanupLocalSnapshots(opts *PruneOptions) error {
err := v.EnsureStorageBinding()
err := v.checkStorageBinding()
if err != nil {
return err
}
@@ -1467,7 +1462,7 @@ func (v *Vaultik) RemoveSnapshot(
SnapshotID: snapshotID,
}
err := v.EnsureStorageBinding()
err := v.checkStorageBinding()
if err != nil {
return result, err
}
@@ -1707,7 +1702,7 @@ func (v *Vaultik) removeSnapshotRemote(
// before it removes anything when the destination store cannot be
// listed or is not present by checkDestinationMarker.
func (v *Vaultik) RemoveAllSnapshots(opts *RemoveOptions) (*RemoveResult, error) {
err := v.EnsureStorageBinding()
err := v.checkStorageBinding()
if err != nil {
return nil, err
}