Apply linter autofixes: internal/database (refs #61)

internal/database/database.go

@@ -57,8 +57,8 @@ func ParseMigrationVersion(filename string) (int, error) {
 	// Split on underscore to separate version from description.
 	// If there's no underscore, the entire stem is the version.
 	versionStr := name
-	if idx := strings.IndexByte(name, '_'); idx >= 0 {
-		versionStr = name[:idx]
+	if before, _, ok := strings.Cut(name, "_"); ok {
+		versionStr = before
 	}
 
 	if versionStr == "" {
@@ -98,6 +98,7 @@ func New(ctx context.Context, path string) (*DB, error) {
 
 	// First attempt with standard WAL mode
 	log.Debug("Attempting to open database with WAL mode", "path", path)
+
 	conn, err := sql.Open(
 		"sqlite",
 		path+"?_journal_mode=WAL&_synchronous=NORMAL&_busy_timeout=10000&_locking_mode=NORMAL&_foreign_keys=ON",
@@ -110,7 +111,8 @@ func New(ctx context.Context, path string) (*DB, error) {
 		conn.SetMaxOpenConns(1)
 		conn.SetMaxIdleConns(1)
 
-		if err := conn.PingContext(ctx); err == nil {
+		err := conn.PingContext(ctx)
+		if err == nil {
 			// Success on first try
 			log.Debug("Database opened successfully with WAL mode", "path", path)
 
@@ -120,13 +122,19 @@ func New(ctx context.Context, path string) (*DB, error) {
 			}
 
 			db := &DB{conn: conn, path: path}
-			if err := applyMigrations(ctx, conn); err != nil {
+
+			err := applyMigrations(ctx, conn)
+			if err != nil {
 				_ = conn.Close()
+
 				return nil, fmt.Errorf("applying migrations: %w", err)
 			}
+
 			return db, nil
 		}
+
 		log.Debug("Failed to ping database, closing connection", "path", path, "error", err)
+
 		_ = conn.Close()
 	}
 
@@ -135,6 +143,7 @@ func New(ctx context.Context, path string) (*DB, error) {
 		"Database appears locked, attempting recovery with TRUNCATE mode",
 		"path", path,
 	)
+
 	conn, err = sql.Open(
 		"sqlite",
 		path+"?_journal_mode=TRUNCATE&_synchronous=NORMAL&_busy_timeout=10000&_foreign_keys=ON",
@@ -152,7 +161,9 @@ func New(ctx context.Context, path string) (*DB, error) {
 
 	if err := conn.PingContext(ctx); err != nil {
 		log.Debug("Failed to ping database in recovery mode, closing", "path", path, "error", err)
+
 		_ = conn.Close()
+
 		return nil, fmt.Errorf(
 			"database still locked after recovery attempt: %w",
 			err,
@@ -163,6 +174,7 @@ func New(ctx context.Context, path string) (*DB, error) {
 
 	// Switch back to WAL mode
 	log.Debug("Switching database back to WAL mode", "path", path)
+
 	if _, err := conn.ExecContext(ctx, "PRAGMA journal_mode=WAL"); err != nil {
 		log.Warn("Failed to switch back to WAL mode", "path", path, "error", err)
 	}
@@ -175,10 +187,12 @@ func New(ctx context.Context, path string) (*DB, error) {
 	db := &DB{conn: conn, path: path}
 	if err := applyMigrations(ctx, conn); err != nil {
 		_ = conn.Close()
+
 		return nil, fmt.Errorf("applying migrations: %w", err)
 	}
 
 	log.Debug("Database connection established successfully", "path", path)
+
 	return db, nil
 }
 
@@ -187,11 +201,16 @@ func New(ctx context.Context, path string) (*DB, error) {
 // Returns an error if the database connection cannot be closed properly.
 func (db *DB) Close() error {
 	log.Debug("Closing database connection", "path", db.path)
-	if err := db.conn.Close(); err != nil {
+
+	err := db.conn.Close()
+	if err != nil {
 		log.Error("Failed to close database", "path", db.path, "error", err)
+
 		return fmt.Errorf("failed to close database: %w", err)
 	}
+
 	log.Debug("Database connection closed successfully", "path", db.path)
+
 	return nil
 }
 
@@ -227,9 +246,10 @@ func (db *DB) BeginTx(
 func (db *DB) ExecWithLog(
 	ctx context.Context,
 	query string,
-	args ...interface{},
+	args ...any,
 ) (sql.Result, error) {
 	LogSQL("Execute", query, args...)
+
 	return db.conn.ExecContext(ctx, query, args...)
 }
 
@@ -240,9 +260,10 @@ func (db *DB) ExecWithLog(
 func (db *DB) QueryRowWithLog(
 	ctx context.Context,
 	query string,
-	args ...interface{},
+	args ...any,
 ) *sql.Row {
 	LogSQL("QueryRow", query, args...)
+
 	return db.conn.QueryRowContext(ctx, query, args...)
 }
 
@@ -375,6 +396,7 @@ func repeatPlaceholder(n int) string {
 	if n <= 0 {
 		return ""
 	}
+
 	return strings.Repeat(", ?", n)
 }
 
@@ -385,7 +407,7 @@ func repeatPlaceholder(n int) string {
 // The operation parameter describes the type of SQL operation (e.g., "Execute", "Query").
 // The query parameter is the SQL statement being executed.
 // The args parameter contains the query arguments that will be interpolated.
-func LogSQL(operation, query string, args ...interface{}) {
+func LogSQL(operation, query string, args ...any) {
 	if strings.Contains(os.Getenv("GODEBUG"), "vaultik") {
 		log.Debug(
 			"SQL "+operation,