Apply mechanical lint fixes for golangci-lint v2.12.2 rollout

Auto-remediate style-only findings (wsl_v5, nlreturn, noinlineerr,
modernize, intrange, perfsprint, usetesting, unconvert, errorlint,
gocritic, testifylint) and rename printf-style helpers to f-suffixed
names (goprintffuncname): ui.Writer message methods, cli.ReportErrorf,
database.Fatalf, vaultik stdoutf.

internal/ui/ui.go

@@ -94,10 +94,12 @@ func shouldColor(w io.Writer) bool {
 	if os.Getenv("NO_COLOR") != "" {
 		return false
 	}
+
 	f, ok := w.(*os.File)
 	if !ok {
 		return false
 	}
+
 	return term.IsTerminal(int(f.Fd()))
 }
 
@@ -106,67 +108,73 @@ func (w *Writer) paint(color, s string) string {
 	if !w.color {
 		return s
 	}
+
 	return color + s + ansiReset
 }
 
 // ───────────────────────── message methods ─────────────────────────
 
-// Begin prints an operation-start line, left-aligned with a white marker.
-func (w *Writer) Begin(format string, args ...any) {
+// Beginf prints an operation-start line, left-aligned with a white marker.
+func (w *Writer) Beginf(format string, args ...any) {
 	if w.quiet {
 		return
 	}
+
 	w.emit(ansiWhite, Marker, "", format, args)
 }
 
-// Complete prints an operation-completion line in green, left-aligned.
-func (w *Writer) Complete(format string, args ...any) {
+// Completef prints an operation-completion line in green, left-aligned.
+func (w *Writer) Completef(format string, args ...any) {
 	if w.quiet {
 		return
 	}
+
 	w.emit(ansiGreen, Marker, ansiGreen, format, args)
 }
 
-// Info prints a neutral status line, left-aligned with a white marker.
-func (w *Writer) Info(format string, args ...any) {
+// Infof prints a neutral status line, left-aligned with a white marker.
+func (w *Writer) Infof(format string, args ...any) {
 	if w.quiet {
 		return
 	}
+
 	w.emit(ansiWhite, Marker, "", format, args)
 }
 
-// Notice prints an attention-worthy informational line, marker in cyan.
-func (w *Writer) Notice(format string, args ...any) {
+// Noticef prints an attention-worthy informational line, marker in cyan.
+func (w *Writer) Noticef(format string, args ...any) {
 	if w.quiet {
 		return
 	}
+
 	w.emit(ansiCyan, Marker, "", format, args)
 }
 
-// Warning prints "⚠️  Warning: " in orange/yellow followed by the message.
-func (w *Writer) Warning(format string, args ...any) {
+// Warningf prints "⚠️  Warning: " in orange/yellow followed by the message.
+func (w *Writer) Warningf(format string, args ...any) {
 	w.warnings++
 	prefix := "⚠️  " + w.paint(ansiYellow+ansiBold, "Warning: ")
 	_, _ = fmt.Fprintln(w.out, prefix+fmt.Sprintf(format, args...))
 }
 
-// Error prints "🛑 ERROR: " in red followed by the message. Goes to the
+// Errorf prints "🛑 ERROR: " in red followed by the message. Goes to the
 // same writer as everything else; callers that want stderr should
 // construct a separate Writer for it.
-func (w *Writer) Error(format string, args ...any) {
+func (w *Writer) Errorf(format string, args ...any) {
 	w.errors++
 	prefix := "🛑 " + w.paint(ansiRed+ansiBold, "ERROR: ")
 	_, _ = fmt.Fprintln(w.out, prefix+fmt.Sprintf(format, args...))
 }
 
-// Detail prints an indented continuation line under a preceding Complete
+// Detailf prints an indented continuation line under a preceding Completef
 // (or other top-level message). Marker "  》" (white) at column 2.
-// Distinct from Progress (semantically a "heartbeat") in usage but
+// Distinct from Progressf (semantically a "heartbeat") in usage but
 // visually identical.
-func (w *Writer) Detail(format string, args ...any) {
+func (w *Writer) Detailf(format string, args ...any) {
 	if w.quiet {
 		return
 	}
+
 	w.emit(ansiWhite, "  "+Marker, "", format, args)
 }
 
@@ -176,24 +184,27 @@ func (w *Writer) WarningCount() int { return w.warnings }
 // ErrorCount returns the number of Error() calls this writer has emitted.
 func (w *Writer) ErrorCount() int { return w.errors }
 
-// Progress prints an indented heartbeat / per-item update, marker in white.
-func (w *Writer) Progress(format string, args ...any) {
+// Progressf prints an indented heartbeat / per-item update, marker in white.
+func (w *Writer) Progressf(format string, args ...any) {
 	if w.quiet {
 		return
 	}
+
 	w.emit(ansiWhite, "  "+Marker, "", format, args)
 }
 
-// Banner prints a line with no marker, left-aligned. Bold when color
+// Bannerf prints a line with no marker, left-aligned. Bold when color
 // is enabled. Used for the application startup banner only.
-func (w *Writer) Banner(format string, args ...any) {
+func (w *Writer) Bannerf(format string, args ...any) {
 	if w.quiet {
 		return
 	}
+
 	body := fmt.Sprintf(format, args...)
 	if w.color {
 		body = ansiBold + body + ansiReset
 	}
+
 	_, _ = fmt.Fprintln(w.out, body)
 }
 
@@ -204,6 +215,7 @@ func (w *Writer) emit(prefixColor, prefix, bodyColor, format string, args []any)
 	if bodyColor != "" {
 		body = w.paint(bodyColor, body)
 	}
+
 	_, _ = fmt.Fprintln(w.out, w.paint(prefixColor, prefix)+" "+body)
 }
 
@@ -219,6 +231,7 @@ func (w *Writer) Hex(s string) string {
 	if len(s) > 12 {
 		short = s[:12] + "..."
 	}
+
 	return w.paint(ansiCyan, short)
 }
 
@@ -244,8 +257,11 @@ func (w *Writer) Speed(bytesPerSec float64) string {
 	if bytesPerSec <= 0 {
 		return w.paint(ansiMagenta, "N/A")
 	}
+
 	bitsPerSec := bytesPerSec * 8
+
 	var s string
+
 	switch {
 	case bitsPerSec >= 1e9:
 		s = fmt.Sprintf("%.1f Gbit/sec", bitsPerSec/1e9)
@@ -256,6 +272,7 @@ func (w *Writer) Speed(bytesPerSec float64) string {
 	default:
 		s = fmt.Sprintf("%.0f bit/sec", bitsPerSec)
 	}
+
 	return w.paint(ansiMagenta, s)
 }
 
@@ -270,10 +287,12 @@ func (w *Writer) Duration(d time.Duration) string {
 // displayed in the process's local zone.
 func (w *Writer) Time(t time.Time) string {
 	t = t.Local()
+
 	now := time.Now()
 	if t.Year() == now.Year() && t.YearDay() == now.YearDay() {
 		return w.paint(ansiYellow, t.Format("15:04:05"))
 	}
+
 	return w.paint(ansiYellow, t.Format("2006-01-02 15:04:05"))
 }