Apply mechanical lint fixes for golangci-lint v2.12.2 rollout

Auto-remediate style-only findings (wsl_v5, nlreturn, noinlineerr,
modernize, intrange, perfsprint, usetesting, unconvert, errorlint,
gocritic, testifylint) and rename printf-style helpers to f-suffixed
names (goprintffuncname): ui.Writer message methods, cli.ReportErrorf,
database.Fatalf, vaultik stdoutf.

internal/storage/url.go

@@ -1,6 +1,7 @@
 package storage
 
 import (
+	"errors"
 	"fmt"
 	"net/url"
 	"strings"
@@ -24,15 +25,16 @@ type StorageURL struct {
 //   - rclone://remote/path/to/backups
 func ParseStorageURL(rawURL string) (*StorageURL, error) {
 	if rawURL == "" {
-		return nil, fmt.Errorf("storage URL is empty")
+		return nil, errors.New("storage URL is empty")
 	}
 
 	// Handle file:// URLs
-	if strings.HasPrefix(rawURL, "file://") {
-		path := strings.TrimPrefix(rawURL, "file://")
+	if after, ok := strings.CutPrefix(rawURL, "file://"); ok {
+		path := after
 		if path == "" {
-			return nil, fmt.Errorf("file URL path is empty")
+			return nil, errors.New("file URL path is empty")
 		}
+
 		return &StorageURL{
 			Scheme: "file",
 			Prefix: path,
@@ -48,12 +50,13 @@ func ParseStorageURL(rawURL string) (*StorageURL, error) {
 
 		bucket := u.Host
 		if bucket == "" {
-			return nil, fmt.Errorf("s3 URL missing bucket name")
+			return nil, errors.New("s3 URL missing bucket name")
 		}
 
 		prefix := strings.TrimPrefix(u.Path, "/")
 
 		query := u.Query()
+
 		useSSL := true
 		if query.Get("ssl") == "false" {
 			useSSL = false
@@ -78,7 +81,7 @@ func ParseStorageURL(rawURL string) (*StorageURL, error) {
 
 		remote := u.Host
 		if remote == "" {
-			return nil, fmt.Errorf("rclone URL missing remote name")
+			return nil, errors.New("rclone URL missing remote name")
 		}
 
 		path := strings.TrimPrefix(u.Path, "/")
@@ -90,29 +93,32 @@ func ParseStorageURL(rawURL string) (*StorageURL, error) {
 		}, nil
 	}
 
-	return nil, fmt.Errorf("unsupported URL scheme: must start with s3://, file://, or rclone://")
+	return nil, errors.New("unsupported URL scheme: must start with s3://, file://, or rclone://")
 }
 
 // String returns a human-readable representation of the storage URL.
 func (u *StorageURL) String() string {
 	switch u.Scheme {
 	case "file":
-		return fmt.Sprintf("file://%s", u.Prefix)
+		return "file://" + u.Prefix
 	case "s3":
 		endpoint := u.Endpoint
 		if endpoint == "" {
 			endpoint = "s3.amazonaws.com"
 		}
+
 		if u.Prefix != "" {
 			return fmt.Sprintf("s3://%s/%s (endpoint: %s)", u.Bucket, u.Prefix, endpoint)
 		}
+
 		return fmt.Sprintf("s3://%s (endpoint: %s)", u.Bucket, endpoint)
 	case "rclone":
 		if u.Prefix != "" {
 			return fmt.Sprintf("rclone://%s/%s", u.RcloneRemote, u.Prefix)
 		}
-		return fmt.Sprintf("rclone://%s", u.RcloneRemote)
+
+		return "rclone://" + u.RcloneRemote
 	default:
-		return fmt.Sprintf("%s://?", u.Scheme)
+		return u.Scheme + "://?"
 	}
 }