Apply mechanical lint fixes for golangci-lint v2.12.2 rollout

Auto-remediate style-only findings (wsl_v5, nlreturn, noinlineerr,
modernize, intrange, perfsprint, usetesting, unconvert, errorlint,
gocritic, testifylint) and rename printf-style helpers to f-suffixed
names (goprintffuncname): ui.Writer message methods, cli.ReportErrorf,
database.Fatalf, vaultik stdoutf.

internal/log/log.go

@@ -84,6 +84,7 @@ func getCaller(skip int) string {
 	if !ok {
 		return "unknown"
 	}
+
 	return fmt.Sprintf("%s:%d", filepath.Base(file), line)
 }
 
@@ -94,6 +95,7 @@ func Fatal(msg string, args ...any) {
 		args = append(args, "caller", getCaller(2))
 		logger.Error(msg, args...)
 	}
+
 	os.Exit(1)
 }
 
@@ -172,6 +174,7 @@ func With(args ...any) *slog.Logger {
 	if logger != nil {
 		return logger.With(args...)
 	}
+
 	return slog.Default()
 }
 

internal/log/tty_handler.go

@@ -33,6 +33,7 @@ func NewTTYHandler(out io.Writer, opts *slog.HandlerOptions) *TTYHandler {
 	if opts == nil {
 		opts = &slog.HandlerOptions{}
 	}
+
 	return &TTYHandler{
 		out:  out,
 		opts: *opts,
@@ -54,7 +55,9 @@ func (h *TTYHandler) Handle(_ context.Context, r slog.Record) error {
 
 	// Level and color
 	level := r.Level.String()
+
 	var levelColor string
+
 	switch r.Level {
 	case slog.LevelDebug:
 		levelColor = colorGray
@@ -96,10 +99,12 @@ func (h *TTYHandler) Handle(_ context.Context, r slog.Record) error {
 		_, _ = fmt.Fprintf(h.out, " %s%s%s=%s%s%s",
 			colorCyan, a.Key, colorReset,
 			colorBlue, value, colorReset)
+
 		return true
 	})
 
 	_, _ = fmt.Fprintln(h.out)
+
 	return nil
 }
 
@@ -122,6 +127,7 @@ func formatDuration(d time.Duration) string {
 	} else if d < time.Minute {
 		return fmt.Sprintf("%.1fs", d.Seconds())
 	}
+
 	return d.String()
 }
 
@@ -131,10 +137,12 @@ func formatBytes(b int64) string {
 	if b < unit {
 		return fmt.Sprintf("%d B", b)
 	}
+
 	div, exp := int64(unit), 0
 	for n := b / unit; n >= unit; n /= unit {
 		div *= unit
 		exp++
 	}
+
 	return fmt.Sprintf("%.1f %cB", float64(b)/float64(div), "KMGTPE"[exp])
 }