Apply mechanical lint fixes for golangci-lint v2.12.2 rollout

Auto-remediate style-only findings (wsl_v5, nlreturn, noinlineerr,
modernize, intrange, perfsprint, usetesting, unconvert, errorlint,
gocritic, testifylint) and rename printf-style helpers to f-suffixed
names (goprintffuncname): ui.Writer message methods, cli.ReportErrorf,
database.Fatalf, vaultik stdoutf.

internal/database/repository_edge_cases_test.go

@@ -98,6 +98,7 @@ func TestFileRepositoryEdgeCases(t *testing.T) {
 			if (err != nil) != tt.wantErr {
 				t.Errorf("Create() error = %v, wantErr %v", err, tt.wantErr)
 			}
+
 			if err != nil && tt.errMsg != "" && !strings.Contains(err.Error(), tt.errMsg) {
 				t.Errorf("Create() error = %v, want error containing %q", err, tt.errMsg)
 			}
@@ -136,6 +137,7 @@ func TestDuplicateHandling(t *testing.T) {
 		if err != nil {
 			t.Fatalf("failed to create file1: %v", err)
 		}
+
 		originalID := file1.ID
 
 		// Create with same path should update the existing record (UPSERT behavior)
@@ -190,6 +192,7 @@ func TestDuplicateHandling(t *testing.T) {
 			UID:   1000,
 			GID:   1000,
 		}
+
 		err := repos.Files.Create(ctx, nil, file)
 		if err != nil {
 			t.Fatal(err)
@@ -199,6 +202,7 @@ func TestDuplicateHandling(t *testing.T) {
 			ChunkHash: types.ChunkHash("test-chunk-dup"),
 			Size:      1024,
 		}
+
 		err = repos.Chunks.Create(ctx, nil, chunk)
 		if err != nil {
 			t.Fatal(err)
@@ -325,6 +329,7 @@ func TestLargeDatasets(t *testing.T) {
 		Hostname:  "test-host",
 		StartedAt: time.Now(),
 	}
+
 	err := repos.Snapshots.Create(ctx, nil, snapshot)
 	if err != nil {
 		t.Fatal(err)
@@ -332,11 +337,12 @@ func TestLargeDatasets(t *testing.T) {
 
 	// Create many files
 	const fileCount = 1000
+
 	fileIDs := make([]types.FileID, fileCount)
 
 	t.Run("create many files", func(t *testing.T) {
 		start := time.Now()
-		for i := 0; i < fileCount; i++ {
+		for i := range fileCount {
 			file := &File{
 				Path:  types.FilePath(fmt.Sprintf("/large/file%05d.txt", i)),
 				MTime: time.Now(),
@@ -345,10 +351,12 @@ func TestLargeDatasets(t *testing.T) {
 				UID:   uint32(1000 + (i % 10)),
 				GID:   uint32(1000 + (i % 10)),
 			}
+
 			err := repos.Files.Create(ctx, nil, file)
 			if err != nil {
 				t.Fatalf("failed to create file %d: %v", i, err)
 			}
+
 			fileIDs[i] = file.ID
 
 			// Add half to snapshot
@@ -359,29 +367,35 @@ func TestLargeDatasets(t *testing.T) {
 				}
 			}
 		}
+
 		t.Logf("Created %d files in %v", fileCount, time.Since(start))
 	})
 
 	// Test ListByPrefix performance
 	t.Run("list by prefix performance", func(t *testing.T) {
 		start := time.Now()
+
 		files, err := repos.Files.ListByPrefix(ctx, "/large/")
 		if err != nil {
 			t.Fatal(err)
 		}
+
 		if len(files) != fileCount {
 			t.Errorf("expected %d files, got %d", fileCount, len(files))
 		}
+
 		t.Logf("Listed %d files in %v", len(files), time.Since(start))
 	})
 
 	// Test orphaned cleanup performance
 	t.Run("orphaned cleanup performance", func(t *testing.T) {
 		start := time.Now()
+
 		err := repos.Files.DeleteOrphaned(ctx)
 		if err != nil {
 			t.Fatal(err)
 		}
+
 		t.Logf("Cleaned up orphaned files in %v", time.Since(start))
 
 		// Verify correct number remain
@@ -389,6 +403,7 @@ func TestLargeDatasets(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
+
 		if len(files) != fileCount/2 {
 			t.Errorf("expected %d files after cleanup, got %d", fileCount/2, len(files))
 		}
@@ -409,6 +424,7 @@ func TestErrorPropagation(t *testing.T) {
 		if err != nil {
 			t.Errorf("GetByID should not return error for non-existent ID, got: %v", err)
 		}
+
 		if file != nil {
 			t.Error("expected nil file for non-existent ID")
 		}
@@ -420,6 +436,7 @@ func TestErrorPropagation(t *testing.T) {
 		if err != nil {
 			t.Errorf("GetByPath should not return error for non-existent path, got: %v", err)
 		}
+
 		if file != nil {
 			t.Error("expected nil file for non-existent path")
 		}
@@ -432,10 +449,12 @@ func TestErrorPropagation(t *testing.T) {
 			Idx:       0,
 			ChunkHash: types.ChunkHash("some-chunk"),
 		}
+
 		err := repos.FileChunks.Create(ctx, nil, fc)
 		if err == nil {
 			t.Error("expected error for invalid foreign key")
 		}
+
 		if !strings.Contains(err.Error(), "FOREIGN KEY") {
 			t.Errorf("expected foreign key error, got: %v", err)
 		}
@@ -475,6 +494,7 @@ func TestQueryInjection(t *testing.T) {
 
 			// Verify tables still exist
 			var count int
+
 			err := db.conn.QueryRow("SELECT COUNT(*) FROM files").Scan(&count)
 			if err != nil {
 				t.Fatal("files table was damaged by injection")