Apply mechanical lint fixes for golangci-lint v2.12.2 rollout

Auto-remediate style-only findings (wsl_v5, nlreturn, noinlineerr,
modernize, intrange, perfsprint, usetesting, unconvert, errorlint,
gocritic, testifylint) and rename printf-style helpers to f-suffixed
names (goprintffuncname): ui.Writer message methods, cli.ReportErrorf,
database.Fatalf, vaultik stdoutf.

internal/cli/entry.go

@@ -19,24 +19,26 @@ func CLIEntry() {
 		if len(short) > 12 {
 			short = short[:12]
 		}
+
 		writeStartupBanner(ui.New(os.Stdout), time.Now().UTC(), short)
 	}
 
 	rootCmd := NewRootCommand()
 	rootCmd.SilenceErrors = true
 
-	if err := rootCmd.Execute(); err != nil {
-		ReportError("%s", err.Error())
+	err := rootCmd.Execute()
+	if err != nil {
+		ReportErrorf("%s", err.Error())
 		os.Exit(1)
 	}
 }
 
-// ReportError emits a user-facing error to stderr in the standard
+// ReportErrorf emits a user-facing error to stderr in the standard
 // 🛑 ERROR: format. Use it from goroutine error paths (where returning
 // an error to cobra isn't an option) and anywhere else a CLI command
 // must surface a failure outside the normal RunE return path.
-func ReportError(format string, args ...any) {
-	ui.New(os.Stderr).Error(format, args...)
+func ReportErrorf(format string, args ...any) {
+	ui.New(os.Stderr).Errorf(format, args...)
 }
 
 // bannerSuppressedInArgs reports whether any of args is a flag that
@@ -48,10 +50,12 @@ func bannerSuppressedInArgs(args []string) bool {
 		if a == "--" {
 			return false
 		}
+
 		switch a {
 		case "--quiet", "-q", "--cron":
 			return true
 		}
+
 		if strings.HasPrefix(a, "--quiet=") || strings.HasPrefix(a, "--cron=") {
 			return true
 		}
@@ -64,5 +68,6 @@ func bannerSuppressedInArgs(args []string) bool {
 			}
 		}
 	}
+
 	return false
 }