List remote snapshots without requiring the private key (closes #64)
All checks were successful
check / check (push) Successful in 6s
All checks were successful
check / check (push) Successful in 6s
ListSnapshots built its table entirely from the local SQLite index. The only remote access, reportRemoteDrift, was gated on AgeSecretKey != "", so on a correctly configured host - which by design holds no private key - snapshot list never contacted the destination store at all. A user who lost their local index could not see their own backups, and the "<remote only>" cell the README documents was unreachable dead code. The listing is now the union of the local index and the destination store, with no age_secret_key gate. Remote-only snapshots cannot have their hostname or name recovered - RemoteSnapshotKey is one-way and the manifest stores the hash - so they are listed by abbreviated remote key with the real timestamp and compressed size from the manifest, and "<remote only>" in the two columns that require the local index. Nothing new is written to remote storage and the human ID is never fabricated. An unreachable destination degrades to local-only with a warning and a zero exit code. remote_present is null rather than false in that case, so "absent" and "unknown" stay distinguishable and no drift is claimed from a listing that never happened. Also: - Snapshot timestamps are normalised to UTC in scanSnapshotRows, the single point where they enter the domain. Previously one of three scanners omitted .UTC(), so on a non-UTC host the same snapshot rendered a different time depending on whether it was locally tracked. - The 1000-row cap and the unreadable-manifest count are reported in --json mode as well as table mode, so machine consumers cannot be silently truncated. The JSON shape is unchanged. - Warnings raised while listing are routed to stderr rather than the logger, which writes to stdout and would corrupt the JSON document. This is a local workaround for the logger bug tracked in #82 and should be removed when that lands. - downloadManifestByKey is now the only remote manifest reader, so the manifest privacy question in #81 has a single call site to change. - The orphaned "vaultik snapshot cleanup" hint now names vaultik prune; that command was folded into prune by the 2026-07-02 consolidation.
This commit was merged in pull request #83.
This commit is contained in:
@@ -191,6 +191,119 @@ func TestSnapshotRepositoryListRecent(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestSnapshotTimestampsDecodeAsUTC pins the zone every snapshot reader
|
||||
// returns. started_at and completed_at are stored as bare Unix seconds,
|
||||
// so the zone is a decode choice, and callers (notably `snapshot list`)
|
||||
// render these timestamps through zone-less format strings in the same
|
||||
// column as timestamps read from remote manifests, which are always
|
||||
// UTC. If one reader decodes in the host's local zone, that column
|
||||
// silently shows two different wall clocks for the same instant.
|
||||
//
|
||||
// The assertions compare *time.Location pointers, so this fails on a
|
||||
// UTC host too: time.Unix returns time.Local, which is never the same
|
||||
// Location value as time.UTC no matter what the host's offset is.
|
||||
func TestSnapshotTimestampsDecodeAsUTC(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
db, cleanup := setupTestDB(t)
|
||||
defer cleanup()
|
||||
|
||||
ctx := context.Background()
|
||||
repo := database.NewSnapshotRepository(db)
|
||||
|
||||
startedAt := time.Date(2026, 3, 1, 10, 0, 0, 0, time.UTC)
|
||||
completedAt := startedAt.Add(time.Minute)
|
||||
|
||||
completed := &database.Snapshot{
|
||||
ID: types.SnapshotID("testhost_home_2026-03-01T10:00:00Z"),
|
||||
Hostname: testHostname,
|
||||
VaultikVersion: testVersion,
|
||||
StartedAt: startedAt,
|
||||
CompletedAt: &completedAt,
|
||||
}
|
||||
|
||||
err := repo.Create(ctx, nil, completed)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to create completed snapshot: %v", err)
|
||||
}
|
||||
|
||||
// An incomplete row as well, so the scanner shared by the two
|
||||
// GetIncomplete* readers is covered with a nil completed_at too.
|
||||
incomplete := &database.Snapshot{
|
||||
ID: types.SnapshotID("testhost_home_2026-03-02T10:00:00Z"),
|
||||
Hostname: testHostname,
|
||||
VaultikVersion: testVersion,
|
||||
StartedAt: startedAt.Add(time.Hour),
|
||||
CompletedAt: nil,
|
||||
}
|
||||
|
||||
err = repo.Create(ctx, nil, incomplete)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to create incomplete snapshot: %v", err)
|
||||
}
|
||||
|
||||
byID, err := repo.GetByID(ctx, completed.ID.String())
|
||||
if err != nil {
|
||||
t.Fatalf("failed to get snapshot by id: %v", err)
|
||||
}
|
||||
|
||||
recent, err := repo.ListRecent(ctx, 10)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to list recent snapshots: %v", err)
|
||||
}
|
||||
|
||||
incompletes, err := repo.GetIncompleteSnapshots(ctx)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to list incomplete snapshots: %v", err)
|
||||
}
|
||||
|
||||
byHost, err := repo.GetIncompleteByHostname(ctx, testHostname)
|
||||
if err != nil {
|
||||
t.Fatalf("failed to list incomplete snapshots by hostname: %v", err)
|
||||
}
|
||||
|
||||
read := make([]*database.Snapshot, 0,
|
||||
1+len(recent)+len(incompletes)+len(byHost))
|
||||
read = append(read, byID)
|
||||
read = append(read, recent...)
|
||||
read = append(read, incompletes...)
|
||||
read = append(read, byHost...)
|
||||
|
||||
if len(read) < 5 {
|
||||
t.Fatalf("expected every reader to return rows, got %d", len(read))
|
||||
}
|
||||
|
||||
assertTimestampsAreUTC(t, read)
|
||||
|
||||
// And the wall clock is the UTC one, not the host's rendering of it.
|
||||
rendered := byID.StartedAt.Format("2006-01-02 15:04:05")
|
||||
if rendered != "2026-03-01 10:00:00" {
|
||||
t.Errorf("started_at rendered as %q, want the UTC wall clock", rendered)
|
||||
}
|
||||
}
|
||||
|
||||
// assertTimestampsAreUTC fails for any snapshot whose timestamps did not
|
||||
// decode in UTC. It compares *time.Location pointers rather than
|
||||
// offsets, so it is equally strict on a host whose local zone happens to
|
||||
// be UTC: time.Unix returns time.Local, which is never the same Location
|
||||
// value as time.UTC.
|
||||
func assertTimestampsAreUTC(t *testing.T, snapshots []*database.Snapshot) {
|
||||
t.Helper()
|
||||
|
||||
for _, snapshot := range snapshots {
|
||||
if snapshot.StartedAt.Location() != time.UTC {
|
||||
t.Errorf("snapshot %s: started_at decoded in %s, want UTC",
|
||||
snapshot.ID, snapshot.StartedAt.Location())
|
||||
}
|
||||
|
||||
if snapshot.CompletedAt != nil &&
|
||||
snapshot.CompletedAt.Location() != time.UTC {
|
||||
t.Errorf("snapshot %s: completed_at decoded in %s, want UTC",
|
||||
snapshot.ID, snapshot.CompletedAt.Location())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestSnapshotRepositoryNotFound(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
|
||||
Reference in New Issue
Block a user