Check storage_url with the storage parser at config load (closes #468)
check / check (push) Waiting to run
check / check (push) Waiting to run
config set accepted rclone:// values that every command then refused: no remote name, parameters in the remote name, a query parameter. The config only checked the URL's prefix, because config could not import the parser from storage, which imports config. The parser moves from internal/storage to a new package, internal/storageurl, that both import. ParseStorageURL becomes storageurl.Parse. Loading the config now runs it on every storage_url, so config set refuses such a value and leaves the file unchanged. Model: opus-5-5
This commit is contained in:
1 parent
d747ddef3a
commit
4e084a2746
8 files changed
+133
-129
No files matched your search
@@ -282,6 +282,13 @@ func TestConfigSetKeepsFileThatWouldNotLoad(t *testing.T) {
|
||||
storageURLKey, testS3URL,
|
||||
"s3.secret_access_key is required for s3:// URLs; " +
|
||||
"set s3.access_key_id and s3.secret_access_key first"},
|
||||
// rclone:// URLs that no command could open.
|
||||
{configWithoutRecipients, storageURLKey, "rclone:///backups",
|
||||
"rclone URL missing remote name"},
|
||||
{configWithoutRecipients, storageURLKey, "rclone://dav,user=x/backups",
|
||||
"rclone URL must not carry parameters in the remote name"},
|
||||
{configWithoutRecipients, storageURLKey, "rclone://dav/backups?x=1",
|
||||
`unknown query parameter in storage URL: "x"`},
|
||||
// With its reference filled in, the config loads.
|
||||
{levelReference, "blob_size_limit", "1MB",
|
||||
"blob_size_limit must be at least"},
|
||||
|
||||
Reference in new issue
Block a user