diff --git a/internal/vaultik/blob_fetch_stub.go b/internal/vaultik/blob_fetch_stub.go index f1f85b4..e8ef0a7 100644 --- a/internal/vaultik/blob_fetch_stub.go +++ b/internal/vaultik/blob_fetch_stub.go @@ -1,15 +1,12 @@ package vaultik -// TODO: These are stub implementations for methods referenced but not yet -// implemented. They allow the package to compile for testing. -// Remove once the real implementations land. - import ( "context" "fmt" "io" "filippo.io/age" + "git.eeqj.de/sneak/vaultik/internal/blobgen" ) // FetchAndDecryptBlobResult holds the result of fetching and decrypting a blob. @@ -19,10 +16,40 @@ type FetchAndDecryptBlobResult struct { // FetchAndDecryptBlob downloads a blob, decrypts it, and returns the plaintext data. func (v *Vaultik) FetchAndDecryptBlob(ctx context.Context, blobHash string, expectedSize int64, identity age.Identity) (*FetchAndDecryptBlobResult, error) { - return nil, fmt.Errorf("FetchAndDecryptBlob not yet implemented") + rc, _, err := v.FetchBlob(ctx, blobHash, expectedSize) + if err != nil { + return nil, err + } + defer func() { _ = rc.Close() }() + + reader, err := blobgen.NewReader(rc, identity) + if err != nil { + return nil, fmt.Errorf("creating blob reader: %w", err) + } + defer func() { _ = reader.Close() }() + + data, err := io.ReadAll(reader) + if err != nil { + return nil, fmt.Errorf("reading blob data: %w", err) + } + + return &FetchAndDecryptBlobResult{Data: data}, nil } // FetchBlob downloads a blob and returns a reader for the encrypted data. func (v *Vaultik) FetchBlob(ctx context.Context, blobHash string, expectedSize int64) (io.ReadCloser, int64, error) { - return nil, 0, fmt.Errorf("FetchBlob not yet implemented") + blobPath := fmt.Sprintf("blobs/%s/%s/%s", blobHash[:2], blobHash[2:4], blobHash) + + rc, err := v.Storage.Get(ctx, blobPath) + if err != nil { + return nil, 0, fmt.Errorf("downloading blob %s: %w", blobHash[:16], err) + } + + info, err := v.Storage.Stat(ctx, blobPath) + if err != nil { + _ = rc.Close() + return nil, 0, fmt.Errorf("stat blob %s: %w", blobHash[:16], err) + } + + return rc, info.Size, nil } diff --git a/internal/vaultik/blobcache.go b/internal/vaultik/blobcache.go index ac6bb88..50b5565 100644 --- a/internal/vaultik/blobcache.go +++ b/internal/vaultik/blobcache.go @@ -167,7 +167,7 @@ func (c *blobDiskCache) ReadAt(key string, offset, length int64) ([]byte, error) if err != nil { return nil, err } - defer f.Close() + defer func() { _ = f.Close() }() buf := make([]byte, length) if _, err := f.ReadAt(buf, offset); err != nil { diff --git a/internal/vaultik/blobcache_test.go b/internal/vaultik/blobcache_test.go index 2088706..778aadd 100644 --- a/internal/vaultik/blobcache_test.go +++ b/internal/vaultik/blobcache_test.go @@ -12,7 +12,7 @@ func TestBlobDiskCache_BasicGetPut(t *testing.T) { if err != nil { t.Fatal(err) } - defer cache.Close() + defer func() { _ = cache.Close() }() data := []byte("hello world") if err := cache.Put("key1", data); err != nil { @@ -39,7 +39,7 @@ func TestBlobDiskCache_EvictionUnderPressure(t *testing.T) { if err != nil { t.Fatal(err) } - defer cache.Close() + defer func() { _ = cache.Close() }() for i := 0; i < 5; i++ { data := make([]byte, 300) @@ -65,7 +65,7 @@ func TestBlobDiskCache_OversizedEntryRejected(t *testing.T) { if err != nil { t.Fatal(err) } - defer cache.Close() + defer func() { _ = cache.Close() }() data := make([]byte, 200) if err := cache.Put("big", data); err != nil { @@ -82,7 +82,7 @@ func TestBlobDiskCache_UpdateInPlace(t *testing.T) { if err != nil { t.Fatal(err) } - defer cache.Close() + defer func() { _ = cache.Close() }() if err := cache.Put("key1", []byte("v1")); err != nil { t.Fatal(err) @@ -111,7 +111,7 @@ func TestBlobDiskCache_ReadAt(t *testing.T) { if err != nil { t.Fatal(err) } - defer cache.Close() + defer func() { _ = cache.Close() }() data := make([]byte, 1024) if _, err := rand.Read(data); err != nil { @@ -159,7 +159,7 @@ func TestBlobDiskCache_LRUOrder(t *testing.T) { if err != nil { t.Fatal(err) } - defer cache.Close() + defer func() { _ = cache.Close() }() d := make([]byte, 100) if err := cache.Put("a", d); err != nil { diff --git a/internal/vaultik/restore.go b/internal/vaultik/restore.go index 37a69b1..d5ac3a7 100644 --- a/internal/vaultik/restore.go +++ b/internal/vaultik/restore.go @@ -113,7 +113,7 @@ func (v *Vaultik) Restore(opts *RestoreOptions) error { if err != nil { return fmt.Errorf("creating blob cache: %w", err) } - defer blobCache.Close() + defer func() { _ = blobCache.Close() }() for i, file := range files { if v.ctx.Err() != nil { @@ -427,7 +427,9 @@ func (v *Vaultik) restoreRegularFile( if err != nil { return fmt.Errorf("downloading blob %s: %w", blobHashStr[:16], err) } - if putErr := blobCache.Put(blobHashStr, blobData); putErr != nil { log.Debug("Failed to cache blob on disk", "hash", blobHashStr[:16], "error", putErr) } + if putErr := blobCache.Put(blobHashStr, blobData); putErr != nil { + log.Debug("Failed to cache blob on disk", "hash", blobHashStr[:16], "error", putErr) + } result.BlobsDownloaded++ result.BytesDownloaded += blob.CompressedSize } @@ -477,53 +479,6 @@ func (v *Vaultik) restoreRegularFile( return nil } -// BlobFetchResult holds the result of fetching and decrypting a blob. -type BlobFetchResult struct { - Data []byte - CompressedSize int64 -} - -// FetchAndDecryptBlob downloads a blob from storage, decrypts and decompresses it. -func (v *Vaultik) FetchAndDecryptBlob(ctx context.Context, blobHash string, expectedSize int64, identity age.Identity) (*BlobFetchResult, error) { - // Construct blob path with sharding - blobPath := fmt.Sprintf("blobs/%s/%s/%s", blobHash[:2], blobHash[2:4], blobHash) - - reader, err := v.Storage.Get(ctx, blobPath) - if err != nil { - return nil, fmt.Errorf("downloading blob: %w", err) - } - defer func() { _ = reader.Close() }() - - // Read encrypted data - encryptedData, err := io.ReadAll(reader) - if err != nil { - return nil, fmt.Errorf("reading blob data: %w", err) - } - - // Decrypt and decompress - blobReader, err := blobgen.NewReader(bytes.NewReader(encryptedData), identity) - if err != nil { - return nil, fmt.Errorf("creating decryption reader: %w", err) - } - defer func() { _ = blobReader.Close() }() - - data, err := io.ReadAll(blobReader) - if err != nil { - return nil, fmt.Errorf("decrypting blob: %w", err) - } - - log.Debug("Downloaded and decrypted blob", - "hash", blobHash[:16], - "encrypted_size", humanize.Bytes(uint64(len(encryptedData))), - "decrypted_size", humanize.Bytes(uint64(len(data))), - ) - - return &BlobFetchResult{ - Data: data, - CompressedSize: int64(len(encryptedData)), - }, nil -} - // downloadBlob downloads and decrypts a blob func (v *Vaultik) downloadBlob(ctx context.Context, blobHash string, expectedSize int64, identity age.Identity) ([]byte, error) { result, err := v.FetchAndDecryptBlob(ctx, blobHash, expectedSize, identity) diff --git a/internal/vaultik/snapshot.go b/internal/vaultik/snapshot.go index a6e498b..38269df 100644 --- a/internal/vaultik/snapshot.go +++ b/internal/vaultik/snapshot.go @@ -851,7 +851,7 @@ func (v *Vaultik) RemoveSnapshot(snapshotID string, opts *RemoveOptions) (*Remov v.printfStdout("Remove snapshot '%s' from local database? [y/N] ", snapshotID) } var confirm string - if err := v.scanlnStdin(&confirm); err != nil { + if _, err := v.scanStdin(&confirm); err != nil { v.printlnStdout("Cancelled") return result, nil } diff --git a/internal/vaultik/vaultik.go b/internal/vaultik/vaultik.go index f403c33..e875cdf 100644 --- a/internal/vaultik/vaultik.go +++ b/internal/vaultik/vaultik.go @@ -134,7 +134,6 @@ func (v *Vaultik) printfStdout(format string, args ...any) { _, _ = fmt.Fprintf(v.Stdout, format, args...) } - // printlnStdout writes a line to stdout. func (v *Vaultik) printlnStdout(args ...any) { _, _ = fmt.Fprintln(v.Stdout, args...)