From 26909b058ac37fc0c28c1e18d88acd35acc72cfd Mon Sep 17 00:00:00 2001 From: sneak Date: Fri, 7 Aug 2026 16:59:56 +0000 Subject: [PATCH] Fix noinlineerr findings: internal/chunker (refs #61) --- internal/chunker/chunker.go | 5 +++-- internal/chunker/chunker_test.go | 8 ++++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/internal/chunker/chunker.go b/internal/chunker/chunker.go index 1615899..c20065e 100644 --- a/internal/chunker/chunker.go +++ b/internal/chunker/chunker.go @@ -121,12 +121,13 @@ func (c *Chunker) ChunkReaderStreaming(r io.Reader, callback ChunkCallback) (str // Pass the data directly - caller must process it before we call Next() again // (chunker reuses its internal buffer, but since we process synchronously // and completely before continuing, no copy is needed) - if err := callback(Chunk{ + err = callback(Chunk{ Hash: hex.EncodeToString(hash[:]), Data: chunk.Data, Offset: offset, Size: int64(len(chunk.Data)), - }); err != nil { + }) + if err != nil { return "", fmt.Errorf("callback error: %w", err) } diff --git a/internal/chunker/chunker_test.go b/internal/chunker/chunker_test.go index fca59f2..20ba3a3 100644 --- a/internal/chunker/chunker_test.go +++ b/internal/chunker/chunker_test.go @@ -30,7 +30,9 @@ func TestChunker(t *testing.T) { // Generate 2MB of random data data := make([]byte, 2*1024*1024) - if _, err := rand.Read(data); err != nil { + + _, err := rand.Read(data) + if err != nil { t.Fatalf("failed to generate random data: %v", err) } @@ -109,7 +111,9 @@ func TestChunkBoundaries(t *testing.T) { // Test that minimum chunk size is respected data := make([]byte, minSize+1024) - if _, err := rand.Read(data); err != nil { + + _, err := rand.Read(data) + if err != nil { t.Fatalf("failed to generate random data: %v", err) }