From ee34f3b70c79eaa02699c1c555d731f8761af02d Mon Sep 17 00:00:00 2001 From: sneak Date: Thu, 1 Jan 2026 06:50:54 -0800 Subject: [PATCH] Change Docker image naming to upaas-appname:deploymentID - Use upaas-appname format instead of upaas/appname - Tag with deployment number instead of 'latest' - Example: upaas-myapp:42 --- internal/service/deploy/deploy.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/service/deploy/deploy.go b/internal/service/deploy/deploy.go index f088c54..0f355a8 100644 --- a/internal/service/deploy/deploy.go +++ b/internal/service/deploy/deploy.go @@ -529,7 +529,7 @@ func (svc *Service) buildImage( defer cleanup() - imageTag := "upaas/" + app.Name + ":latest" + imageTag := fmt.Sprintf("upaas-%s:%d", app.Name, deployment.ID) // Create log writer that flushes build output to deployment logs every second logWriter := newDeploymentLogWriter(ctx, deployment) @@ -721,9 +721,9 @@ func (svc *Service) createAndStartContainer( ctx context.Context, app *models.App, deployment *models.Deployment, - imageID string, + _ string, ) (string, error) { - containerOpts, err := svc.buildContainerOptions(ctx, app, imageID) + containerOpts, err := svc.buildContainerOptions(ctx, app, deployment.ID) if err != nil { svc.failDeployment(ctx, app, deployment, err) @@ -767,7 +767,7 @@ func (svc *Service) createAndStartContainer( func (svc *Service) buildContainerOptions( ctx context.Context, app *models.App, - _ string, + deploymentID int64, ) (docker.CreateContainerOptions, error) { envVars, err := app.GetEnvVars(ctx) if err != nil { @@ -801,7 +801,7 @@ func (svc *Service) buildContainerOptions( return docker.CreateContainerOptions{ Name: "upaas-" + app.Name, - Image: "upaas/" + app.Name + ":latest", + Image: fmt.Sprintf("upaas-%s:%d", app.Name, deploymentID), Env: envMap, Labels: buildLabelMap(app, labels), Volumes: buildVolumeMounts(volumes),