From e858fea05699f24d15055e8005fa81c22ef48073 Mon Sep 17 00:00:00 2001 From: clawbot Date: Sat, 21 Feb 2026 00:55:44 -0800 Subject: [PATCH] fix: remove unused imageID parameter from createAndStartContainer (closes #124) The parameter was accepted but ignored (blank identifier). The image reference is constructed from app name and deployment ID in buildContainerOptions instead. --- internal/service/deploy/deploy.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/internal/service/deploy/deploy.go b/internal/service/deploy/deploy.go index 3093116..0e47f99 100644 --- a/internal/service/deploy/deploy.go +++ b/internal/service/deploy/deploy.go @@ -484,7 +484,7 @@ func (svc *Service) runBuildAndDeploy( svc.notify.NotifyBuildSuccess(bgCtx, app, deployment) // Deploy phase with timeout - err = svc.deployContainerWithTimeout(deployCtx, app, deployment, imageID) + err = svc.deployContainerWithTimeout(deployCtx, app, deployment) if err != nil { cancelErr := svc.checkCancelled(deployCtx, bgCtx, app, deployment, imageID) if cancelErr != nil { @@ -541,7 +541,6 @@ func (svc *Service) deployContainerWithTimeout( ctx context.Context, app *models.App, deployment *models.Deployment, - imageID string, ) error { deployCtx, cancel := context.WithTimeout(ctx, deployTimeout) defer cancel() @@ -555,7 +554,7 @@ func (svc *Service) deployContainerWithTimeout( svc.removeOldContainer(deployCtx, app, deployment) // Create and start the new container - _, err = svc.createAndStartContainer(deployCtx, app, deployment, imageID) + _, err = svc.createAndStartContainer(deployCtx, app, deployment) if err != nil { if errors.Is(deployCtx.Err(), context.DeadlineExceeded) { timeoutErr := fmt.Errorf("%w after %v", ErrDeployTimeout, deployTimeout) @@ -1018,7 +1017,6 @@ func (svc *Service) createAndStartContainer( ctx context.Context, app *models.App, deployment *models.Deployment, - _ string, ) (string, error) { containerOpts, err := svc.buildContainerOptions(ctx, app, deployment.ID) if err != nil {