diff --git a/README.md b/README.md index 91877d7..f0d034d 100644 --- a/README.md +++ b/README.md @@ -9,6 +9,7 @@ A simple self-hosted PaaS that auto-deploys Docker containers from Git repositor - Per-app UUID-based webhook URLs for Gitea integration - Branch filtering - only deploy on configured branch changes - Environment variables, labels, and volume mounts per app +- CPU and memory resource limits per app - Docker builds via socket access - Notifications via ntfy and Slack-compatible webhooks - Simple server-rendered UI with Tailwind CSS diff --git a/internal/database/migrations/007_add_resource_limits.sql b/internal/database/migrations/007_add_resource_limits.sql new file mode 100644 index 0000000..2744f0c --- /dev/null +++ b/internal/database/migrations/007_add_resource_limits.sql @@ -0,0 +1,3 @@ +-- Add CPU and memory resource limits per app +ALTER TABLE apps ADD COLUMN cpu_limit REAL; +ALTER TABLE apps ADD COLUMN memory_limit INTEGER; diff --git a/internal/docker/client.go b/internal/docker/client.go index 8d62266..ef78527 100644 --- a/internal/docker/client.go +++ b/internal/docker/client.go @@ -138,13 +138,15 @@ func (c *Client) BuildImage( // CreateContainerOptions contains options for creating a container. type CreateContainerOptions struct { - Name string - Image string - Env map[string]string - Labels map[string]string - Volumes []VolumeMount - Ports []PortMapping - Network string + Name string + Image string + Env map[string]string + Labels map[string]string + Volumes []VolumeMount + Ports []PortMapping + Network string + CPULimit float64 // CPU cores (e.g. 0.5 = half a core, 2.0 = two cores). 0 means unlimited. + MemoryLimit int64 // Memory in bytes. 0 means unlimited. } // VolumeMount represents a volume mount. @@ -161,6 +163,14 @@ type PortMapping struct { Protocol string // "tcp" or "udp" } +// nanoCPUsPerCPU is the number of NanoCPUs per CPU core. +const nanoCPUsPerCPU = 1e9 + +// cpuLimitToNanoCPUs converts a CPU limit (e.g. 0.5 cores) to Docker NanoCPUs. +func cpuLimitToNanoCPUs(cpuLimit float64) int64 { + return int64(cpuLimit * nanoCPUsPerCPU) +} + // buildPortConfig converts port mappings to Docker port configuration. func buildPortConfig(ports []PortMapping) (nat.PortSet, nat.PortMap) { exposedPorts := make(nat.PortSet) @@ -185,6 +195,48 @@ func buildPortConfig(ports []PortMapping) (nat.PortSet, nat.PortMap) { return exposedPorts, portBindings } +// buildEnvSlice converts an env map to a Docker-compatible env slice. +func buildEnvSlice(env map[string]string) []string { + envSlice := make([]string, 0, len(env)) + + for key, val := range env { + envSlice = append(envSlice, key+"="+val) + } + + return envSlice +} + +// buildMounts converts volume mounts to Docker mount configuration. +func buildMounts(volumes []VolumeMount) []mount.Mount { + mounts := make([]mount.Mount, 0, len(volumes)) + + for _, vol := range volumes { + mounts = append(mounts, mount.Mount{ + Type: mount.TypeBind, + Source: vol.HostPath, + Target: vol.ContainerPath, + ReadOnly: vol.ReadOnly, + }) + } + + return mounts +} + +// buildResources builds Docker resource constraints from container options. +func buildResources(opts CreateContainerOptions) container.Resources { + resources := container.Resources{} + + if opts.CPULimit > 0 { + resources.NanoCPUs = cpuLimitToNanoCPUs(opts.CPULimit) + } + + if opts.MemoryLimit > 0 { + resources.Memory = opts.MemoryLimit + } + + return resources +} + // CreateContainer creates a new container. func (c *Client) CreateContainer( ctx context.Context, @@ -196,40 +248,20 @@ func (c *Client) CreateContainer( c.log.Info("creating container", "name", opts.Name, "image", opts.Image) - // Convert env map to slice - envSlice := make([]string, 0, len(opts.Env)) - - for key, val := range opts.Env { - envSlice = append(envSlice, key+"="+val) - } - - // Convert volumes to mounts - mounts := make([]mount.Mount, 0, len(opts.Volumes)) - - for _, vol := range opts.Volumes { - mounts = append(mounts, mount.Mount{ - Type: mount.TypeBind, - Source: vol.HostPath, - Target: vol.ContainerPath, - ReadOnly: vol.ReadOnly, - }) - } - - // Convert ports to exposed ports and port bindings exposedPorts, portBindings := buildPortConfig(opts.Ports) - // Create container resp, err := c.docker.ContainerCreate(ctx, &container.Config{ Image: opts.Image, - Env: envSlice, + Env: buildEnvSlice(opts.Env), Labels: opts.Labels, ExposedPorts: exposedPorts, }, &container.HostConfig{ - Mounts: mounts, + Mounts: buildMounts(opts.Volumes), PortBindings: portBindings, NetworkMode: container.NetworkMode(opts.Network), + Resources: buildResources(opts), RestartPolicy: container.RestartPolicy{ Name: container.RestartPolicyUnlessStopped, }, diff --git a/internal/docker/resource_limits_test.go b/internal/docker/resource_limits_test.go new file mode 100644 index 0000000..ab2a686 --- /dev/null +++ b/internal/docker/resource_limits_test.go @@ -0,0 +1,31 @@ +package docker //nolint:testpackage // tests unexported cpuLimitToNanoCPUs + +import ( + "testing" +) + +func TestCpuLimitToNanoCPUs(t *testing.T) { + t.Parallel() + + tests := []struct { + name string + cpuLimit float64 + expected int64 + }{ + {"one core", 1.0, 1_000_000_000}, + {"half core", 0.5, 500_000_000}, + {"two cores", 2.0, 2_000_000_000}, + {"quarter core", 0.25, 250_000_000}, + } + + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + t.Parallel() + + got := cpuLimitToNanoCPUs(tt.cpuLimit) + if got != tt.expected { + t.Errorf("cpuLimitToNanoCPUs(%v) = %d, want %d", tt.cpuLimit, got, tt.expected) + } + }) + } +} diff --git a/internal/handlers/app.go b/internal/handlers/app.go index d55c27c..6b4b00d 100644 --- a/internal/handlers/app.go +++ b/internal/handlers/app.go @@ -257,23 +257,19 @@ func (h *Handlers) HandleAppUpdate() http.HandlerFunc { //nolint:funlen // valid application.RepoURL = request.FormValue("repo_url") application.Branch = request.FormValue("branch") application.DockerfilePath = request.FormValue("dockerfile_path") + application.DockerNetwork = optionalNullString(request.FormValue("docker_network")) + application.NtfyTopic = optionalNullString(request.FormValue("ntfy_topic")) + application.SlackWebhook = optionalNullString(request.FormValue("slack_webhook")) - if network := request.FormValue("docker_network"); network != "" { - application.DockerNetwork = sql.NullString{String: network, Valid: true} - } else { - application.DockerNetwork = sql.NullString{} - } + limitsErr := applyResourceLimits(application, request) + if limitsErr != "" { + data := h.addGlobals(map[string]any{ + "App": application, + "Error": limitsErr, + }, request) + h.renderTemplate(writer, tmpl, "app_edit.html", data) - if ntfy := request.FormValue("ntfy_topic"); ntfy != "" { - application.NtfyTopic = sql.NullString{String: ntfy, Valid: true} - } else { - application.NtfyTopic = sql.NullString{} - } - - if slack := request.FormValue("slack_webhook"); slack != "" { - application.SlackWebhook = sql.NullString{String: slack, Valid: true} - } else { - application.SlackWebhook = sql.NullString{} + return } saveErr := application.Save(request.Context()) @@ -1368,6 +1364,129 @@ func validateVolumePaths(hostPath, containerPath string) error { return nil } +// ErrInvalidMemoryFormat is returned when a memory limit string cannot be parsed. +var ErrInvalidMemoryFormat = errors.New( + "must be a number with optional unit suffix (e.g. 256m, 1g, 512000000)", +) + +// ErrNegativeValue is returned when a resource limit is negative. +var ErrNegativeValue = errors.New("value must be positive") + +// Memory unit byte multipliers. +const ( + kilobyte = 1024 + megabyte = 1024 * 1024 + gigabyte = 1024 * 1024 * 1024 +) + +// optionalNullString converts a form value to a sql.NullString. +// Returns a valid NullString if non-empty, invalid (NULL) if empty. +func optionalNullString(s string) sql.NullString { + if s != "" { + return sql.NullString{String: s, Valid: true} + } + + return sql.NullString{} +} + +// applyResourceLimits parses CPU and memory limit form values and applies them to the app. +// Returns an error message string if validation fails, or empty string on success. +func applyResourceLimits(application *models.App, request *http.Request) string { + cpuLimit, cpuErr := parseOptionalFloat64(request.FormValue("cpu_limit")) + if cpuErr != nil { + return "Invalid CPU limit: must be a positive number (e.g. 0.5, 1, 2)" + } + + application.CPULimit = cpuLimit + + memoryLimit, memErr := parseOptionalMemoryBytes(request.FormValue("memory_limit")) + if memErr != nil { + return "Invalid memory limit: " + memErr.Error() + } + + application.MemoryLimit = memoryLimit + + return "" +} + +// memoryUnitMultiplier returns the byte multiplier for a memory unit suffix. +// Returns 0 if the suffix is not recognized. +func memoryUnitMultiplier(suffix byte) int64 { + switch suffix { + case 'k': + return kilobyte + case 'm': + return megabyte + case 'g': + return gigabyte + default: + return 0 + } +} + +// parseOptionalFloat64 parses an optional float64 form field. +// Returns a valid NullFloat64 if the string is non-empty and parses to a positive number. +// Returns an empty NullFloat64 if the string is empty. +// Returns an error if the string is non-empty but invalid or non-positive. +func parseOptionalFloat64(s string) (sql.NullFloat64, error) { + s = strings.TrimSpace(s) + if s == "" { + return sql.NullFloat64{}, nil + } + + val, err := strconv.ParseFloat(s, 64) + if err != nil { + return sql.NullFloat64{}, fmt.Errorf("invalid number: %w", err) + } + + if val <= 0 { + return sql.NullFloat64{}, ErrNegativeValue + } + + return sql.NullFloat64{Float64: val, Valid: true}, nil +} + +// parseOptionalMemoryBytes parses an optional memory limit string into bytes. +// Accepts plain bytes (e.g. "536870912") or suffixed values (e.g. "512m", "1g", "256k"). +// Returns a valid NullInt64 with bytes if non-empty, empty NullInt64 if blank. +func parseOptionalMemoryBytes(s string) (sql.NullInt64, error) { + s = strings.TrimSpace(s) + if s == "" { + return sql.NullInt64{}, nil + } + + s = strings.ToLower(s) + + // Check for unit suffix + multiplier := memoryUnitMultiplier(s[len(s)-1]) + if multiplier > 0 { + numStr := s[:len(s)-1] + + val, err := strconv.ParseFloat(numStr, 64) + if err != nil { + return sql.NullInt64{}, ErrInvalidMemoryFormat + } + + if val <= 0 { + return sql.NullInt64{}, ErrNegativeValue + } + + return sql.NullInt64{Int64: int64(val * float64(multiplier)), Valid: true}, nil + } + + // Plain bytes + val, err := strconv.ParseInt(s, 10, 64) + if err != nil { + return sql.NullInt64{}, ErrInvalidMemoryFormat + } + + if val <= 0 { + return sql.NullInt64{}, ErrNegativeValue + } + + return sql.NullInt64{Int64: val, Valid: true}, nil +} + // formatDeployKey formats an SSH public key with a descriptive comment. // Format: ssh-ed25519 AAAA... upaas_2025-01-15_myapp func formatDeployKey(pubKey string, createdAt time.Time, appName string) string { diff --git a/internal/handlers/resource_limits_test.go b/internal/handlers/resource_limits_test.go new file mode 100644 index 0000000..5e39db0 --- /dev/null +++ b/internal/handlers/resource_limits_test.go @@ -0,0 +1,195 @@ +package handlers //nolint:testpackage // tests unexported parsing functions + +import ( + "database/sql" + "testing" + + "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" +) + +func TestParseOptionalFloat64(t *testing.T) { + t.Parallel() + + t.Run("empty string returns invalid", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalFloat64("") + require.NoError(t, err) + assert.False(t, result.Valid) + }) + + t.Run("whitespace only returns invalid", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalFloat64(" ") + require.NoError(t, err) + assert.False(t, result.Valid) + }) + + t.Run("valid float", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalFloat64("0.5") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.InDelta(t, 0.5, result.Float64, 0.001) + }) + + t.Run("valid integer", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalFloat64("2") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.InDelta(t, 2.0, result.Float64, 0.001) + }) + + t.Run("negative value rejected", func(t *testing.T) { + t.Parallel() + + _, err := parseOptionalFloat64("-1") + require.Error(t, err) + }) + + t.Run("zero value rejected", func(t *testing.T) { + t.Parallel() + + _, err := parseOptionalFloat64("0") + require.Error(t, err) + }) + + t.Run("non-numeric rejected", func(t *testing.T) { + t.Parallel() + + _, err := parseOptionalFloat64("abc") + require.Error(t, err) + }) +} + +func TestParseOptionalMemoryBytes(t *testing.T) { //nolint:funlen // table-driven test + t.Parallel() + + t.Run("empty string returns invalid", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes("") + require.NoError(t, err) + assert.False(t, result.Valid) + }) + + t.Run("whitespace only returns invalid", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes(" ") + require.NoError(t, err) + assert.False(t, result.Valid) + }) + + t.Run("plain bytes", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes("536870912") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.Equal(t, int64(536870912), result.Int64) + }) + + t.Run("megabytes suffix", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes("256m") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.Equal(t, int64(256*1024*1024), result.Int64) + }) + + t.Run("megabytes suffix uppercase", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes("256M") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.Equal(t, int64(256*1024*1024), result.Int64) + }) + + t.Run("gigabytes suffix", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes("1g") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.Equal(t, int64(1024*1024*1024), result.Int64) + }) + + t.Run("kilobytes suffix", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes("512k") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.Equal(t, int64(512*1024), result.Int64) + }) + + t.Run("fractional gigabytes", func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes("1.5g") + require.NoError(t, err) + assert.True(t, result.Valid) + assert.Equal(t, int64(1.5*1024*1024*1024), result.Int64) + }) + + t.Run("negative value rejected", func(t *testing.T) { + t.Parallel() + + _, err := parseOptionalMemoryBytes("-256m") + require.Error(t, err) + }) + + t.Run("zero value rejected", func(t *testing.T) { + t.Parallel() + + _, err := parseOptionalMemoryBytes("0") + require.Error(t, err) + }) + + t.Run("invalid string rejected", func(t *testing.T) { + t.Parallel() + + _, err := parseOptionalMemoryBytes("abc") + require.Error(t, err) + }) + + t.Run("negative plain bytes rejected", func(t *testing.T) { + t.Parallel() + + _, err := parseOptionalMemoryBytes("-100") + require.Error(t, err) + }) +} + +func TestAppResourceLimitsRoundTrip(t *testing.T) { + t.Parallel() + + // Test that parsing and formatting are consistent + tests := []struct { + input string + expected sql.NullInt64 + format string + }{ + {"256m", sql.NullInt64{Int64: 256 * 1024 * 1024, Valid: true}, "256m"}, + {"1g", sql.NullInt64{Int64: 1024 * 1024 * 1024, Valid: true}, "1g"}, + {"512k", sql.NullInt64{Int64: 512 * 1024, Valid: true}, "512k"}, + } + + for _, tt := range tests { + t.Run(tt.input, func(t *testing.T) { + t.Parallel() + + result, err := parseOptionalMemoryBytes(tt.input) + require.NoError(t, err) + assert.Equal(t, tt.expected, result) + }) + } +} diff --git a/internal/models/app.go b/internal/models/app.go index bda1b14..c476a35 100644 --- a/internal/models/app.go +++ b/internal/models/app.go @@ -14,7 +14,8 @@ import ( const appColumns = `id, name, repo_url, branch, dockerfile_path, webhook_secret, ssh_private_key, ssh_public_key, image_id, status, docker_network, ntfy_topic, slack_webhook, webhook_secret_hash, - previous_image_id, created_at, updated_at` + previous_image_id, cpu_limit, memory_limit, + created_at, updated_at` // AppStatus represents the status of an app. type AppStatus string @@ -47,6 +48,8 @@ type App struct { DockerNetwork sql.NullString NtfyTopic sql.NullString SlackWebhook sql.NullString + CPULimit sql.NullFloat64 + MemoryLimit sql.NullInt64 CreatedAt time.Time UpdatedAt time.Time } @@ -142,14 +145,14 @@ func (a *App) insert(ctx context.Context) error { id, name, repo_url, branch, dockerfile_path, webhook_secret, ssh_private_key, ssh_public_key, image_id, status, docker_network, ntfy_topic, slack_webhook, webhook_secret_hash, - previous_image_id - ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)` + previous_image_id, cpu_limit, memory_limit + ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)` _, err := a.db.Exec(ctx, query, a.ID, a.Name, a.RepoURL, a.Branch, a.DockerfilePath, a.WebhookSecret, a.SSHPrivateKey, a.SSHPublicKey, a.ImageID, a.Status, a.DockerNetwork, a.NtfyTopic, a.SlackWebhook, a.WebhookSecretHash, - a.PreviousImageID, + a.PreviousImageID, a.CPULimit, a.MemoryLimit, ) if err != nil { return err @@ -165,6 +168,7 @@ func (a *App) update(ctx context.Context) error { image_id = ?, status = ?, docker_network = ?, ntfy_topic = ?, slack_webhook = ?, previous_image_id = ?, + cpu_limit = ?, memory_limit = ?, updated_at = CURRENT_TIMESTAMP WHERE id = ?` @@ -173,6 +177,7 @@ func (a *App) update(ctx context.Context) error { a.ImageID, a.Status, a.DockerNetwork, a.NtfyTopic, a.SlackWebhook, a.PreviousImageID, + a.CPULimit, a.MemoryLimit, a.ID, ) @@ -188,6 +193,7 @@ func (a *App) scan(row *sql.Row) error { &a.DockerNetwork, &a.NtfyTopic, &a.SlackWebhook, &a.WebhookSecretHash, &a.PreviousImageID, + &a.CPULimit, &a.MemoryLimit, &a.CreatedAt, &a.UpdatedAt, ) } @@ -206,6 +212,7 @@ func scanApps(appDB *database.Database, rows *sql.Rows) ([]*App, error) { &app.DockerNetwork, &app.NtfyTopic, &app.SlackWebhook, &app.WebhookSecretHash, &app.PreviousImageID, + &app.CPULimit, &app.MemoryLimit, &app.CreatedAt, &app.UpdatedAt, ) if scanErr != nil { diff --git a/internal/models/models_test.go b/internal/models/models_test.go index 2d894b5..727a746 100644 --- a/internal/models/models_test.go +++ b/internal/models/models_test.go @@ -781,6 +781,96 @@ func TestCascadeDelete(t *testing.T) { }) } +// Resource Limits Tests. + +func TestAppResourceLimits(t *testing.T) { //nolint:funlen // integration test with multiple subtests + t.Parallel() + + t.Run("saves and loads CPU limit", func(t *testing.T) { + t.Parallel() + + testDB, cleanup := setupTestDB(t) + defer cleanup() + + app := createTestApp(t, testDB) + + app.CPULimit = sql.NullFloat64{Float64: 0.5, Valid: true} + + err := app.Save(context.Background()) + require.NoError(t, err) + + found, err := models.FindApp(context.Background(), testDB, app.ID) + require.NoError(t, err) + require.NotNil(t, found) + assert.True(t, found.CPULimit.Valid) + assert.InDelta(t, 0.5, found.CPULimit.Float64, 0.001) + }) + + t.Run("saves and loads memory limit", func(t *testing.T) { + t.Parallel() + + testDB, cleanup := setupTestDB(t) + defer cleanup() + + app := createTestApp(t, testDB) + + app.MemoryLimit = sql.NullInt64{Int64: 536870912, Valid: true} // 512m + + err := app.Save(context.Background()) + require.NoError(t, err) + + found, err := models.FindApp(context.Background(), testDB, app.ID) + require.NoError(t, err) + require.NotNil(t, found) + assert.True(t, found.MemoryLimit.Valid) + assert.Equal(t, int64(536870912), found.MemoryLimit.Int64) + }) + + t.Run("null limits by default", func(t *testing.T) { + t.Parallel() + + testDB, cleanup := setupTestDB(t) + defer cleanup() + + app := createTestApp(t, testDB) + + found, err := models.FindApp(context.Background(), testDB, app.ID) + require.NoError(t, err) + require.NotNil(t, found) + assert.False(t, found.CPULimit.Valid) + assert.False(t, found.MemoryLimit.Valid) + }) + + t.Run("clears limits when set to null", func(t *testing.T) { + t.Parallel() + + testDB, cleanup := setupTestDB(t) + defer cleanup() + + app := createTestApp(t, testDB) + + // Set limits + app.CPULimit = sql.NullFloat64{Float64: 1.0, Valid: true} + app.MemoryLimit = sql.NullInt64{Int64: 1073741824, Valid: true} // 1g + + err := app.Save(context.Background()) + require.NoError(t, err) + + // Clear limits + app.CPULimit = sql.NullFloat64{} + app.MemoryLimit = sql.NullInt64{} + + err = app.Save(context.Background()) + require.NoError(t, err) + + found, err := models.FindApp(context.Background(), testDB, app.ID) + require.NoError(t, err) + require.NotNil(t, found) + assert.False(t, found.CPULimit.Valid) + assert.False(t, found.MemoryLimit.Valid) + }) +} + // Helper function to create a test app. func createTestApp(t *testing.T, testDB *database.Database) *models.App { t.Helper() diff --git a/internal/service/deploy/deploy.go b/internal/service/deploy/deploy.go index 4b78e29..2bc983c 100644 --- a/internal/service/deploy/deploy.go +++ b/internal/service/deploy/deploy.go @@ -1094,14 +1094,28 @@ func (svc *Service) buildContainerOptions( network = app.DockerNetwork.String } + var cpuLimit float64 + + if app.CPULimit.Valid { + cpuLimit = app.CPULimit.Float64 + } + + var memoryLimit int64 + + if app.MemoryLimit.Valid { + memoryLimit = app.MemoryLimit.Int64 + } + return docker.CreateContainerOptions{ - Name: "upaas-" + app.Name, - Image: imageID.String(), - Env: envMap, - Labels: buildLabelMap(app, labels), - Volumes: buildVolumeMounts(volumes), - Ports: buildPortMappings(ports), - Network: network, + Name: "upaas-" + app.Name, + Image: imageID.String(), + Env: envMap, + Labels: buildLabelMap(app, labels), + Volumes: buildVolumeMounts(volumes), + Ports: buildPortMappings(ports), + Network: network, + CPULimit: cpuLimit, + MemoryLimit: memoryLimit, }, nil } diff --git a/internal/service/deploy/deploy_container_test.go b/internal/service/deploy/deploy_container_test.go index 4b047fd..1bc4c77 100644 --- a/internal/service/deploy/deploy_container_test.go +++ b/internal/service/deploy/deploy_container_test.go @@ -2,6 +2,7 @@ package deploy_test import ( "context" + "database/sql" "log/slog" "os" "testing" @@ -43,3 +44,93 @@ func TestBuildContainerOptionsUsesImageID(t *testing.T) { t.Errorf("expected Name=%q, got %q", "upaas-myapp", opts.Name) } } + +func TestBuildContainerOptionsNoResourceLimits(t *testing.T) { + t.Parallel() + + db := database.NewTestDatabase(t) + + app := models.NewApp(db) + app.Name = "nolimits" + + err := app.Save(context.Background()) + if err != nil { + t.Fatalf("failed to save app: %v", err) + } + + log := slog.New(slog.NewTextHandler(os.Stderr, nil)) + svc := deploy.NewTestService(log) + + opts, err := svc.BuildContainerOptionsExported( + context.Background(), app, docker.ImageID("test:latest"), + ) + if err != nil { + t.Fatalf("buildContainerOptions returned error: %v", err) + } + + if opts.CPULimit != 0 { + t.Errorf("expected CPULimit=0, got %v", opts.CPULimit) + } + + if opts.MemoryLimit != 0 { + t.Errorf("expected MemoryLimit=0, got %v", opts.MemoryLimit) + } +} + +func TestBuildContainerOptionsCPULimit(t *testing.T) { + t.Parallel() + + db := database.NewTestDatabase(t) + + app := models.NewApp(db) + app.Name = "cpulimit" + app.CPULimit = sql.NullFloat64{Float64: 0.5, Valid: true} + + err := app.Save(context.Background()) + if err != nil { + t.Fatalf("failed to save app: %v", err) + } + + log := slog.New(slog.NewTextHandler(os.Stderr, nil)) + svc := deploy.NewTestService(log) + + opts, err := svc.BuildContainerOptionsExported( + context.Background(), app, docker.ImageID("test:latest"), + ) + if err != nil { + t.Fatalf("buildContainerOptions returned error: %v", err) + } + + if opts.CPULimit != 0.5 { + t.Errorf("expected CPULimit=0.5, got %v", opts.CPULimit) + } +} + +func TestBuildContainerOptionsMemoryLimit(t *testing.T) { + t.Parallel() + + db := database.NewTestDatabase(t) + + app := models.NewApp(db) + app.Name = "memlimit" + app.MemoryLimit = sql.NullInt64{Int64: 536870912, Valid: true} // 512m + + err := app.Save(context.Background()) + if err != nil { + t.Fatalf("failed to save app: %v", err) + } + + log := slog.New(slog.NewTextHandler(os.Stderr, nil)) + svc := deploy.NewTestService(log) + + opts, err := svc.BuildContainerOptionsExported( + context.Background(), app, docker.ImageID("test:latest"), + ) + if err != nil { + t.Fatalf("buildContainerOptions returned error: %v", err) + } + + if opts.MemoryLimit != 536870912 { + t.Errorf("expected MemoryLimit=536870912, got %v", opts.MemoryLimit) + } +} diff --git a/templates/app_edit.html b/templates/app_edit.html index cd68c0e..3bb3852 100644 --- a/templates/app_edit.html +++ b/templates/app_edit.html @@ -114,6 +114,38 @@ > +
Number of CPU cores (e.g. 0.5 = half a core)
+Memory with unit suffix (k, m, g) or plain bytes
+