From 79c1c7fe688cd724c5a4777b499b9c193d888ad6 Mon Sep 17 00:00:00 2001
From: sneak <sneak@sneak.berlin>
Date: Thu, 1 Oct 2026 19:08:48 +0000
Subject: [PATCH] Say env var changes take effect at the next deploy or
 rollback (closes #255)

The hint under the app page's environment variable editor asked for a
container restart. Environment variables are set when a container is
created, and upaas's restart stops and starts the same container, so it
keeps the old values; deploy and rollback each create a new container.
The hint now says so in one sentence, styled with badge-warning, the
warning style the page already uses: its old text-amber-600 class is not
in the built stylesheet. A handler test renders the app page and checks
the hint.

Model: opus-5-5
---
 TODO.md                                       |  5 +++
 .../handlers/app_page_env_var_hint_test.go    | 39 +++++++++++++++++++
 templates/app_detail.html                     |  2 +-
 3 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 internal/handlers/app_page_env_var_hint_test.go

diff --git a/TODO.md b/TODO.md
index 6385244..59ee59a 100644
--- a/TODO.md
+++ b/TODO.md
@@ -20,6 +20,11 @@ regress.
 
 # Completed Steps
 
+- 2026-10-01: The hint under the app page's environment variable editor now says
+  changes take effect at the next deploy or rollback, in the page's warning
+  style, instead of asking for a container restart, which keeps the old values
+  (#255).
+
 - 2026-10-01: Builds attach a BuildKit session, as the docker command line does,
   so a base image that is not on the host is pulled instead of the build failing
   with "no active sessions" on Docker Engine 27. Container logs, and so the
diff --git a/internal/handlers/app_page_env_var_hint_test.go b/internal/handlers/app_page_env_var_hint_test.go
new file mode 100644
index 0000000..fa7c342
--- /dev/null
+++ b/internal/handlers/app_page_env_var_hint_test.go
@@ -0,0 +1,39 @@
+package handlers_test
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+
+	"sneak.berlin/go/upaas/internal/service/app"
+)
+
+// TestAppPageEnvVarHint checks that the environment variable editor says
+// changes take effect at the next deploy or rollback, in the warning style.
+func TestAppPageEnvVarHint(t *testing.T) {
+	t.Parallel()
+
+	testCtx := setupTestHandlers(t)
+
+	createdApp, err := testCtx.appSvc.CreateApp(t.Context(), app.CreateAppInput{
+		Name:    "env-hint-app",
+		RepoURL: "git@example.com:user/env-hint-app.git",
+	})
+	require.NoError(t, err)
+
+	request := httptest.NewRequestWithContext(
+		t.Context(), http.MethodGet, "/apps/"+createdApp.ID, nil,
+	)
+	request = addChiURLParams(request, map[string]string{"id": createdApp.ID})
+	recorder := httptest.NewRecorder()
+
+	testCtx.handlers.HandleAppDetail().ServeHTTP(recorder, request)
+
+	require.Equal(t, http.StatusOK, recorder.Code)
+	assert.Contains(t, recorder.Body.String(),
+		`<p class="badge-warning mt-1">`+
+			"Environment variable changes take effect at the next deploy or rollback.</p>")
+}
diff --git a/templates/app_detail.html b/templates/app_detail.html
index eb6f146..a8a3b62 100644
--- a/templates/app_detail.html
+++ b/templates/app_detail.html
@@ -178,7 +178,7 @@
                                     <button type="submit" class="btn-primary text-sm">Save</button>
                                     <button type="button" @click="editIdx = -1" class="text-gray-500 hover:text-gray-700 text-sm">Cancel</button>
                                 </form>
-                                <p class="text-xs text-amber-600 mt-1">⚠ Container restart needed after env var changes.</p>
+                                <p class="badge-warning mt-1">Environment variable changes take effect at the next deploy or rollback.</p>
                             </td>
                         </template>
                     </tr>