From 7253c64c782229437a44d64264b9d4bf7fa3ba20 Mon Sep 17 00:00:00 2001 From: clawbot Date: Sat, 21 Feb 2026 00:54:49 -0800 Subject: [PATCH] fix: use renderTemplate in all error paths of HandleAppCreate/HandleAppUpdate (closes #121) Replace direct tmpl.ExecuteTemplate calls with h.renderTemplate to ensure buffered rendering and prevent partial HTML responses on template errors. --- internal/handlers/app.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/handlers/app.go b/internal/handlers/app.go index 28382de..0a9ee77 100644 --- a/internal/handlers/app.go +++ b/internal/handlers/app.go @@ -72,7 +72,7 @@ func (h *Handlers) HandleAppCreate() http.HandlerFunc { //nolint:funlen // valid nameErr := validateAppName(name) if nameErr != nil { data["Error"] = "Invalid app name: " + nameErr.Error() - _ = tmpl.ExecuteTemplate(writer, "app_new.html", data) + h.renderTemplate(writer, tmpl, "app_new.html", data) return } @@ -228,7 +228,7 @@ func (h *Handlers) HandleAppUpdate() http.HandlerFunc { //nolint:funlen // valid "App": application, "Error": "Invalid app name: " + nameErr.Error(), }, request) - _ = tmpl.ExecuteTemplate(writer, "app_edit.html", data) + h.renderTemplate(writer, tmpl, "app_edit.html", data) return } @@ -239,7 +239,7 @@ func (h *Handlers) HandleAppUpdate() http.HandlerFunc { //nolint:funlen // valid "App": application, "Error": "Invalid repository URL: " + repoURLErr.Error(), }, request) - _ = tmpl.ExecuteTemplate(writer, "app_edit.html", data) + h.renderTemplate(writer, tmpl, "app_edit.html", data) return }