From c125375ac7aab3b007ecbd6204109788ef3a8d89 Mon Sep 17 00:00:00 2001 From: sneak Date: Tue, 17 Nov 2026 05:32:01 +0000 Subject: [PATCH] reputation: run the DNSBL resolver test in parallel (closes #406) TestQueriesGoToTheResolverSWWDNSBLResolverNames queries a real UDP stand-in outside any synctest bubble. A parallel test starts only once every test that is not parallel has ended, so it can no longer overlap the bubbled DNSBL tests, and no other parallel test of the package queries a resolver. The other tests that run one at a time stay so, each for the reason its comment gives: environment variables, TMPDIR, timing, Go's resolver in synctest bubbles, and garbage collection hiding a leaked connection. Every subtest inside a parallel test already calls t.Parallel(). Model: opus-5-5 --- internal/reputation/dnsbl_test.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/internal/reputation/dnsbl_test.go b/internal/reputation/dnsbl_test.go index 0be1a3d..dfe1e74 100644 --- a/internal/reputation/dnsbl_test.go +++ b/internal/reputation/dnsbl_test.go @@ -31,10 +31,12 @@ import ( // this package: Go's resolver counts the queries under way in one // sync.WaitGroup for the whole process, and the process fails when // queries from two bubbles, or from a bubble and from outside one, are -// under way at once. TestMain has the resolver make its configuration, -// which it makes on its first query, outside every bubble, since the -// configuration holds a channel, which the bubble it was made in would -// keep to itself. +// under way at once. The one test outside a bubble is parallel, so it +// starts only once every test that is not parallel has ended; no other +// parallel test of this package queries a resolver. TestMain has the +// resolver make its configuration, which it makes on its first query, +// outside every bubble, since the configuration holds a channel, which +// the bubble it was made in would keep to itself. const ( // zone and otherZone are the DNSBL zones the tests name. @@ -525,8 +527,9 @@ func TestAtMost100000VerdictsKeptTheOneFetchedLongestAgoDroppedFirst( } } -//nolint:paralleltest // one at a time, as the comment at the top of this file says func TestQueriesGoToTheResolverSWWDNSBLResolverNames(t *testing.T) { + t.Parallel() + resolver := &resolverStandIn{answers: map[string]answer{ listedName: {addrs: []string{listing}}, }} -- 2.54.0