diff --git a/internal/reputation/dnsbl_test.go b/internal/reputation/dnsbl_test.go index 0be1a3d..dfe1e74 100644 --- a/internal/reputation/dnsbl_test.go +++ b/internal/reputation/dnsbl_test.go @@ -31,10 +31,12 @@ import ( // this package: Go's resolver counts the queries under way in one // sync.WaitGroup for the whole process, and the process fails when // queries from two bubbles, or from a bubble and from outside one, are -// under way at once. TestMain has the resolver make its configuration, -// which it makes on its first query, outside every bubble, since the -// configuration holds a channel, which the bubble it was made in would -// keep to itself. +// under way at once. The one test outside a bubble is parallel, so it +// starts only once every test that is not parallel has ended; no other +// parallel test of this package queries a resolver. TestMain has the +// resolver make its configuration, which it makes on its first query, +// outside every bubble, since the configuration holds a channel, which +// the bubble it was made in would keep to itself. const ( // zone and otherZone are the DNSBL zones the tests name. @@ -525,8 +527,9 @@ func TestAtMost100000VerdictsKeptTheOneFetchedLongestAgoDroppedFirst( } } -//nolint:paralleltest // one at a time, as the comment at the top of this file says func TestQueriesGoToTheResolverSWWDNSBLResolverNames(t *testing.T) { + t.Parallel() + resolver := &resolverStandIn{answers: map[string]answer{ listedName: {addrs: []string{listing}}, }}