rproxy tests: the visitor that stops a little short gets 408 under load #451

Open
opened 2026-11-19 17:33:22 +01:00 by clawbot · 2 comments
Collaborator

TestAVisitorThatStopsALittleShortIsReadUntilTheRequestTimeLimit in internal/rproxy/limits_test.go failed the race pass of make check once, at a load average of about 360 on 48 cores. It passed on the -v rerun in the same step. The branch under test, issue-436-server-exports-no-parts (cut from next at 809d266), does not touch internal/rproxy.

The failure: limits_test.go:1277: answered 408 "Request Timeout\n", want the app's greeting, after 2.24 s.

The test sets the request time limit to 2 seconds and expects the app's answer before it runs out. On a busy host the answer can take longer, so rproxy answers 408 first. The test phase exits 1 even when the rerun passes, so this can turn next red on its own.

#318 fixed the same kind of failure in two neighbouring tests by moving their limits to minutes. This test still uses 2 seconds, because it also checks that the connection stays open until the limit runs out.

Model: opus-5-5

`TestAVisitorThatStopsALittleShortIsReadUntilTheRequestTimeLimit` in `internal/rproxy/limits_test.go` failed the race pass of `make check` once, at a load average of about 360 on 48 cores. It passed on the `-v` rerun in the same step. The branch under test, `issue-436-server-exports-no-parts` (cut from `next` at `809d266`), does not touch `internal/rproxy`. The failure: `limits_test.go:1277: answered 408 "Request Timeout\n", want the app's greeting`, after 2.24 s. The test sets the request time limit to 2 seconds and expects the app's answer before it runs out. On a busy host the answer can take longer, so rproxy answers `408` first. The test phase exits 1 even when the rerun passes, so this can turn `next` red on its own. https://git.eeqj.de/sneak/smallwebwaf/issues/318 fixed the same kind of failure in two neighbouring tests by moving their limits to minutes. This test still uses 2 seconds, because it also checks that the connection stays open until the limit runs out. Model: opus-5-5
Author
Collaborator

TestAnswersThatCannotBePassedOnOpenTheBreaker in internal/rproxy fails the same way: twice in the race pass of make check at a load average of about 300 on 48 cores, on issue-427-typed-fixed-value-settings (from next at 809d266, no internal/rproxy change). It failed with rproxy_test.go:1549: rproxy did not write "the circuit breaker is open" and passed on the -v rerun.

Model: opus-5-5

`TestAnswersThatCannotBePassedOnOpenTheBreaker` in `internal/rproxy` fails the same way: twice in the race pass of `make check` at a load average of about 300 on 48 cores, on `issue-427-typed-fixed-value-settings` (from `next` at `809d266`, no `internal/rproxy` change). It failed with `rproxy_test.go:1549: rproxy did not write "the circuit breaker is open"` and passed on the `-v` rerun. Model: opus-5-5
Author
Collaborator

Two internal/rproxy tests failed together in the race pass of make check at a load average of about 230 on 48 cores, on issue-431-body-wrapper-fields (from next at 809d266, a change that keeps rproxy's behaviour as it was). Both passed on the -v rerun and on a second make check.

  • TestAVisitorThatStopsALittleShortIsReadUntilTheRequestTimeLimit, this time with 504: limits_test.go:1277: answered 504 "Gateway Timeout\n", want the app's greeting.
  • TestTheRequestTimeLimitDoesNotCutAnAnswerOnceTheAppHasTheRequest, which also uses a 2-second request time limit: limits_test.go:1454: answered 504 "Gateway Timeout\n", want the app's whole answer.

Model: opus-5-5

Two `internal/rproxy` tests failed together in the race pass of `make check` at a load average of about 230 on 48 cores, on `issue-431-body-wrapper-fields` (from `next` at `809d266`, a change that keeps rproxy's behaviour as it was). Both passed on the `-v` rerun and on a second `make check`. - `TestAVisitorThatStopsALittleShortIsReadUntilTheRequestTimeLimit`, this time with `504`: `limits_test.go:1277: answered 504 "Gateway Timeout\n", want the app's greeting`. - `TestTheRequestTimeLimitDoesNotCutAnAnswerOnceTheAppHasTheRequest`, which also uses a 2-second request time limit: `limits_test.go:1454: answered 504 "Gateway Timeout\n", want the app's whole answer`. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/smallwebwaf#451