internal/sww and internal/rproxy tests fail at random when the host is loaded #420

Closed
opened 2026-11-19 09:25:32 +01:00 by clawbot · 1 comment
Collaborator

make check failed twice in the test-race stage on trees that differ from next (dadd576) only in README.md and, in one run, a test in internal/config. A third run of the same tree passed. The host's load average was between 130 and 300 during the runs.

  • First run:
    • TestABodyAnnouncedOverItsLimitIsRefusedOnceWAFAllowsIt/with_the_limit_within_the_first_part in internal/rproxy: "no report".
    • TestBanRefusesItsNetblockAfterARestartWithAnotherScope in internal/sww: status 503, want 200.
    • TestEveryLineIsAlsoSentToTheRemoteLogEndpoint in internal/sww.
  • Second run, all in internal/sww:
    • TestAStatusWAFDoesNotTakeIsReportedAs599;
    • TestStateKeptAcrossRestarts;
    • TestAChunkedBodyStaysABodyAtWAF.

Until this is fixed, any PR's make check can fail at random, including the run on a fresh clone before a merge into next.

Definition of done

  • These tests do not fail because other work slows the host.
  • Each still fails when the behaviour it checks is broken.
  • make check passes.

Model: opus-5-5

`make check` failed twice in the `test-race` stage on trees that differ from `next` (`dadd576`) only in `README.md` and, in one run, a test in `internal/config`. A third run of the same tree passed. The host's load average was between 130 and 300 during the runs. - First run: - `TestABodyAnnouncedOverItsLimitIsRefusedOnceWAFAllowsIt/with_the_limit_within_the_first_part` in `internal/rproxy`: "no report". - `TestBanRefusesItsNetblockAfterARestartWithAnotherScope` in `internal/sww`: status `503`, want `200`. - `TestEveryLineIsAlsoSentToTheRemoteLogEndpoint` in `internal/sww`. - Second run, all in `internal/sww`: - `TestAStatusWAFDoesNotTakeIsReportedAs599`; - `TestStateKeptAcrossRestarts`; - `TestAChunkedBodyStaysABodyAtWAF`. Until this is fixed, any PR's `make check` can fail at random, including the run on a fresh clone before a merge into `next`. ## Definition of done - These tests do not fail because other work slows the host. - Each still fails when the behaviour it checks is broken. - `make check` passes. Model: opus-5-5
Author
Collaborator

#423 on branch issue-420-tests-under-load: the rproxy and sww tests wait a minute for waf instead of rproxy's 2-second default, and the sww tests run waf with the Core Rule Set off so its inspections cannot pass waf's 500 ms check limit and answer 503.

  • Judgement call: waf's 2-second limit for sending the last remote-log lines at shutdown is unchanged; the remote-log test's failure fits a 503 from its first request.

Model: opus-5-5

https://git.eeqj.de/sneak/smallwebwaf/pulls/423 on branch `issue-420-tests-under-load`: the rproxy and sww tests wait a minute for waf instead of rproxy's 2-second default, and the sww tests run waf with the Core Rule Set off so its inspections cannot pass waf's 500 ms check limit and answer 503. - Judgement call: waf's 2-second limit for sending the last remote-log lines at shutdown is unchanged; the remote-log test's failure fits a 503 from its first request. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/smallwebwaf#420