make check failed once on next (aaa9719) with #369 rebased on it, in internal/rproxy, which that PR does not touch. The verbose rerun in the same build and a second make check passed.
Test: TestABodyAnnouncedOverItsLimitIsRefusedOnceWAFAllowsIt/with_the_limit_past_the_first_part, internal/rproxy/limits_test.go line 96.
Error: request: readfrom tcp ...: write: connection reset by peer.
Done when the test cannot fail this way, under load included.
Model: opus-5-5
`make check` failed once on `next` (`aaa9719`) with https://git.eeqj.de/sneak/smallwebwaf/pulls/369 rebased on it, in `internal/rproxy`, which that PR does not touch. The verbose rerun in the same build and a second `make check` passed.
- Test: `TestABodyAnnouncedOverItsLimitIsRefusedOnceWAFAllowsIt/with_the_limit_past_the_first_part`, `internal/rproxy/limits_test.go` line 96.
- Error: `request: readfrom tcp ...: write: connection reset by peer`.
Done when the test cannot fail this way, under load included.
Model: opus-5-5
Cause: visit sends Connection: close, and for such a request Go's server closes the connection after the 413 without reading the rest of the body, which resets it while the client still writes. The test now sends its request on its own connection without that header, so Go's server reads the rest before it closes.
The same behaviour reaches real visitors who send Connection: close: filed as #373.
Model: opus-5-5
PR: https://git.eeqj.de/sneak/smallwebwaf/pulls/372, branch `issue-371-body-over-limit-test-reset`.
Cause: `visit` sends `Connection: close`, and for such a request Go's server closes the connection after the 413 without reading the rest of the body, which resets it while the client still writes. The test now sends its request on its own connection without that header, so Go's server reads the rest before it closes.
The same behaviour reaches real visitors who send `Connection: close`: filed as https://git.eeqj.de/sneak/smallwebwaf/issues/373.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
make checkfailed once onnext(aaa9719) with #369 rebased on it, ininternal/rproxy, which that PR does not touch. The verbose rerun in the same build and a secondmake checkpassed.TestABodyAnnouncedOverItsLimitIsRefusedOnceWAFAllowsIt/with_the_limit_past_the_first_part,internal/rproxy/limits_test.goline 96.request: readfrom tcp ...: write: connection reset by peer.Done when the test cannot fail this way, under load included.
Model: opus-5-5
PR: #372, branch
issue-371-body-over-limit-test-reset.Cause:
visitsendsConnection: close, and for such a request Go's server closes the connection after the 413 without reading the rest of the body, which resets it while the client still writes. The test now sends its request on its own connection without that header, so Go's server reads the rest before it closes.The same behaviour reaches real visitors who send
Connection: close: filed as #373.Model: opus-5-5