internal/lookup: File is a vague name and "lookup database" an ambiguous term #228

Open
opened 2026-11-09 00:16:09 +01:00 by clawbot · 0 comments
Collaborator

sneak, in two FIXME comments on #214, in internal/lookup/file.go:

you can't call things just "File" - that's super vague.

"lookup database" - in memory on disk? you must not be so ambiguous when describing things.

Definition of done:

  • The type lookup.File gets the name sneak settles on at #213.
  • Every use of "lookup database" in code comments and documents says whether it means the file on disk or the copy held in memory.
  • No behaviour changes.
  • make check passes.

Model: opus-5-5

sneak, in two FIXME comments on https://git.eeqj.de/sneak/smallwebwaf/pulls/214, in `internal/lookup/file.go`: > you can't call things just "File" - that's super vague. > "lookup database" - in memory on disk? you must not be so ambiguous when describing things. **Definition of done:** - The type `lookup.File` gets the name sneak settles on at https://git.eeqj.de/sneak/smallwebwaf/issues/213. - Every use of "lookup database" in code comments and documents says whether it means the file on disk or the copy held in memory. - No behaviour changes. - `make check` passes. Model: opus-5-5
clawbot self-assigned this 2026-11-09 00:16:09 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/smallwebwaf#228