Name request log actions so they say what they mean (closes #229)

Rename too_large, rate_limited, rule_blocked and denied, and split banned
into temporarily_banned and permanently_banned by whether the ban runs out.
A client under both a temporary and a permanent ban gets the permanent one.
A request that makes a ban permanent gets permanently_banned. A ban rule, a
trap path or a CrowdSec decision gets the value for the ban it makes, and in
observe mode would_action names the ban enforce mode would have made.

The offence kind rule_blocked follows, as a metric label and a key in
clients.json.

Model: opus-5-5

internal/discriminator/trappaths_test.go

@@ -43,7 +43,7 @@ func TestTrapPathBansAsABanRuleDoes(t *testing.T) {
 
 	// The query is not part of the path.
 	line := s.request(client, "/wp-login.php?redirect_to=x", http.StatusTooManyRequests,
-		requestlog.ActionBanned)
+		requestlog.ActionTemporarilyBanned)
 	wantRuleIDs(t, line)
 
 	if line.BanExpires != requestlog.FormatTime(start.Add(7*24*time.Hour)) {
@@ -77,7 +77,7 @@ func TestTrapPathBansAsABanRuleDoes(t *testing.T) {
 	}
 
 	// The next request is refused under the ban, and makes it permanent.
-	line = s.get(client, http.StatusTooManyRequests, requestlog.ActionBanned)
+	line = s.get(client, http.StatusTooManyRequests, requestlog.ActionPermanentlyBanned)
 	if line.BanExpires != permanent {
 		t.Errorf("log line has ban_expires %q, want permanent", line.BanExpires)
 	}
@@ -89,7 +89,7 @@ func TestTrapPathRefusalNamesItsHeuristicAndPath(t *testing.T) {
 	s, _, _ := startWithClock(t, "", map[string]string{trapPaths: trapPathList})
 
 	line := s.request(client, "/wp-login.php?redirect_to=x", http.StatusForbidden,
-		requestlog.ActionBanned)
+		requestlog.ActionTemporarilyBanned)
 	wantHeuristic(t, line, "trap_paths", `{"path": "/wp-login.php"}`)
 }
 
@@ -100,7 +100,8 @@ func TestTrapPathMatchesThePathDecodedOnce(t *testing.T) {
 
 	// %2577 decodes once to %77, not to w.
 	s.request(otherClient, "/%2577p-login.php", http.StatusOK, requestlog.ActionForward)
-	s.request(client, "/%77p-login.php", http.StatusForbidden, requestlog.ActionBanned)
+	s.request(client, "/%77p-login.php", http.StatusForbidden,
+		requestlog.ActionTemporarilyBanned)
 
 	// The ban's notes give the path as the client sent it.
 	got := server.Ledger.Bans(netip.MustParsePrefix(client + "/32"))
@@ -117,7 +118,8 @@ func TestTrapPathsNeedNoRuleFiles(t *testing.T) {
 		"SWW_RULES_ENABLED": "false",
 	})
 
-	s.request(client, "/xmlrpc.php", http.StatusForbidden, requestlog.ActionBanned)
+	s.request(client, "/xmlrpc.php", http.StatusForbidden,
+		requestlog.ActionTemporarilyBanned)
 }
 
 func TestObserveModeLogsWhatATrapPathWouldDo(t *testing.T) {
@@ -129,7 +131,7 @@ func TestObserveModeLogsWhatATrapPathWouldDo(t *testing.T) {
 	})
 
 	line := s.request(client, "/xmlrpc.php", http.StatusOK, requestlog.ActionForward)
-	wantWouldAction(t, line, requestlog.ActionBanned)
+	wantWouldAction(t, line, requestlog.ActionTemporarilyBanned)
 
 	// No ban was made.
 	s.get(client, http.StatusOK, requestlog.ActionForward)