Give ban causes, limit kinds, alert events, actions and dispositions named types (closes #428)
check / check (push) Failing after 5m25s

Each fixed set of string constants becomes a named string type in the
package that owns it, and the fields and parameters that carry it use
the type: bans.Cause, ratelimit.LimitKind, alerts.Event,
alerts.DestinationName, rules.Action, requestlog.Action,
requestlog.Offence, requestlog.WAFLineKind and waf.Disposition. Every
value keeps its string, so the logs, state files, alerts and metrics do
not change.

The switches exhaustive now checks list their missing cases.

Model: opus-5-5
This commit is contained in:
sneak authored and clawbot committed 2026-11-19 19:48:49 +00:00
1 parent 40386dce6e
commit d0264ff6a7
41 files changed
+358 -248

No files matched your search

+4 -2
View File
@@ -208,7 +208,9 @@ func TestMainWithoutACommandItKnowsPrintsTheCommands(t *testing.T) {
// ask sends waf at addr rproxy's question about a request for path from
// placed, checks the answer's status and disposition, and closes it.
func ask(t *testing.T, addr, path string, status int, disposition string) {
func ask(
t *testing.T, addr, path string, status int, disposition waf.Disposition,
) {
t.Helper()
req, err := http.NewRequestWithContext(t.Context(), http.MethodGet,
@@ -232,7 +234,7 @@ func ask(t *testing.T, addr, path string, status int, disposition string) {
_ = res.Body.Close()
if res.StatusCode != status ||
res.Header.Get(waf.DispositionHeader) != disposition {
res.Header.Get(waf.DispositionHeader) != string(disposition) {
t.Errorf(
"answered %d with disposition %q, want %d with %q",
res.StatusCode,